Fog::Compute[:openstack].images.all returns nil without the patch.
The patch should bring the images collection behaviour in-line with
other collections I think.
The added test should expose the issue.
Updates the OpenStack compute server model so that it stores/handles
metadata correctly on Server create again.
This was a regression from 21499d8 (and should properly handle the
concern there too).
Includes an update to the test that fails without these fixes.
The following patch adds the following missing attributes:
+---------------------------+--------------------------------------+
| Field | Value |
+---------------------------+--------------------------------------+
| provider:network_type | gre |
| provider:physical_network | |
| provider:segmentation_id | 1 |
| router:external | False |
+---------------------------+--------------------------------------+
Not sure if the code style I've used for the attributes is OK though,
I did it so I don't break the 80 col. barrier.
Added also a small test for the new and existing attributes.
Added default security group to the OpenStack compute mocks.
OpenStack server creation mock now stores the security groups for the
created server.
OpenStack security group mock deletion now deletes created security
groups.
OpenStack security group mock list now accepts a server id like the real
implementation.
Altered the paths for EC2 credential requests to remove an extra / in
the request URIs.
Altered Fog::Open::Identity::Real#request to retry only once when given
a 401 error response code. The EC2 API returns 401 when attempting to
fetch nonexistent EC2 credentials instead of something sensible like
404, leading to an infinite loop. Also, the "Bad username or password"
check was removed. My version of OpenStack does not return this message
when a token is expired, but returns the same message as for a missing
EC2 credential.
