Give AR#group an Array instead of a comma separated String
This commit is contained in:
parent
578bd235c9
commit
7f997c7f42
|
@ -14,11 +14,11 @@ class User < ActiveRecord::Base
|
||||||
scope :by_name, -> { order(:name) }
|
scope :by_name, -> { order(:name) }
|
||||||
scope :by_read_count, -> {
|
scope :by_read_count, -> {
|
||||||
cols = if connection.adapter_name == "PostgreSQL"
|
cols = if connection.adapter_name == "PostgreSQL"
|
||||||
column_names.map { |column| %{"users"."#{column}"} }.join(", ")
|
column_names.map { |column| %{"users"."#{column}"} }
|
||||||
else
|
else
|
||||||
'"users"."id"'
|
['"users"."id"']
|
||||||
end
|
end
|
||||||
group(cols).select("count(readerships.id) AS read_count, #{cols}").order('read_count DESC')
|
group(*cols).select("count(readerships.id) AS read_count, #{cols.join(', ')}").order('read_count DESC')
|
||||||
}
|
}
|
||||||
end
|
end
|
||||||
class Authorship < ActiveRecord::Base
|
class Authorship < ActiveRecord::Base
|
||||||
|
|
Loading…
Reference in New Issue