kotovalexarian-likes-github/moby--moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
Code Releases Activity

jsonfilelog_test: check err from open before close

Browse source 
Fix warnings like this one:

> daemon/logger/jsonfilelog/jsonfilelog_test.go:191:3: SA5001: should check returned error before deferring file.Close() (staticcheck)
> 		defer file.Close()
>		^

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This commit is contained in:
Kir Kolyshkin 2019-08-05 20:05:40 -07:00 • committed by Sebastiaan van Stijn
parent 7b0e0335bc
commit 04129678a6
No known key found for this signature in database
GPG key ID: 76698F39D527CE8C
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
daemon/logger/jsonfilelog/jsonfilelog_test.go
View file

@ -188,15 +188,15 @@ func TestJSONFileLoggerWithOpts(t *testing.T) {
}
file, err := os.Open(filename + ".1.gz")
if err != nil {
t.Fatal(err)
}
defer file.Close()
if err != nil {
t.Fatal(err)
}
zipReader, err := gzip.NewReader(file)
defer zipReader.Close()
if err != nil {
t.Fatal(err)
}
defer zipReader.Close()
penUlt, err = ioutil.ReadAll(zipReader)
if err != nil {
t.Fatal(err)
@ -204,15 +204,15 @@ func TestJSONFileLoggerWithOpts(t *testing.T) {
}
file, err := os.Open(filename + ".2.gz")
if err != nil {
t.Fatal(err)
}
defer file.Close()
if err != nil {
t.Fatal(err)
}
zipReader, err := gzip.NewReader(file)
defer zipReader.Close()
if err != nil {
t.Fatal(err)
}
defer zipReader.Close()
antepenult, err := ioutil.ReadAll(zipReader)
if err != nil {
t.Fatal(err)