kotovalexarian-likes-github/mperham--sidekiq
1
0
Fork 0
mirror of https://github.com/mperham/sidekiq.git synced 2022-11-09 13:52:34 -05:00
Code Releases Activity

Remove connection naming, fixes #4479

Browse source
This commit is contained in:
Mike Perham 2020-03-23 10:40:44 -07:00
parent 4ca372160a
commit 05f874edea
3 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Changes.md
View file

@ -2,6 +2,11 @@
[Sidekiq Changes](https://github.com/mperham/sidekiq/blob/master/Changes.md) | [Sidekiq Pro Changes](https://github.com/mperham/sidekiq/blob/master/Pro-Changes.md) | [Sidekiq Enterprise Changes](https://github.com/mperham/sidekiq/blob/master/Ent-Changes.md)
HEAD
---------
- Remove Redis connection naming [#4479]
6.0.6
---------

1
lib/sidekiq/redis_connection.rb
View file

@ -12,7 +12,6 @@ module Sidekiq
options[key.to_sym] = options.delete(key)
end
options[:id] = "Sidekiq-#{Sidekiq.server? ? "server" : "client"}-PID-#{::Process.pid}" unless options.key?(:id)
options[:url] ||= determine_redis_provider
size = if options[:size]

3
test/test_redis_connection.rb
View file

@ -27,7 +27,6 @@ describe Sidekiq::RedisConnection do
it "creates a pooled redis connection" do
pool = Sidekiq::RedisConnection.create
assert_equal Redis, pool.checkout.class
assert_equal "Sidekiq-server-PID-#{$$}", pool.checkout.connection.fetch(:id)
end
# Readers for these ivars should be available in the next release of
@ -207,7 +206,7 @@ describe Sidekiq::RedisConnection do
assert_includes(output, ':host=>"host1", :port=>26379, :password=>"REDACTED"')
assert_includes(output, ':host=>"host2", :port=>26379, :password=>"REDACTED"')
assert_includes(output, ':host=>"host3", :port=>26379, :password=>"REDACTED"')
assert_includes(output, ':password=>"REDACTED", :id=>')
assert_includes(output, ':password=>"REDACTED"')
end
end
end