1
0
Fork 0
mirror of https://github.com/mperham/sidekiq.git synced 2022-11-09 13:52:34 -05:00
mperham--sidekiq/lib
Geoff Harcourt dd0a8476ea
Remove SSL parameters from Redis connection logging to avoid exception (#4532)
In 3f9c4bf9 the Redis connection options began to be cloned (via dumping
and re-marshalling) to avoid issues with password redaction in logging
altering the connection options and breaking authentication with Sentinels.

Unfortunately, this change caused an exception on boot for users of
Redis over SSL. The `OpenSSL::X509::Store` object used for SSL certs is
not yet dumpable in the bundled OpenSSL wrapper for current Rubies
(although it does in master as of ruby/openssl#281).

The fix here prunes the `ssl_params` options out of the Redis
configuration options before the dumping and marshalling. It's probably
better not to include those in logging anyway for privacy purposes.

Fix #4531
2020-04-18 13:00:29 -07:00
..
generators/sidekiq Follow generator configuration to determine the resulting test file (#4371) 2019-11-11 10:37:39 -08:00
sidekiq Remove SSL parameters from Redis connection logging to avoid exception (#4532) 2020-04-18 13:00:29 -07:00
sidekiq.rb Bump standard, fix style issues 2020-03-17 13:38:48 -07:00