Explicitly disable Style/AccessorMethodName for set_transaction_id

This method is doing a lot more than just setting transaction_id for
self, so to me it doesn't make sense to rename it to transaction_id=.
This commit is contained in:
Paul Padier 2016-03-31 17:55:26 +09:00
parent 38c4193b4a
commit 36b4032c09
2 changed files with 1 additions and 6 deletions

View File

@ -20,11 +20,6 @@ Metrics/ModuleLength:
Metrics/PerceivedComplexity:
Max: 16
# Offense count: 1
Style/AccessorMethodName:
Exclude:
- 'lib/paper_trail/has_paper_trail.rb'
# Offense count: 11
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.

View File

@ -456,7 +456,7 @@ module PaperTrail
end
end
def set_transaction_id(version)
def set_transaction_id(version) # rubocop:disable Style/AccessorMethodName
return unless self.class.paper_trail_version_class.column_names.include?("transaction_id")
if PaperTrail.transaction? && PaperTrail.transaction_id.nil?
PaperTrail.transaction_id = version.id