mirror of
https://github.com/puma/puma.git
synced 2022-11-09 13:48:40 -05:00
489f9941b7
Make it more clear that the changelog check is skipped if CI is skipped. Useful when making doc fixes. (Having `[ci skip]` in the commit message wont stop the tests from running when you open a PR.)
1.1 KiB
1.1 KiB
Description
Please describe your pull request. Thank you for contributing! You're the best.
Your checklist for this pull request
- I have reviewed the guidelines for contributing to this repository.
- I have added an entry to History.md if this PR fixes a bug or adds a feature. If it doesn't need an entry to HISTORY.md, I have added
[changelog skip]
or[ci skip]
to the pull request title. - I have added appropriate tests if this PR fixes a bug or adds a feature.
- My pull request is 100 lines added/removed or less so that it can be easily reviewed.
- If this PR doesn't need tests (docs change), I added
[ci skip]
to the title of the PR. - If this closes any issues, I have added "Closes
#issue
" to the PR description or my commit messages. - I have updated the documentation accordingly.
- All new and existing tests passed, including Rubocop.