rails--rails/activerecord/CHANGELOG.md

356 lines
12 KiB
Markdown
Raw Normal View History

* Add support for PostgreSQL 11+ partitioned indexes when using `upsert_all`.
*Sebastián Palma*
* Adds support for `if_not_exists` to `add_column` and `if_exists` to `remove_column`.
Applications can set their migrations to ignore exceptions raised when adding a column that already exists or when removing a column that does not exist.
Example Usage:
```
class AddColumnTitle < ActiveRecord::Migration[6.1]
def change
add_column :posts, :title, :string, if_not_exists: true
end
end
```
```
class RemoveColumnTitle < ActiveRecord::Migration[6.1]
def change
remove_column :posts, :title, if_exists: true
end
end
```
*Eileen M. Uchitelle*
2020-01-27 15:49:59 +00:00
* Regexp-escape table name for MS SQL
Add `Regexp.escape` to one method in ActiveRecord, so that table names with regular expression characters in them work as expected. Since MS SQL Server uses "[" and "]" to quote table and column names, and those characters are regular expression characters, methods like `pluck` and `select` fail in certain cases when used with the MS SQL Server adapter.
*Larry Reid*
Move advisory lock to it's own connection This PR moves advisory lock to it's own connection instead of `ActiveRecord::Base` to fix #37748. As a note the issue is present on both mysql and postgres. We don't see it on sqlite3 because sqlite3 doesn't support advisory locks. The underlying problem only appears if: 1) the app is using multiple databases, and therefore establishing a new connetion in the abstract models 2) the app has a migration that loads a model (ex `Post.update_all`) which causes that new connection to get established. This is because when Rails runs migrations the default connections are established, the lock is taken out on the `ActiveRecord::Base` connection. When the migration that calls a model is loaded, a new connection will be established and the lock will automatically be released. When Rails goes to release the lock in the ensure block it will find that the connection has been closed. Even if the connection wasn't closed the lock would no longer exist on that connection. We originally considered checking if the connection was active, but ultimately that would hide that the advisory locks weren't working correctly because there'd be no lock to release. We also considered making the lock more granular - that it only blocked on each migration individually instead of all the migrations for that connection. This might be the right move going forward, but right now multi-db migrations that load models are very broken in Rails 6.0 and master. John and I don't love this fix, it requires a bit too much knowledge of internals and how Rails picks up connections. However, it does fix the issue, makes the lock more global, and makes the lock more resilient to changing connections. Co-authored-by: John Crepezzi <john.crepezzi@gmail.com>
2020-01-14 17:41:38 +00:00
* Store advisory locks on their own named connection.
Previously advisory locks were taken out against a connection when a migration started. This works fine in single database applications but doesn't work well when migrations need to open new connections which results in the lock getting dropped.
In order to fix this we are storing the advisory lock on a new connection with the connection specification name `AdvisoryLockBase`. The caveat is that we need to maintain at least 2 connections to a database while migrations are running in order to do this.
Move advisory lock to it's own connection This PR moves advisory lock to it's own connection instead of `ActiveRecord::Base` to fix #37748. As a note the issue is present on both mysql and postgres. We don't see it on sqlite3 because sqlite3 doesn't support advisory locks. The underlying problem only appears if: 1) the app is using multiple databases, and therefore establishing a new connetion in the abstract models 2) the app has a migration that loads a model (ex `Post.update_all`) which causes that new connection to get established. This is because when Rails runs migrations the default connections are established, the lock is taken out on the `ActiveRecord::Base` connection. When the migration that calls a model is loaded, a new connection will be established and the lock will automatically be released. When Rails goes to release the lock in the ensure block it will find that the connection has been closed. Even if the connection wasn't closed the lock would no longer exist on that connection. We originally considered checking if the connection was active, but ultimately that would hide that the advisory locks weren't working correctly because there'd be no lock to release. We also considered making the lock more granular - that it only blocked on each migration individually instead of all the migrations for that connection. This might be the right move going forward, but right now multi-db migrations that load models are very broken in Rails 6.0 and master. John and I don't love this fix, it requires a bit too much knowledge of internals and how Rails picks up connections. However, it does fix the issue, makes the lock more global, and makes the lock more resilient to changing connections. Co-authored-by: John Crepezzi <john.crepezzi@gmail.com>
2020-01-14 17:41:38 +00:00
*Eileen M. Uchitelle*, *John Crepezzi*
* Allow schema cache path to be defined in the database configuration file.
For example:
```
development:
adapter: postgresql
database: blog_development
pool: 5
schema_cache_path: tmp/schema/main.yml
```
*Katrina Owen*
* Deprecate `#remove_connection` in favor of `#remove_connection_pool` when called on the handler.
`#remove_connection` is deprecated in order to support returning a `DatabaseConfig` object instead of a `Hash`. Use `#remove_connection_pool`, `#remove_connection` will be removed in 6.2.
*Eileen M. Uchitelle*, *John Crepezzi*
* Deprecate `#default_hash` and it's alias `#[]` on database configurations
Applications should use `configs_for`. `#default_hash` and `#[]` will be removed in 6.2.
*Eileen M. Uchitelle*, *John Crepezzi*
* Add scale support to `ActiveRecord::Validations::NumericalityValidator`.
*Gannon McGibbon*
* Find orphans by looking for missing relations through chaining `where.missing`:
Before:
```ruby
Post.left_joins(:author).where(authors: { id: nil })
```
After:
```ruby
Post.where.missing(:author)
```
*Tom Rossi*
* Ensure `:reading` connections always raise if a write is attempted.
Now Rails will raise an `ActiveRecord::ReadOnlyError` if any connection on the reading handler attempts to make a write. If your reading role needs to write you should name the role something other than `:reading`.
*Eileen M. Uchitelle*
Deprecate "primary" as a connection_specification_name for ActiveRecord::Base As multiple databases have evolved it's becoming more and more confusing that we have a `connection_specification_name` that defaults to "primary" and a `spec_name` on the database objects that defaults to "primary" (my bad). Even more confusing is that we use the class name for all non-ActiveRecord::Base abstract classes that establish connections. For example connections established on `class MyOtherDatabaseModel < ApplicationRecord` will use `"MyOtherDatabaseModel"` as it's connection specification name while `ActiveRecord::Base` uses `"primary"`. This PR deprecates the use of the name `"primary"` as the `connection_specification_name` for `ActiveRecord::Base` in favor of using `"ActiveRecord::Base"`. In this PR the following is true: * If `handler.establish_connection(:primary)` is called, `"primary"` will not throw a deprecation warning and can still be used for the `connection_specification_name`. This also fixes a bug where using this method to establish a connection could accidentally overwrite the actual `ActiveRecord::Base` connection IF that connection was not using a configuration named `:primary`. * Calling `handler.retrieve_connection "primary"` when `handler.establish_connection :primary` has never been called will return the connection for `ActiveRecord::Base` and throw a deprecation warning. * Calling `handler.remove_connection "primary"` when `handler.establish_connection :primary` has never been called will remove the connection for `ActiveRecord::Base` and throw a deprecation warning. See #38179 for details on more motivations for this change. Co-authored-by: John Crepezzi <john.crepezzi@gmail.com>
2020-01-07 21:40:15 +00:00
* Deprecate "primary" as the connection_specification_name for ActiveRecord::Base
`"primary"` has been deprecated as the `connection_specification_name` for `ActiveRecord::Base` in favor of using `"ActiveRecord::Base"`. This change affects calls to `ActiveRecord::Base.connection_handler.retrieve_connection` and `ActiveRecord::Base.connection_handler.remove_connection`. If you're calling these methods with `"primary"`, please switch to `"ActiveRecord::Base"`.
*Eileen M. Uchitelle*, *John Crepezzi*
* Add `ActiveRecord::Validations::NumericalityValidator` with
support for casting floats using a database columns' precision value.
*Gannon McGibbon*
* Enforce fresh ETag header after a collection's contents change by adding
ActiveRecord::Relation#cache_key_with_version. This method will be used by
ActionController::ConditionalGet to ensure that when collection cache versioning
is enabled, requests using ConditionalGet don't return the same ETag header
after a collection is modified. Fixes #38078.
*Aaron Lipman*
* Skip test database when running `db:create` or `db:drop` in development
with `DATABASE_URL` set.
*Brian Buchalter*
* Don't allow mutations on the database configurations hash.
2019-12-19 17:25:39 +00:00
Freeze the configurations hash to disallow directly changing it. If applications need to change the hash, for example to create databases for parallelization, they should use the `DatabaseConfig` object directly.
2019-12-19 17:25:39 +00:00
Before:
```ruby
@db_config = ActiveRecord::Base.configurations.configs_for(env_name: "test", spec_name: "primary")
@db_config.configuration_hash.merge!(idle_timeout: "0.02")
```
After:
```ruby
@db_config = ActiveRecord::Base.configurations.configs_for(env_name: "test", spec_name: "primary")
config = @db_config.configuration_hash.merge(idle_timeout: "0.02")
db_config = ActiveRecord::DatabaseConfigurations::HashConfig.new(@db_config.env_name, @db_config.spec_name, config)
```
*Eileen M. Uchitelle*, *John Crepezzi*
* Remove `:connection_id` from the `sql.active_record` notification.
*Aaron Patterson*, *Rafael Mendonça França*
* The `:name` key will no longer be returned as part of `DatabaseConfig#configuration_hash`. Please use `DatabaseConfig#owner_name` instead.
*Eileen M. Uchitelle*, *John Crepezzi*
* ActiveRecord's `belongs_to_required_by_default` flag can now be set per model.
You can now opt-out/opt-in specific models from having their associations required
by default.
This change is meant to ease the process of migrating all your models to have
their association required.
*Edouard Chin*
* The `connection_config` method has been deprecated, please use `connection_db_config` instead which will return a `DatabaseConfigurations::DatabaseConfig` instead of a `Hash`.
*Eileen M. Uchitelle*, *John Crepezzi*
* Retain explicit selections on the base model after applying `includes` and `joins`.
Resolves #34889.
*Patrick Rebsch*
* The `database` kwarg is deprecated without replacement because it can't be used for sharding and creates an issue if it's used during a request. Applications that need to create new connections should use `connects_to` instead.
*Eileen M. Uchitelle*, *John Crepezzi*
2019-11-13 22:35:28 +00:00
* Allow attributes to be fetched from Arel node groupings.
*Jeff Emminger*, *Gannon McGibbon*
2019-12-18 07:46:48 +00:00
* A database URL can now contain a querystring value that contains an equal sign. This is needed to support passing PostgreSQL `options`.
*Joshua Flanagan*
* Calling methods like `establish_connection` with a `Hash` which is invalid (eg: no `adapter`) will now raise an error the same way as connections defined in `config/database.yml`.
*John Crepezzi*
* Specifying `implicit_order_column` now subsorts the records by primary key if available to ensure deterministic results.
*Paweł Urbanek*
* `where(attr => [])` now loads an empty result without making a query.
*John Hawthorn*
* Fixed the performance regression for `primary_keys` introduced MySQL 8.0.
*Hiroyuki Ishii*
* Add support for `belongs_to` to `has_many` inversing.
*Gannon McGibbon*
* Allow length configuration for `has_secure_token` method. The minimum length
is set at 24 characters.
Before:
```ruby
has_secure_token :auth_token
```
After:
```ruby
has_secure_token :default_token # 24 characters
has_secure_token :auth_token, length: 36 # 36 characters
has_secure_token :invalid_token, length: 12 # => ActiveRecord::SecureToken::MinimumLengthError
```
*Bernardo de Araujo*
* Deprecate `DatabaseConfigurations#to_h`. These connection hashes are still available via `ActiveRecord::Base.configurations.configs_for`.
*Eileen Uchitelle*, *John Crepezzi*
* Add `DatabaseConfig#configuration_hash` to return database configuration hashes with symbol keys, and use all symbol-key configuration hashes internally. Deprecate `DatabaseConfig#config` which returns a String-keyed `Hash` with the same values.
*John Crepezzi*, *Eileen Uchitelle*
* Allow column names to be passed to `remove_index` positionally along with other options.
Passing other options can be necessary to make `remove_index` correctly reversible.
Before:
add_index :reports, :report_id # => works
add_index :reports, :report_id, unique: true # => works
remove_index :reports, :report_id # => works
remove_index :reports, :report_id, unique: true # => ArgumentError
After:
remove_index :reports, :report_id, unique: true # => works
*Eugene Kenny*
* Allow bulk `ALTER` statements to drop and recreate indexes with the same name.
*Eugene Kenny*
* `insert`, `insert_all`, `upsert`, and `upsert_all` now clear the query cache.
*Eugene Kenny*
* Call `while_preventing_writes` directly from `connected_to`.
In some cases application authors want to use the database switching middleware and make explicit calls with `connected_to`. It's possible for an app to turn off writes and not turn them back on by the time we call `connected_to(role: :writing)`.
This change allows apps to fix this by assuming if a role is writing we want to allow writes, except in the case it's explicitly turned off.
*Eileen M. Uchitelle*
* Improve detection of ActiveRecord::StatementTimeout with mysql2 adapter in the edge case when the query is terminated during filesort.
*Kir Shatrov*
* Stop trying to read yaml file fixtures when loading Active Record fixtures.
*Gannon McGibbon*
* Deprecate `.reorder(nil)` with `.first` / `.first!` taking non-deterministic result.
To continue taking non-deterministic result, use `.take` / `.take!` instead.
*Ryuta Kamizono*
* Ensure custom PK types are casted in through reflection queries.
*Gannon McGibbon*
* Preserve user supplied joins order as much as possible.
Fixes #36761, #34328, #24281, #12953.
*Ryuta Kamizono*
2019-07-29 17:48:57 +00:00
* Allow `matches_regex` and `does_not_match_regexp` on the MySQL Arel visitor.
*James Pearson*
2019-07-29 17:48:57 +00:00
* Allow specifying fixtures to be ignored by setting `ignore` in YAML file's '_fixture' section.
*Tongfei Gao*
* Make the DATABASE_URL env variable only affect the primary connection. Add new env variables for multiple databases.
*John Crepezzi*, *Eileen Uchitelle*
* Add a warning for enum elements with 'not_' prefix.
class Foo
enum status: [:sent, :not_sent]
end
*Edu Depetris*
2019-11-24 00:20:00 +00:00
* Make currency symbols optional for money column type in PostgreSQL.
*Joel Schneider*
* Add support for beginless ranges, introduced in Ruby 2.7.
*Josh Goodall*
* Add database_exists? method to connection adapters to check if a database exists.
*Guilherme Mansur*
* Loading the schema for a model that has no `table_name` raises a `TableNotSpecified` error.
*Guilherme Mansur*, *Eugene Kenny*
* PostgreSQL: Fix GROUP BY with ORDER BY virtual count attribute.
Fixes #36022.
*Ryuta Kamizono*
* Make ActiveRecord `ConnectionPool.connections` method thread-safe.
Fixes #36465.
*Jeff Doering*
* Add support for multiple databases to `rails db:abort_if_pending_migrations`.
*Mark Lee*
* Fix sqlite3 collation parsing when using decimal columns.
*Martin R. Schuster*
* Fix invalid schema when primary key column has a comment.
Fixes #29966.
*Guilherme Goettems Schneider*
* Fix table comment also being applied to the primary key column.
*Guilherme Goettems Schneider*
* Allow generated `create_table` migrations to include or skip timestamps.
*Michael Duchemin*
2019-04-24 19:57:14 +00:00
Please check [6-0-stable](https://github.com/rails/rails/blob/6-0-stable/activerecord/CHANGELOG.md) for previous changes.