rails--rails/activejob/test/jobs/raising_job.rb

# frozen_string_literal: true

class RaisingJob < ActiveJob::Base
  MyError = Class.new(StandardError)

  retry_on(MyError, attempts: 2)

  def perform(error = "RaisingJob::MyError")
    raise error.constantize
  end
end
Fix ActiveJob Test adapter not respecting retry attempts: - ### Problem Given the below example the test adapter will retry the job indefinitely: ```ruby class BuggyJob < ActiveJob::Base retry_on(Exception, attempts: 2) def perform raise "error" end end BuggyJob.perform_later perform_enqueued_jobs ``` The problem is that when the job get retried, the `exception_executions` variable is not serialized/deserialized, resulting in ActiveJob to not be able to determine how many time this job was retried. The solution in this PR is to deserialize the whole job in the test adapter, and reserialize it before retrying. Fix #38391 2020-02-05 22:59:03 -05:00			`# frozen_string_literal: true`

			`class RaisingJob < ActiveJob::Base`
			`MyError = Class.new(StandardError)`

			`retry_on(MyError, attempts: 2)`

Fix AJ `TestAdapter#performed_jobs` not properly counting job: - ### Problem If we use `perform_enqueued_jobs` without a block, a job that raises an error wouldn't be appended to the list of `performed_jobs`. ### Solution Push the job in the array before it is actually performed. 2020-03-09 19:29:41 -04:00			`def perform(error = "RaisingJob::MyError")`
			`raise error.constantize`
Fix ActiveJob Test adapter not respecting retry attempts: - ### Problem Given the below example the test adapter will retry the job indefinitely: ```ruby class BuggyJob < ActiveJob::Base retry_on(Exception, attempts: 2) def perform raise "error" end end BuggyJob.perform_later perform_enqueued_jobs ``` The problem is that when the job get retried, the `exception_executions` variable is not serialized/deserialized, resulting in ActiveJob to not be able to determine how many time this job was retried. The solution in this PR is to deserialize the whole job in the test adapter, and reserialize it before retrying. Fix #38391 2020-02-05 22:59:03 -05:00			`end`
			`end`