kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Fix regular expression on s3 test URL generation test (#44)

Browse source 
So tests are passing if the bucket name is rails-active storage.
But developers specify their own s3 tests configuration (in my case was
activestorage-test) then this regex fails.

Also the first part is dynamic and based on bucket name and region
This commit is contained in:
Dino Maric 2017-07-13 21:54:06 +02:00 committed by David Heinemeier Hansson
parent 50bec56254
commit 14e6386b3c
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
test/service/s3_service_test.rb
View file

@ -38,7 +38,7 @@ if SERVICE_CONFIGURATIONS[:s3]
end end
test "signed URL generation" do test "signed URL generation" do
assert_match /rails-activestorage\.s3\.amazonaws\.com.*response-content-disposition=inline.*avatar\.png/, assert_match /.+s3.+amazonaws.com.*response-content-disposition=inline.*avatar\.png/,
@service.url(FIXTURE_KEY, expires_in: 5.minutes, disposition: :inline, filename: "avatar.png") @service.url(FIXTURE_KEY, expires_in: 5.minutes, disposition: :inline, filename: "avatar.png")
end end
end end