kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Fix ids_reader to respect case sensitive primary key

Browse source 
```ruby
  car = Car.create!(name: "Tofaş")

  # Before
  car.bulb_ids # => SELECT "bulbs".ID FROM "bulbs" WHERE "bulbs"."name" = $1 AND "bulbs"."car_id" = $2  [["name", "defaulty"], ["car_id", 3]]

  # After
  car.bulb_ids # => SELECT "bulbs"."ID" FROM "bulbs" WHERE "bulbs"."name" = $1 AND "bulbs"."car_id" = $2  [["name", "defaulty"], ["car_id", 3]]
```
This commit is contained in:
Ryuta Kamizono 2017-06-28 21:59:28 +09:00
parent d766b64b7e
commit bf3f201000
2 changed files with 2 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
activerecord/lib/active_record/associations/collection_association.rb
View file

@ -44,10 +44,7 @@ module ActiveRecord
if loaded? if loaded?
target.pluck(reflection.association_primary_key) target.pluck(reflection.association_primary_key)
else else
@association_ids ||= ( @association_ids ||= scope.pluck(reflection.association_primary_key)
column = "#{reflection.quoted_table_name}.#{reflection.association_primary_key}"
scope.pluck(column)
)
end end
end end

2
activerecord/test/schema/schema.rb
View file

@ -107,7 +107,7 @@ ActiveRecord::Schema.define do
t.boolean :has_fun, null: false, default: false t.boolean :has_fun, null: false, default: false
end end
create_table :bulbs, force: true do |t| create_table :bulbs, primary_key: "ID", force: true do |t|
t.integer :car_id t.integer :car_id
t.string :name t.string :name
t.boolean :frickinawesome, default: false t.boolean :frickinawesome, default: false