kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity
74541 commits 72 branches 493 tags 355 MiB
Commit graph

20 commits

Author SHA1 Message Date
Ryuta Kamizono
e4a0a04883 Strip duplicated suffixes more strictly 
In the previous code incorrectly removes intermediate words.
 2018-04-22 14:30:07 +09:00
Yoshiyuki Hirano
8e2c91df4a Fix duplicated suffix for JobGenerator 2018-04-22 12:09:04 +09:00
Rafael Mendonça França
8dd76a7a6f
Use .tt extension to all the template files 
Make clear that the files are not to be run for interpreters.

Fixes #23847.
Fixes #30690.
Closes #23878.
 2017-11-13 15:23:28 -05:00
Koichi ITO
aa28c5ca65 [Active Job] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
Kir Shatrov
14ece5e429 Use frozen-string-literal in ActiveJob 2017-07-09 20:50:52 +03:00
Matthew Draper
87b3e226d6 Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" 
This reverts commit 3420a14590, reversing
changes made to afb66a5a59.
 2017-07-02 02:15:17 +09:30
Kir Shatrov
cfade1ec7e Enforce frozen string in Rubocop 2017-07-01 02:11:03 +03:00
bogdanvlviv
40bdbce191
Define path with __dir__ 
".. with __dir__ we can restore order in the Universe." - by @fxn

Related to 5b8738c2df
 2017-05-23 00:53:51 +03:00
Akira Matsuda
5473e390d3 self. is not needed when calling its own instance method 
Actually, private methods cannot be called with `self.`, so it's not just redundant, it's a bad habit in Ruby
 2017-01-05 19:58:52 +09:00
Rafael Mendonça França
b6ffb5efcb
Revert "Merge pull request #27550 from mtsmfm/fix-generator-command-for-nested-rails-engine" 
This reverts commit 1e969bfb98, reversing
changes made to a5041f267d.

Reason: It breaks the public API
 2017-01-03 21:51:18 -05:00
Fumiaki MATSUSHIMA
085546df45 Fix generator command for nested (namespaced) rails engine 
If we create nested (namespaced) rails engine such like bukkits-admin,
`bin/rails g scaffold User name:string age:integer`
will create
`bukkits-admin/app/controllers/bukkits/users_controller.rb`
but it should create
`bukkits-admin/app/controllers/bukkits/admin/users_controller.rb`.

In #6643, we changed `namespaced_path` as root path
because we supposed application_controller is always in root
but nested rails engine's application_controller will not.
 2017-01-03 21:18:09 +09:00
Xavier Noria
80e66cc4d9 normalizes indentation and whitespace across the project 2016-08-06 20:16:27 +02:00
Xavier Noria
93c9534c98 applies new string literal convention in activejob/lib 
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
 2016-08-06 18:40:07 +02:00
David Heinemeier Hansson
01a69e27a4 Offer invitations to use retry_on/discard_on for common cases 2016-08-04 14:57:10 -07:00
yuuji.yaginuma
9a9fc01af0 generate ApplicationJob if it does not already exist 
ActiveJob jobs now inherit from ApplicationJob by default.
However, when updating to Rails 5 from the old Rails,
since there is a possibility that ApplicationJob does not exist.
 2016-03-25 13:21:37 +09:00
Zachary Scott
80ee55f3b8 Rails should be nodoc'd here [ci skip] 2015-04-29 18:44:37 -07:00
Jeroen van Baarsen
929a794a31 Add explicit base class for ActiveJob jobs 
* Jobs generated now inherent from ApplicationJob
* ApplicationJob inherents from ActiveJob::Base
* Added entry to changelog

Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
 2015-03-23 22:37:11 +01:00
Abdelkader Boudih
e63a02ccfb [ActiveJob] Add hook for test_framework and test templates 2014-08-22 20:06:22 +00:00
Cristian Bica
c2f1eca194 Suggest the perform method can take arguments when generating an ActiveJob job 2014-08-15 23:35:06 +03:00
Cristian Bica
3ed69cd5f5 Fixed failing tests; Load active_job in railtie; Renamed generator to job 2014-08-12 13:53:46 +03:00