kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity
rails--rails/actiontext/CHANGELOG.md
Sean Doyle 614580270d Locate fill_in_rich_text_area by <label> text 
This commit dovetails with [#38551] in its focus on improving the
ability to test calls to `rich_text_area` in accessibility-minded ways.

In addition to searching for `<trix-editor>` elements with the
appropriate [`aria-label`][aria-label] attribute, also support locating
elements that match the corresponding `<label>` element's text.

Now that [basecamp/trix#829][] has been merged and released, clicking on
`<label>` elements that reference `<trix-editor>` elements will move
focus into the `<trix-editor>` element.

There are still some accessible [label text][] improvements that could
be made, but extending `fill_in_rich_text_area` to account for `<label
for="...">` elements is a good start.

[#38551]: https://github.com/rails/rails/pull/38551
[aria-label]: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_aria-label_attribute
[basecamp/trix#829]: https://github.com/basecamp/trix/pull/829
[label text]: https://github.com/basecamp/trix/pull/829#issuecomment-699119852
2020-10-02 18:02:14 -04:00

1.7 KiB
Raw Blame History

  • Locate fill_in_rich_text_area by <label> text

    In addition to searching for <trix-editor> elements with the appropriate aria-label attribute, also support locating elements that match the corresponding <label> element's text.

    Sean Doyle

  • Be able to add a default value to rich_text_area.

    form.rich_text_area :content, value: "<h1>Hello world</h1>"
#=> <input type="hidden" name="message[content]" id="message_content_trix_input_message_1" value="<h1>Hello world</h1>">

    Paulo Ancheta

  • Add method to confirm rich text content existence by adding ? after rich text attribute.

    message = Message.create!(body: "<h1>Funny times!</h1>")
message.body? #=> true

    Kyohei Toyoda

  • The fill_in_rich_text_area system test helper locates a Trix editor and fills it in with the given HTML.

    # <trix-editor id="message_content" ...></trix-editor>
fill_in_rich_text_area "message_content", with: "Hello <em>world!</em>"

# <trix-editor placeholder="Your message here" ...></trix-editor>
fill_in_rich_text_area "Your message here", with: "Hello <em>world!</em>"

# <trix-editor aria-label="Message content" ...></trix-editor>
fill_in_rich_text_area "Message content", with: "Hello <em>world!</em>"

# <input id="trix_input_1" name="message[content]" type="hidden">
# <trix-editor input="trix_input_1"></trix-editor>
fill_in_rich_text_area "message[content]", with: "Hello <em>world!</em>"

    George Claghorn

Please check 6-0-stable for previous changes.