mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
eede8d8130
ActionView::Template instances compile their source to methods on the
ActionView::CompiledTemplates module. To prevent leaks in development
mode, where templates can frequently change, a finalizer is added that
undefines these methods[1] when the templates are garbage-collected.
This is undesirable in the test environment, however, as templates don't
change during the life of the test. Moreover, the cost of undefining a
method is proportional to the number of descendants a class or module
has, since the method cache must be cleared for all descendant classes.
As ActionView::CompiledTemplates is mixed into every
ActionView::TestCase (or in RSpec suites, every view spec example
group), it can end up with a very large number of descendants, and
undefining its methods can become very expensive.
In large test suites, this results in a long delay at the end of the
test suite as all template finalizers are run, only for the process to
then exit.
To avoid this unnecessary cost, this change adds a config option,
`action_view.finalize_compiled_template_methods`, defaulting to true,
and sets it to false in the test environment only.
[1] 09b2348f7f/actionview/lib/action_view/template.rb (L118-L126)
54 lines
1.8 KiB
Markdown
54 lines
1.8 KiB
Markdown
* Disable `ActionView::Template` finalizers in test environment
|
|
|
|
Template finalization can be expensive in large view test suites.
|
|
Add a configuration option,
|
|
`action_view.finalize_compiled_template_methods`, and turn it off in
|
|
the test environment.
|
|
|
|
*Simon Coffey*
|
|
|
|
* Extract the `confirm` call in its own, overridable method in `rails_ujs`.
|
|
Example :
|
|
Rails.confirm = function(message, element) {
|
|
return (my_bootstrap_modal_confirm(message));
|
|
}
|
|
|
|
*Mathieu Mahé*
|
|
|
|
* Enable select tag helper to mark `prompt` option as `selected` and/or `disabled` for `required`
|
|
field. Example:
|
|
|
|
select :post,
|
|
:category,
|
|
["lifestyle", "programming", "spiritual"],
|
|
{ selected: "", disabled: "", prompt: "Choose one" },
|
|
{ required: true }
|
|
|
|
Placeholder option would be selected and disabled. The HTML produced:
|
|
|
|
<select required="required" name="post[category]" id="post_category">
|
|
<option disabled="disabled" selected="selected" value="">Choose one</option>
|
|
<option value="lifestyle">lifestyle</option>
|
|
<option value="programming">programming</option>
|
|
<option value="spiritual">spiritual</option></select>
|
|
|
|
*Sergey Prikhodko*
|
|
|
|
* Don't enforce UTF-8 by default.
|
|
|
|
With the disabling of TLS 1.0 by most major websites, continuing to run
|
|
IE8 or lower becomes increasingly difficult so default to not enforcing
|
|
UTF-8 encoding as it's not relevant to other browsers.
|
|
|
|
*Andrew White*
|
|
|
|
* Change translation key of `submit_tag` from `module_name_class_name` to `module_name/class_name`.
|
|
|
|
*Rui Onodera*
|
|
|
|
* Rails 6 requires Ruby 2.4.1 or newer.
|
|
|
|
*Jeremy Daer*
|
|
|
|
|
|
Please check [5-2-stable](https://github.com/rails/rails/blob/5-2-stable/actionview/CHANGELOG.md) for previous changes.
|