132 lines
5.1 KiB
Markdown
132 lines
5.1 KiB
Markdown
* Make `fixture_file_upload` work in integration tests.
|
|
|
|
*Yuji Yaginuma*
|
|
|
|
* Add `to_param` to `ActionController::Parameters` deprecations.
|
|
|
|
In the future `ActionController::Parameters` are discouraged from being used
|
|
in URLs without explicit whitelisting. Go through `to_h` to use `to_param`.
|
|
|
|
*Kir Shatrov*
|
|
|
|
* Fix nested multiple roots
|
|
|
|
The PR #20940 enabled the use of multiple roots with different constraints
|
|
at the top level but unfortunately didn't work when those roots were inside
|
|
a namespace and also broke the use of root inside a namespace after a top
|
|
level root was defined because the check for the existence of the named route
|
|
used the global :root name and not the namespaced name.
|
|
|
|
This is fixed by using the name_for_action method to expand the :root name to
|
|
the full namespaced name. We can pass nil for the second argument as we're not
|
|
dealing with resource definitions so don't need to handle the cases for edit
|
|
and new routes.
|
|
|
|
Fixes #26148.
|
|
|
|
*Ryo Hashimoto*, *Andrew White*
|
|
|
|
* Include the content of the flash in the auto-generated etag. This solves the following problem:
|
|
|
|
1. POST /messages
|
|
2. redirect_to messages_url, notice: 'Message was created'
|
|
3. GET /messages/1
|
|
4. GET /messages
|
|
|
|
Step 4 would before still include the flash message, even though it's no longer relevant,
|
|
because the etag cache was recorded with the flash in place and didn't change when it was gone.
|
|
|
|
*DHH*
|
|
|
|
* SSL: Changes redirect behavior for all non-GET and non-HEAD requests
|
|
(like POST/PUT/PATCH etc) to `http://` resources to redirect to `https://`
|
|
with a [307 status code](http://tools.ietf.org/html/rfc7231#section-6.4.7) instead of [301 status code](http://tools.ietf.org/html/rfc7231#section-6.4.2).
|
|
|
|
307 status code instructs the HTTP clients to preserve the original
|
|
request method while redirecting. It has been part of HTTP RFC since
|
|
1999 and is implemented/recognized by most (if not all) user agents.
|
|
|
|
# Before
|
|
POST http://example.com/articles (i.e. ArticlesContoller#create)
|
|
redirects to
|
|
GET https://example.com/articles (i.e. ArticlesContoller#index)
|
|
|
|
# After
|
|
POST http://example.com/articles (i.e. ArticlesContoller#create)
|
|
redirects to
|
|
POST https://example.com/articles (i.e. ArticlesContoller#create)
|
|
|
|
*Chirag Singhal*
|
|
|
|
* Add `:as` option to `ActionController:TestCase#process` and related methods.
|
|
|
|
Specifying `as: mime_type` allows the `CONTENT_TYPE` header to be specified
|
|
in controller tests without manually doing this through `@request.headers['CONTENT_TYPE']`.
|
|
|
|
*Everest Stefan Munro-Zeisberger*
|
|
|
|
* Show cache hits and misses when rendering partials.
|
|
|
|
Partials using the `cache` helper will show whether a render hit or missed
|
|
the cache:
|
|
|
|
```
|
|
Rendered messages/_message.html.erb in 1.2 ms [cache hit]
|
|
Rendered recordings/threads/_thread.html.erb in 1.5 ms [cache miss]
|
|
```
|
|
|
|
This removes the need for the old fragment cache logging:
|
|
|
|
```
|
|
Read fragment views/v1/2914079/v1/2914079/recordings/70182313-20160225015037000000/d0bdf2974e1ef6d31685c3b392ad0b74 (0.6ms)
|
|
Rendered messages/_message.html.erb in 1.2 ms [cache hit]
|
|
Write fragment views/v1/2914079/v1/2914079/recordings/70182313-20160225015037000000/3b4e249ac9d168c617e32e84b99218b5 (1.1ms)
|
|
Rendered recordings/threads/_thread.html.erb in 1.5 ms [cache miss]
|
|
```
|
|
|
|
Though that full output can be reenabled with
|
|
`config.action_controller.enable_fragment_cache_logging = true`.
|
|
|
|
*Stan Lo*
|
|
|
|
* Don't override the `Accept` header in integration tests when called with `xhr: true`.
|
|
|
|
Fixes #25859.
|
|
|
|
*David Chen*
|
|
|
|
* Fix `defaults` option for root route.
|
|
|
|
A regression from some refactoring for the 5.0 release, this change
|
|
fixes the use of `defaults` (default parameters) in the `root` routing method.
|
|
|
|
*Chris Arcand*
|
|
|
|
* Check `request.path_parameters` encoding at the point they're set.
|
|
|
|
Check for any non-UTF8 characters in path parameters at the point they're
|
|
set in `env`. Previously they were checked for when used to get a controller
|
|
class, but this meant routes that went directly to a Rack app, or skipped
|
|
controller instantiation for some other reason, had to defend against
|
|
non-UTF8 characters themselves.
|
|
|
|
*Grey Baker*
|
|
|
|
* Don't raise `ActionController::UnknownHttpMethod` from `ActionDispatch::Static`.
|
|
|
|
Pass `Rack::Request` objects to `ActionDispatch::FileHandler` to avoid it
|
|
raising `ActionController::UnknownHttpMethod`. If an unknown method is
|
|
passed, it should pass exception higher in the stack instead, once we've had a
|
|
chance to define exception handling behaviour.
|
|
|
|
*Grey Baker*
|
|
|
|
* Handle `Rack::QueryParser` errors in `ActionDispatch::ExceptionWrapper`.
|
|
|
|
Updated `ActionDispatch::ExceptionWrapper` to handle the Rack 2.0 namespace
|
|
for `ParameterTypeError` and `InvalidParameterError` errors.
|
|
|
|
*Grey Baker*
|
|
|
|
Please check [5-0-stable](https://github.com/rails/rails/blob/5-0-stable/actionpack/CHANGELOG.md) for previous changes.
|