1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
rails--rails/activestorage/test/models
Alex Ghiculescu 550d728bd1 Active Storage: incorrect defaults
https://github.com/rails/rails/pull/42225 identified that some of the content types used as defaults by Active Storage aren't recognized by `mini_mime`. This means that in practice code like [this](https://github.com/rails/rails/pull/42225/files#diff-7a3ec24c556b138abdbd67066ab5125b73528e45891d83142e417d3944194128R116) will crash or not function correctly. In [this](https://github.com/rails/rails/pull/42225/files#diff-c2010824d2d2e8d841ff4fc058c264c12d870e893025b153e6de571fba6b6c6cR194) example, a file with content_type `image/jpg` is treated as a PNG by the representer, since `image/jpg` isn't a valid content type according to `mini_mime`.

I don't think the default content_types should include formats that have never actually worked, so I'm proposing we remove them from the defaults.
2021-09-22 16:38:52 -05:00
..
attached Slient the deprecation warning for ActiveStorage.replace_on_assign_to_many logged in test cases 2021-08-10 22:14:52 +05:30
attachment_test.rb Enable Style/ExplicitBlockArgument cop 2021-09-05 17:06:19 +02:00
blob_test.rb Active Storage: incorrect defaults 2021-09-22 16:38:52 -05:00
filename_test.rb Enable Performance/UnfreezeString cop 2018-09-23 08:56:55 +09:00
presence_validation_test.rb Store newly-uploaded files on save rather than assignment 2018-07-07 23:25:33 -04:00
preview_test.rb Make vips the default variant processor for new apps 2021-07-14 14:26:43 -03:00
reflection_test.rb Named variants should be defined using block syntax 2020-05-04 13:04:14 +03:00
representation_test.rb Make vips the default variant processor for new apps 2021-07-14 14:26:43 -03:00
strict_loading_test.rb Add strict loading for active storage 2020-11-16 22:09:15 +08:00
variant_test.rb Active Storage: incorrect defaults 2021-09-22 16:38:52 -05:00
variant_with_record_test.rb Make vips the default variant processor for new apps 2021-07-14 14:26:43 -03:00