kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity
rails--rails/actionview/CHANGELOG.md
neumayr ead4776b82 Fix field_error_proc wrap form select optgroup and divider option tag 
### Summary

The [`:field_error_proc`](https://github.com/rails/rails/blob/master/actionview/lib/action_view/base.rb#L145) is responsible for decorating input tags that refer to attributes with errors. This default build-in rails feature wrap invalid form elements with additional markup: `<div class="field_with_errors">[…]</div>`.

* Fix for `field_error_proc` wraps form select `optgroup`
* Fix for `field_error_proc` wraps form select divider `option`
* Add tests for uncovered elements with errors

[Fixes #31088]

#### Test coverage
* `test_select_grouped_options_with_errors`
* `test_time_zone_select_with_priority_zones_and_errors`

#### Extend test coverage
* `test_collection_select_with_errors`
* `test_label_with_errors`
* `test_check_box_with_errors`
* `test_check_boxes_with_errors`
* `test_radio_button_with_errors`
* `test_radio_buttons_with_errors`
* `test_collection_check_boxes_with_errors`
* `test_collection_radio_buttons_with_errors`
2017-11-09 17:37:06 +01:00

1 KiB
Raw Blame History

  • Fix issues with field_error_proc wrapping optgroup and select divider option.

    Fixes #31088

    Matthias Neumayr

  • Remove deprecated Erubis ERB handler.

    Rafael Mendonça França

  • Remove default alt text generation.

    Fixes #30096

    Cameron Cundiff

  • Add srcset option to image_tag helper.

    Roberto Miranda

  • Fix issues with scopes and engine on current_page? method.

    Fixes #29401.

    Nikita Savrov

  • Generate field ids in collection_check_boxes and collection_radio_buttons.

    This makes sure that the labels are linked up with the fields.

    Fixes #29014.

    Yuji Yaginuma

  • Add :json type to auto_discovery_link_tag to support JSON Feeds

    Mike Gunderloy

  • Update distance_of_time_in_words helper to display better error messages for bad input.

    Jay Hayes

Please check 5-1-stable for previous changes.