ActionView::Helpers.asset_path is where the logic for javascript_include_tag resides. It takes an extname option for specifying the extension or false to not append it. This exposes that option to javascript_include_tag. Without the option files that didn't end with ".js" would get the extension appended to them. This broke JST templates and other file types that should be interpreted as JavaScript but who's file extension isn't ".js"
4.6 KiB
-
Added an
extname
hash option forjavascript_include_tag
method.Before:
javascript_include_tag('templates.jst') # => <script src="/javascripts/templates.jst.js"></script>
After:
javascript_include_tag('templates.jst', extname: false ) # => <script src="/javascripts/templates.jst"></script>
Nathan Stitt
-
Fix
current_page?
when the URL contains escaped characters and the original URL is using the hexadecimal lowercased.Rafael Mendonça França
-
Fix
text_area
to behave liketext_field
whennil
is given as value.Before:
f.text_field :field, value: nil #=> <input value=""> f.text_area :field, value: nil #=> <textarea>value of field</textarea>
After:
f.text_area :field, value: nil #=> <textarea></textarea>
Joel Cogen
-
Element of the
grouped_options_for_select
can optionally contain html attributes as the last element of the array.grouped_options_for_select( [["North America", [['United States','US'],"Canada"], data: { foo: 'bar' }]] )
Vasiliy Ermolovich
-
Fix default rendered format problem when calling
render
without :content_type option. It should return :html. Fix #11393.Gleb Mazovetskiy Oleg kennyj
-
Fix
link_to
with block and url hashes.Before:
link_to(action: 'bar', controller: 'foo') { content_tag(:span, 'Example site') } # => "<a action=\"bar\" controller=\"foo\"><span>Example site</span></a>"
After:
link_to(action: 'bar', controller: 'foo') { content_tag(:span, 'Example site') } # => "<a href=\"/foo/bar\"><span>Example site</span></a>"
Murahashi Sanemat Kenichi
-
Fix "Stack Level Too Deep" error when redering recursive partials.
Fixes #11340.
Rafael Mendonça França
-
Added an
enforce_utf8
hash option forform_tag
method.Control to output a hidden input tag with name
utf8
without monkey patching.Before:
form_tag # => '<form>..<input name="utf8" type="hidden" value="✓" />..</form>'
After:
form_tag # => '<form>..<input name="utf8" type="hidden" value="✓" />..</form>' form_tag({}, { :enforce_utf8 => false }) # => '<form>....</form>'
ma2gedev
-
Remove the deprecated
include_seconds
argument fromdistance_of_time_in_words
, pass in an:include_seconds
hash option to use this feature.Carlos Antonio da Silva
-
Remove deprecated block passing to
FormBuilder#new
.Vipul A M
-
Pick
DateField
DateTimeField
andColorField
values from stringified options allowing use of symbol keys with helpers.Jon Rowe
-
Remove the deprecated
prompt
argument fromgrouped_options_for_select
, pass in a:prompt
hash option to use this feature.kennyj
-
Always escape the result of
link_to_unless
method.Before:
link_to_unless(true, '<b>Showing</b>', 'github.com') # => "<b>Showing</b>"
After:
link_to_unless(true, '<b>Showing</b>', 'github.com') # => "<b>Showing</b>"
dtaniwaki
-
Use a case insensitive URI Regexp for #asset_path.
This fix a problem where the same asset path using different case are generating different URIs.
Before:
image_tag("HTTP://google.com") # => "<img alt=\"Google\" src=\"/assets/HTTP://google.com\" />" image_tag("http://google.com") # => "<img alt=\"Google\" src=\"http://google.com\" />"
After:
image_tag("HTTP://google.com") # => "<img alt=\"Google\" src=\"HTTP://google.com\" />" image_tag("http://google.com") # => "<img alt=\"Google\" src=\"http://google.com\" />"
David Celis
-
Element of the
collection_check_boxes
andcollection_radio_buttons
can optionally contain html attributes as the last element of the array.Vasiliy Ermolovich
-
Update the HTML
BOOLEAN_ATTRIBUTES
inActionView::Helpers::TagHelper
to conform to the latest HTML 5.1 spec. Add attributesallowfullscreen
,default
,inert
,sortable
,truespeed
,typemustmatch
. Fix attributeseamless
(previously misspelledseemless
).Alex Peattie
-
Fix an issue where partials with a number in the filename weren't being digested for cache dependencies.
Bryan Ricker
-
First release, ActionView extracted from ActionPack
Piotr Sarnacki, Łukasz Strzałkowski
Please check 4-0-stable (ActionPack's CHANGELOG) for previous changes.