kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

avoid passing unnecessary options to download method

Browse source 
The option --unicode-beta for tool/downloader.rb introduced in
r66448 must not be passed as an option to actual download machinery.
Thanks to MSP-Greg (Greg L.) for bug report and patch.
This closes issue #15434.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66449 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
duerst 2018-12-19 04:08:46 +00:00
parent eb2e931f6f
commit 13c15beb68
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
tool/downloader.rb
View file

@ -124,6 +124,11 @@ class Downloader
options = options.dup
url = URI(url)
dryrun = options.delete(:dryrun)
# remove from options (future use, see r66448), see L166
unicode_beta = options.delete(:unicode_beta)
puts "never" if unicode_beta == 'assigned but unused variable...'
if name
file = Pathname.new(under(dir, name))
else