kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

[rubygems/rubygems] Fix incorrect gem uninstall --all message

Browse source 
Currently `gem uninstall --all` shows the following incorrect message
after completion:

```
INFO:  Uninstalled all gems in
```

Now it shows something that actually makes sense like:

```
INFO:  Uninstalled all gems in /home/deivid/Code/rubygems/tmp/test_rubygems_6986/gemhome
```

https://github.com/rubygems/rubygems/commit/8fa05e8f8c
This commit is contained in:
David Rodríguez 2020-04-05 13:42:08 +02:00 committed by Hiroshi SHIBATA
parent 22030fe508
commit b1541606a2
Notes: git 2020-05-08 14:14:24 +09:00 
Merged: https://github.com/ruby/ruby/pull/3092
2 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/rubygems/commands/uninstall_command.rb
View file

@ -143,7 +143,7 @@ that is a dependency of an existing gem. You can use the
uninstall_gem spec.name
end
alert "Uninstalled all gems in #{options[:install_dir]}"
alert "Uninstalled all gems in #{options[:install_dir] || Gem.dir}"
end
def uninstall_specific

1
test/rubygems/test_gem_commands_uninstall_command.rb
View file

@ -361,6 +361,7 @@ class TestGemCommandsUninstallCommand < Gem::InstallerTestCase
end
assert_equal %w[default-1], Gem::Specification.all_names.sort
assert_equal "INFO: Uninstalled all gems in #{@gemhome}", @ui.output.split("\n").last
end
def test_execute_outside_gem_home