1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00

Resurrect make xxx-github PR=1234 interface

`call xxx, yyy` seems to pass " yyy" instead of "yyy".
This commit is contained in:
Takashi Kokubun 2019-04-25 18:54:43 +09:00
parent 70adfdcd8d
commit b2e92bfd9f
No known key found for this signature in database
GPG key ID: 6FFC433B12EE23DD

View file

@ -161,7 +161,7 @@ REMOTE_GUTHUB_URL = $(shell git -C "$(srcdir)" config remote.github.url)
.PHONY: fetch-github
fetch-github:
$(call fetch-github, $(PR))
$(call fetch-github,$(PR))
define fetch-github
$(if $(1),,\
@ -183,7 +183,7 @@ checkout-github: fetch-github
.PHONY: merge-github
merge-github: fetch-github
$(call merge-github, $(PR))
$(call merge-github,$(PR))
define merge-github
$(eval GITHUB_MERGE_BASE := $(shell git -C "$(srcdir)" log -1 --format=format:%H))