1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Commit graph

154 commits

Author SHA1 Message Date
Kenta Murata
441cd156e0 [ruby/csv] Fix typo [ci skip]
https://github.com/ruby/csv/commit/117bcf311e
2020-12-27 15:27:46 +09:00
Burdette Lamar
5a0c8068c8 [ruby/csv] Clarify and correct RDoc for converters ()
https://github.com/ruby/csv/commit/f3e9586b34
2020-11-24 09:33:55 +09:00
Burdette Lamar
614afb1647 [ruby/csv] Fix CSV.filter to preserve headers ()
Co-authored-by: Sutou Kouhei <kou@clear-code.com>

https://github.com/ruby/csv/commit/203c5e0574
2020-11-24 09:33:55 +09:00
Burdette Lamar
d2913f912f [ruby/csv] Add link to Wikipedia article Table ()
https://github.com/ruby/csv/commit/fe975c41d2
2020-11-24 09:33:55 +09:00
Sutou Kouhei
c6f389d84e [ruby/csv] Move doc/* to doc/csv/* to work in ruby/ruby too
https://github.com/ruby/csv/commit/910f8e0c5d
2020-07-21 09:17:54 +09:00
Burdette Lamar
935d0b3d05 [ruby/csv] Enhanced RDoc for several methods ()
* Enhanced RDoc for several methods

* Update lib/csv.rb

Co-authored-by: Sutou Kouhei <kou@cozmixng.org>

Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
https://github.com/ruby/csv/commit/72e8b00e51
2020-07-20 15:39:31 +09:00
Sutou Kouhei
4fcfa85cb6
[ruby/csv] CSV.generate_line: use the encoding of the first non ASCII field as the expected encoding
See also: https://github.com/ruby/stringio/issues/13#issuecomment-660543554

https://github.com/ruby/csv/commit/004cf49d18
2020-07-20 02:32:55 +09:00
Burdette Lamar
d9749b4715
[ruby/csv] RDoc for converters ()
* More on RDoc for converters

* More on RDoc for converters

* Fix indent

Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
https://github.com/ruby/csv/commit/6044976160
2020-07-20 02:32:54 +09:00
Burdette Lamar
d7c42df0b1
[ruby/csv] Adding call-seq to methods RDoc ()
* Adding call-seq to methods RDoc

Co-authored-by: Sutou Kouhei <kou@cozmixng.org>


https://github.com/ruby/csv/commit/dbd860c1cd
2020-07-20 02:32:54 +09:00
Burdette Lamar
544d82f49b
[ruby/csv] RDoc: summary lists for options ()
* RDoc: summary lists for options

* Enhanced RDoc for certain attributes and instance methods

* Enhanced RDoc for certain attributes and instance methods

* Enhanced RDoc for certain attributes and instance methods

* Enhanced RDoc for certain attributes and instance methods
https://github.com/ruby/csv/commit/72d8a25dc9
2020-07-20 02:32:54 +09:00
Burdette Lamar
40c5023629
[ruby/csv] RDoc remark about instance methods ()
https://github.com/ruby/csv/commit/76379bbe62
2020-07-20 02:32:54 +09:00
Burdette Lamar
a0bee2bbd6
[ruby/csv] Revised introductory RDoc ()
https://github.com/ruby/csv/commit/60f6f1c28f
2020-07-20 02:32:54 +09:00
Burdette Lamar
da83401ba4
[ruby/csv] Enhanced RDoc for filter ()
* Enhanced RDoc for filter

* Correct return values for ::filter, ::foreach, ::parse

* Enhanced RDoc for filter

* Remove "returns nil"s

Co-authored-by: Sutou Kouhei <kou@clear-code.com>
https://github.com/ruby/csv/commit/2c347f9a3d
2020-07-20 02:32:54 +09:00
Burdette Lamar
66b5cedc29
[ruby/csv] Enhancements for RDoc ()
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
https://github.com/ruby/csv/commit/25dd4cddbb
2020-07-20 02:32:53 +09:00
Burdette Lamar
d9eff306f5
[ruby/csv] Organize files in doc/ ()
https://github.com/ruby/csv/commit/bc9ea859b0
2020-07-20 02:32:53 +09:00
Burdette Lamar
920a16893a
[ruby/csv] RDoc for parse_line (adds headers examples) ()
* RDoc for parse_line (adds headers examples)

* RDoc for parse_line (adds headers examples)
https://github.com/ruby/csv/commit/a161be928e
2020-07-20 02:32:53 +09:00
Burdette Lamar
6106b7badd
[ruby/csv] Added headers to RDoc for CSV.foreach ()
* Added headers: to RDoc for CSV.foreach

* Correct options remark for CSV.generate

* Improve citation for option headers
https://github.com/ruby/csv/commit/b01945ec3a
2020-07-20 02:32:53 +09:00
Burdette Lamar
e4742fec64
[ruby/csv] Add headers cases to CSV.parse ()
* Add headers cases to CSV.parse

* Adjust call-seq for CSV.parse

* Update csv.rb
https://github.com/ruby/csv/commit/848c760c43
2020-07-20 02:32:53 +09:00
Burdette Lamar
013cca1f9a
[ruby/csv] doc: fix return value of open {} and use File.open {} ()
* Enhanced RDoc for CSV

* Repair example code for foreach
https://github.com/ruby/csv/commit/16b425eb37
2020-07-20 02:32:52 +09:00
Burdette Lamar
7c55c96147
[ruby/csv] Rdoc ()
Enhancements for open, parse, minor tweaks.
https://github.com/ruby/csv/commit/35392f4e45
2020-07-20 02:32:52 +09:00
Burdette Lamar
f89186aebb
[ruby/csv] Add document for CSV.instance ()
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
https://github.com/ruby/csv/commit/85e293c1ba
2020-07-20 02:32:52 +09:00
Burdette Lamar
1ac702cd29
[ruby/csv] Add RDoc links for delegated methods ()
https://github.com/ruby/csv/commit/1a4b96b418
2020-07-20 02:32:52 +09:00
Koichi ITO
08e70126ae
[ruby/csv] Add invalid: :replace for CSV.open ()
This PR adds `invalid: :replace` for `CSV.open`. It is a PR similar to .
https://github.com/ruby/csv/commit/5bf687341c
2020-07-20 02:32:52 +09:00
Koichi ITO
4e33a87879
[ruby/csv] Add undef: :replace for CSV.open ()
This PR adds `undef: :replace` option for `CSV.open`.

`File.open` has `undef: :replace` option, but `CSV.open` does not.
It would be convenient if `CSV.open` could have a shortcut by having
`undef: :replace` option.
https://github.com/ruby/csv/commit/cff8b18480
2020-07-20 02:32:51 +09:00
Burdette Lamar
cf8157e001
[ruby/csv] RDoc for foreach, generate ()
* Rdoc for foreach

* Enhanced Rdoc for CSV.generate
https://github.com/ruby/csv/commit/8c26c0ab1f
2020-07-20 02:32:51 +09:00
Burdette Lamar
9e6d54a501
[ruby/csv] Enhanced Rdoc ()
* Enhanced Rdoc for ::new

* Rdoc for parse_line

* More on parse_line

* Make ::new neater with :call-seq:

* Make better use of :call-seq:

* Rdoc for generate_line

* Respond to review
https://github.com/ruby/csv/commit/0d42df39cb
2020-07-20 02:32:51 +09:00
Sutou Kouhei
1822b19221
[ruby/csv] Don't drop stack trace in CSV.parse_line
GitHub: fix GH-120

Reported by Kyle d'Oliveira. Thanks!!!

https://github.com/ruby/csv/commit/2959483f90
2020-07-20 02:32:50 +09:00
Burdette Lamar
6ba1abd40c
[ruby/csv] Enhanced Rdoc for CSV ()
https://github.com/ruby/csv/commit/cd670595d5
2020-07-20 02:32:50 +09:00
TOMITA Masahiro
aeac7db823
[ruby/csv] Fix docs for :strip option ()
https://github.com/ruby/csv/commit/fb10925271
2020-07-20 02:32:49 +09:00
Seiei Miyagi
3c5b67e0db
[ruby/csv] Ensuring StringIO's encoding in CSV.generate ()
https://github.com/ruby/csv/commit/dbf55ef008
2020-07-20 02:32:49 +09:00
Sutou Kouhei
92df7d98b6
Import CSV 3.1.2 () 2019-10-12 14:03:21 +09:00
Jeremy Evans
80b5a0ff2a
Make rb_scan_args handle keywords more similar to Ruby methods ()
Cfuncs that use rb_scan_args with the : entry suffer similar keyword
argument separation issues that Ruby methods suffer if the cfuncs
accept optional or variable arguments.

This makes the following changes to : handling.

* Treats as **kw, prompting keyword argument separation warnings
  if called with a positional hash.

* Do not look for an option hash if empty keywords are provided.
  For backwards compatibility, treat an empty keyword splat as a empty
  mandatory positional hash argument, but emit a a warning, as this
  behavior will be removed in Ruby 3.  The argument number check
  needs to be moved lower so it can correctly handle an empty
  positional argument being added.

* If the last argument is nil and it is necessary to treat it as an option
  hash in order to make sure all arguments are processed, continue to
  treat the last argument as the option hash. Emit a warning in this case,
  as this behavior will be removed in Ruby 3.

* If splitting the keyword hash into two hashes, issue a warning, as we
  will not be splitting hashes in Ruby 3.

* If the keyword argument is required to fill a mandatory positional
  argument, continue to do so, but emit a warning as this behavior will
  be going away in Ruby 3.

* If keyword arguments are provided and the last argument is not a hash,
  that indicates something wrong. This can happen if a cfunc is calling
  rb_scan_args multiple times, and providing arguments that were not
  passed to it from Ruby.  Callers need to switch to the new
  rb_scan_args_kw function, which allows passing of whether keywords
  were provided.

This commit fixes all warnings caused by the changes above.

It switches some function calls to *_kw versions with appropriate
kw_splat flags. If delegating arguments, RB_PASS_CALLED_KEYWORDS
is used.  If creating new arguments, RB_PASS_KEYWORDS is used if
the last argument is a hash to be treated as keywords.

In open_key_args in io.c, use rb_scan_args_kw.
In this case, the arguments provided come from another C
function, not Ruby.  The last argument may or may not be a hash,
so we can't set keyword argument mode.  However, if it is a
hash, we don't want to warn when treating it as keywords.

In Ruby files, make sure to appropriately use keyword splats
or literal keywords when calling Cfuncs that now issue keyword
argument separation warnings through rb_scan_args.  Also, make
sure not to pass nil in place of an option hash.

Work around Kernel#warn warnings due to problems in the Rubygems
override of the method.  There is an open pull request to fix
these issues in Rubygems, but part of the Rubygems tests for
their override fail on ruby-head due to rb_scan_args not
recognizing empty keyword splats, which this commit fixes.

Implementation wise, adding rb_scan_args_kw is kind of a pain,
because rb_scan_args takes a variable number of arguments.
In order to not duplicate all the code, the function internals need
to be split into two functions taking a va_list, and to avoid passing
in a ton of arguments, a single struct argument is used to handle
the variables previously local to the function.
2019-09-25 11:18:49 -07:00
Jeremy Evans
d08e1004e0 Fix keyword argument separation issues in lib
Mostly requires adding ** in either calls or method definitions.
2019-08-30 12:39:31 -07:00
Kazuhiro NISHIYAMA
ffab84fa3e
Fix a typo [ci skip] 2019-08-13 15:27:46 +09:00
Kazuhiro NISHIYAMA
d8e90f5558
Fix a typo in inspect 2019-07-25 16:39:28 +09:00
kawa_tech
8c0edbd79d [ruby/csv] add options doc :quote_empty ()
https://github.com/ruby/csv/commit/5ca8d79f60
2019-07-14 23:07:31 +09:00
Masafumi Koba
75620c804e [ruby/csv] Add options doc: :write_converters, :write_nil_value, :write_empty_value ()
https://github.com/ruby/csv/commit/5923ee08b7
2019-07-14 23:07:31 +09:00
hayashiyoshino
fe40841bfb [ruby/csv] add document of strip ()
* add document of strip

* modify typo

https://github.com/ruby/csv/commit/de0257dc31
2019-07-14 23:07:31 +09:00
Kouhei Sutou
8392592a0a [ruby/csv] Don't raise on eof?
GitHub: fix 

Reported by krororo. Thanks!!!

https://github.com/ruby/csv/commit/5a8d9d9297
2019-07-14 23:07:31 +09:00
kou
e3b6c7c7eb Import CSV 3.0.8
This includes performance improvements and backward incompatibility
fixes.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67560 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2019-04-14 21:01:51 +00:00
kou
24b57b102c Upgrade CSV to 3.0.4
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66922 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2019-01-25 06:49:59 +00:00
kou
e5d634260e Import CSV 3.0.2
This includes performance improvement especially writing. Writing is
about 2 times faster.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66507 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-12-23 07:00:35 +00:00
hsbt
60ebd4e26a Merge csv-3.0.0 from ruby/csv repository.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64638 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-09-05 13:33:21 +00:00
hsbt
5c1941a9be Merge csv-1.0.2 from upstream.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63364 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-05-09 04:39:16 +00:00
watson1978
dce4a3f58c Improve CSV performance
If it will not use special variables (like $1, $&, $`...),
it can improve the performance by using Regexp#match? or String#match? instead of Regexp#=~ or String#=~.

This patch is same idea as https://github.com/ruby/ruby/pull/1836

[Fix GH-1842]

## Environment
* OS : Ubuntu 17.10
* Compiler : gcc version 7.2.0
* CPU : Intel(R) Core(TM) i5-3210M CPU @ 2.50GHz
* Memory : 16 GB

## TL;DR
Methods     | Before | After  | Speed up
----------- | ------ | ------ | --------
CSV.foreach | 44.825 | 48.201 | 7.5%
CSV#shift   | 45.200 | 49.584 | 9.7%
CSV.read    | 42.968 | 46.853 | 9.0%
CSV.table   | 10.933 | 11.277 | 3.1%

## Before
```
Calculating -------------------------------------
         CSV.foreach     44.825  (± 0.0%) i/s -    228.000  in   5.086576s
           CSV#shift     45.200  (± 0.0%) i/s -    228.000  in   5.044297s
            CSV.read     42.968  (± 0.0%) i/s -    216.000  in   5.027504s
           CSV.table     10.933  (± 0.0%) i/s -     55.000  in   5.031098s
```

## After
```
Calculating -------------------------------------
         CSV.foreach     48.201  (± 0.0%) i/s -    244.000  in   5.062256s
           CSV#shift     49.584  (± 0.0%) i/s -    248.000  in   5.001652s
            CSV.read     46.853  (± 0.0%) i/s -    236.000  in   5.037044s
           CSV.table     11.277  (± 0.0%) i/s -     57.000  in   5.054694s
```

## Benchmark code
```ruby
require 'csv'
require 'benchmark/ips'

CSV.open("/tmp/file.csv", "w") do |csv|
  csv << ["player", "gameA", "gameB"]
  1000.times do
    csv << ['"Alice"', "84.0", "79.5"]
    csv << ['"Bob"', "20.0", "56.5"]
  end
end

Benchmark.ips do |x|
  x.report "CSV.foreach" do
    CSV.foreach("/tmp/file.csv") do |row|
    end
  end

  x.report "CSV#shift" do
    CSV.open("/tmp/file.csv") do |csv|
      while line = csv.shift
      end
    end
  end

  x.report "CSV.read" do
    CSV.read("/tmp/file.csv")
  end

  x.report "CSV.table" do
    CSV.table("/tmp/file.csv")
  end
end
```

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62806 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-03-18 10:28:58 +00:00
hsbt
0593c6a510 Merge csv-0.1.0 from upstream.
* csv.gemspec: Update release version.
  * lib/csv.rb: Remove superfluous private clause.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59849 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2017-09-12 08:38:06 +00:00
hsbt
9d99093169 Partly reverted r59642. Because IO#close is idempotent since Ruby 2.3.
Reported by Eric Wong. Thank you.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59683 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2017-08-29 10:22:47 +00:00
glass
1a1930180c lib/csv.rb: refactor and optimize. This change
includes the patch from marshall-lee.
close 

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59671 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2017-08-28 07:54:00 +00:00
glass
20c5f60775 csv.rb: optimize CSV::Table#to_a and #to_csv
* lib/csv.rb (CSV::Table#to_a, #to_csv): use Array#push instead of
  Array#concat for performance improvement. This performance improvement is
  proposed by zdennis <zach.dennis@gmail.com>. The patch is from
  Mau Magnaguagno <maumagnaguagno@gmail.com>.
  close 

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59657 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2017-08-25 08:13:32 +00:00
hsbt
ffb49a7e9b Fixed regression to convert blank value at r45497.
[Bug ][ruby-core:69088]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59643 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2017-08-22 06:57:00 +00:00