mirror of
https://github.com/thoughtbot/factory_bot.git
synced 2022-11-09 11:43:51 -05:00
5947e10578
Why: Another run of internal methods that should not be publicly available from the base namespace. This time the sequence involving methods were moved. It's worth noticing that the ```Internal``` class is getting crowded. Maybe we can start name-spacing the internal groups into modules under ```internal/sequence.rb``` ```internal/trait.rb``` and so on. Thoughts? This PR: - Moves the ```register_sequence```, ```sequence_by_name```, ```sequences``` and ```rewind_sequences``` to the ```FactoryBot::Internal``` module. - Deprecates uses of ```sequence_by_name```, and ```sequences``` from the ```FactoryBot``` module. - Refactor rewind sequences test to use spies This is one of the steps towards fixing [this issue](https://github.com/thoughtbot/factory_bot/pull/1285#1281)
56 lines
1.9 KiB
Ruby
56 lines
1.9 KiB
Ruby
describe FactoryBot::Internal do
|
|
describe ".register_trait" do
|
|
it "registers the provided trait" do
|
|
trait = FactoryBot::Trait.new(:admin)
|
|
configuration = FactoryBot::Internal.configuration
|
|
expect { FactoryBot::Internal.register_trait(trait) }.
|
|
to change { configuration.traits.count }.
|
|
from(0).
|
|
to(1)
|
|
end
|
|
end
|
|
|
|
describe ".trait_by_name" do
|
|
it "finds a previously registered trait" do
|
|
trait = FactoryBot::Trait.new(:admin)
|
|
FactoryBot::Internal.register_trait(trait)
|
|
expect(FactoryBot::Internal.trait_by_name(trait.name)).to eq trait
|
|
end
|
|
end
|
|
|
|
describe ".register_sequence" do
|
|
it "registers the provided sequence" do
|
|
sequence = FactoryBot::Sequence.new(:email)
|
|
configuration = FactoryBot::Internal.configuration
|
|
expect { FactoryBot::Internal.register_sequence(sequence) }.
|
|
to change { configuration.sequences.count }.
|
|
from(0).
|
|
to(1)
|
|
end
|
|
end
|
|
|
|
describe ".sequence_by_name" do
|
|
it "finds a registered sequence" do
|
|
sequence = FactoryBot::Sequence.new(:email)
|
|
FactoryBot::Internal.register_sequence(sequence)
|
|
expect(FactoryBot::Internal.sequence_by_name(sequence.name)).to eq sequence
|
|
end
|
|
end
|
|
|
|
describe ".rewind_sequences" do
|
|
it "rewinds the sequences and the internal sequences" do
|
|
sequence = instance_double(FactoryBot::Sequence, names: ["email"])
|
|
allow(sequence).to receive(:rewind)
|
|
FactoryBot::Internal.register_sequence(sequence)
|
|
|
|
inline_sequence = instance_double(FactoryBot::Sequence)
|
|
allow(inline_sequence).to receive(:rewind)
|
|
FactoryBot::Internal.register_inline_sequence(inline_sequence)
|
|
|
|
FactoryBot::Internal.rewind_sequences
|
|
|
|
expect(sequence).to have_received(:rewind).exactly(:once)
|
|
expect(inline_sequence).to have_received(:rewind).exactly(:once)
|
|
end
|
|
end
|
|
end
|