2015-04-02 14:03:50 +00:00
|
|
|
# HEAD
|
2014-10-22 07:18:54 +00:00
|
|
|
|
|
|
|
|
### Backward-incompatible changes
|
|
|
|
|
|
2015-05-22 16:48:42 +00:00
|
|
|
* We've dropped support for Rails 3.x, Ruby 1.9.2, and Ruby 1.9.3, and RSpec 2.
|
2015-06-25 22:06:21 +00:00
|
|
|
All of these have been end-of-lifed. ([a4045a1], [b7fe87a])
|
2015-05-22 16:48:42 +00:00
|
|
|
|
|
|
|
|
* The gem no longer detects the test framework you're using or mixes itself into
|
|
|
|
|
that framework automatically. [History][no-auto-integration-1] has
|
|
|
|
|
[shown][no-auto-integration-2] that performing any kind of detection is prone
|
|
|
|
|
to bugs and more complicated than it should be.
|
|
|
|
|
|
|
|
|
|
Here are the updated instructions:
|
|
|
|
|
|
|
|
|
|
* You no longer need to say `require: false` in your Gemfile; you can
|
|
|
|
|
include the gem as normal.
|
|
|
|
|
* You'll need to add the following somewhere in your `rails_helper` (for
|
|
|
|
|
RSpec) or `test_helper` (for Minitest / Test::Unit):
|
2015-05-07 04:43:35 +00:00
|
|
|
|
2015-05-22 16:48:42 +00:00
|
|
|
``` ruby
|
|
|
|
|
Shoulda::Matchers.configure do |config|
|
|
|
|
|
config.integrate do |with|
|
|
|
|
|
# Choose a test framework:
|
|
|
|
|
with.test_framework :rspec
|
|
|
|
|
with.test_framework :minitest
|
|
|
|
|
with.test_framework :minitest_4
|
|
|
|
|
with.test_framework :test_unit
|
|
|
|
|
|
2015-05-07 04:43:35 +00:00
|
|
|
# Choose one or more libraries:
|
2015-05-22 16:48:42 +00:00
|
|
|
with.library :active_record
|
|
|
|
|
with.library :active_model
|
|
|
|
|
with.library :action_controller
|
2015-05-07 04:43:35 +00:00
|
|
|
# Or, choose the following (which implies all of the above):
|
2015-05-22 16:48:42 +00:00
|
|
|
with.library :rails
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
```
|
|
|
|
|
|
|
|
|
|
([1900071])
|
|
|
|
|
|
|
|
|
|
* There are two changes to `allow_value`:
|
|
|
|
|
|
|
|
|
|
* The negative form of the matcher has been changed so that instead of
|
|
|
|
|
asserting that any of the given values is an invalid value (allowing good
|
|
|
|
|
values to pass through), assert that *all* values are invalid values
|
|
|
|
|
(allowing good values not to pass through). This means that this test which
|
|
|
|
|
formerly passed will now fail:
|
|
|
|
|
|
|
|
|
|
expect(record).not_to allow_value('good value', *bad_values)
|
|
|
|
|
|
|
|
|
|
([19ce8a6])
|
|
|
|
|
|
|
|
|
|
* The matcher may raise an error if the attribute in question contains
|
|
|
|
|
custom logic to ignore certain values, resulting in a discrepancy between
|
|
|
|
|
the value you provide and the value that the attribute is actually set to.
|
|
|
|
|
Specifically, if the attribute cannot be changed from a non-nil value to a
|
|
|
|
|
nil value, or vice versa, then you'll get a CouldNotSetAttributeError. The
|
|
|
|
|
current behavior (which is to permit this) is misleading, as the test that
|
|
|
|
|
you're writing under the hood by using `allow_value` could be different from
|
|
|
|
|
the test that actually ends up getting run. ([eaaa2d8])
|
|
|
|
|
|
|
|
|
|
* `validate_uniqueness_of` is now properly case-insensitive by default, to match
|
|
|
|
|
the default behavior of the validation itself. This is a backward-incompatible
|
|
|
|
|
change because this test which incorrectly passed before will now fail:
|
|
|
|
|
|
|
|
|
|
``` ruby
|
|
|
|
|
class Product < ActiveRecord::Base
|
|
|
|
|
validates_uniqueness_of :name, case_sensitive: false
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
describe Product do
|
|
|
|
|
it { is_expected.to validate_uniqueness_of(:name) }
|
|
|
|
|
end
|
|
|
|
|
```
|
|
|
|
|
|
|
|
|
|
([57a1922])
|
2015-05-22 16:10:29 +00:00
|
|
|
|
2014-11-18 09:58:09 +00:00
|
|
|
* `ensure_inclusion_of`, `ensure_exclusion_of`, and `ensure_length_of` have been
|
2015-05-22 16:10:29 +00:00
|
|
|
removed in favor of their `validate_*` counterparts. ([55c8d09])
|
2014-11-18 09:58:09 +00:00
|
|
|
|
2014-11-19 23:13:59 +00:00
|
|
|
* `set_the_flash` and `set_session` have been changed to more closely align with
|
|
|
|
|
each other:
|
2015-05-22 16:10:29 +00:00
|
|
|
* `set_the_flash` has been removed in favor of `set_flash`. ([801f2c7])
|
2014-11-19 23:13:59 +00:00
|
|
|
* `set_session('foo')` is no longer valid syntax, please use
|
2015-05-22 16:10:29 +00:00
|
|
|
`set_session['foo']` instead. ([535fe05])
|
2014-11-19 23:13:59 +00:00
|
|
|
* `set_session['key'].to(nil)` will no longer pass when the key in question
|
2015-05-22 16:10:29 +00:00
|
|
|
has not been set yet. ([535fe05])
|
2014-11-19 23:17:48 +00:00
|
|
|
|
2015-07-08 22:43:10 +00:00
|
|
|
* Change `set_flash` so that `set_flash[:foo].now` is no longer valid syntax.
|
|
|
|
|
You'll want to use `set_flash.now[:foo]` instead. This was changed in order to
|
|
|
|
|
more closely align with how `flash.now` works when used in a controller.
|
|
|
|
|
([#755], [#752])
|
|
|
|
|
|
2015-05-22 20:37:19 +00:00
|
|
|
* Change behavior of `validate_uniqueness_of` when the matcher is not
|
|
|
|
|
qualified with any scopes, but your validation is. Previously the following
|
|
|
|
|
test would pass when it now fails:
|
|
|
|
|
|
|
|
|
|
``` ruby
|
|
|
|
|
class Post < ActiveRecord::Base
|
|
|
|
|
validate :slug, uniqueness: { scope: :user_id }
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
describe Post do
|
|
|
|
|
it { should validate_uniqueness_of(:slug) }
|
|
|
|
|
end
|
|
|
|
|
```
|
|
|
|
|
|
2015-05-22 16:48:42 +00:00
|
|
|
([6ac7b81])
|
|
|
|
|
|
|
|
|
|
[no-auto-integration-1]: https://github.com/freerange/mocha/commit/049080c673ee3f76e76adc1e1a6122c7869f1648
|
|
|
|
|
[no-auto-integration-2]: https://github.com/rr/rr/issues/29
|
|
|
|
|
[1900071]: https://github.com/thoughtbot/shoulda-matchers/commit/190007155e0676aae84d08d8ed8eed3beebc3a06
|
|
|
|
|
[b7fe87a]: https://github.com/thoughtbot/shoulda-matchers/commit/b7fe87ae915f6b1f99d64e847fea536ad0f78024
|
|
|
|
|
[a4045a1]: https://github.com/thoughtbot/shoulda-matchers/commit/a4045a1f9bc454e618a7c55960942eb030f02fdd
|
|
|
|
|
[57a1922]: https://github.com/thoughtbot/shoulda-matchers/commit/57a19228b6a85f12ba7a79a26dae5869c1499c6d
|
|
|
|
|
[19ce8a6]: https://github.com/thoughtbot/shoulda-matchers/commit/19c38a642a2ae1316ef12540a0185cd026901e74
|
|
|
|
|
[eaaa2d8]: https://github.com/thoughtbot/shoulda-matchers/commit/eaaa2d83e5cd31a3ca0a1aaa65441ea1a4fffa49
|
|
|
|
|
[55c8d09]: https://github.com/thoughtbot/shoulda-matchers/commit/55c8d09bf2af886540924efa83c3b518d926a770
|
|
|
|
|
[801f2c7]: https://github.com/thoughtbot/shoulda-matchers/commit/801f2c7c1eab3b2053244485c9800f850959cfef
|
|
|
|
|
[535fe05]: https://github.com/thoughtbot/shoulda-matchers/commit/535fe05be8686fdafd8b22f2ed5c4192bd565d50
|
|
|
|
|
[eaaa2d8]: https://github.com/thoughtbot/shoulda-matchers/commit/eaaa2d83e5cd31a3ca0a1aaa65441ea1a4fffa49
|
|
|
|
|
[6ac7b81]: https://github.com/thoughtbot/shoulda-matchers/commit/6ac7b8158cfba3b518eb3da3c24345e4473b416f
|
2015-07-08 22:43:10 +00:00
|
|
|
[#755]: https://github.com/thoughtbot/shoulda-matchers/pull/755
|
|
|
|
|
[#752]: https://github.com/thoughtbot/shoulda-matchers/pull/752
|
2015-05-22 16:48:42 +00:00
|
|
|
|
2015-02-09 23:40:52 +00:00
|
|
|
### Bug fixes
|
|
|
|
|
|
|
|
|
|
* So far the tests for the gem have been running against only SQLite. Now they
|
|
|
|
|
run against PostgreSQL, too. As a result we were able to fix some
|
2015-02-11 21:34:18 +00:00
|
|
|
Postgres-related bugs, specifically around `validate_uniqueness_of`:
|
2015-02-09 23:40:52 +00:00
|
|
|
|
2015-02-11 21:34:18 +00:00
|
|
|
* When scoped to a UUID column that ends in an "f", the matcher is able to
|
2015-02-10 17:31:17 +00:00
|
|
|
generate a proper "next" value without erroring. ([#402], [#587], [#662])
|
|
|
|
|
|
2015-02-11 21:34:18 +00:00
|
|
|
* Support scopes that are PostgreSQL array columns. Please note that this is
|
|
|
|
|
only supported for Rails 4.2 and greater, as versions before this cannot
|
|
|
|
|
handle array columns correctly, particularly in conjunction with the
|
|
|
|
|
uniqueness validator. ([#554])
|
2015-02-10 17:31:17 +00:00
|
|
|
|
2015-02-11 21:34:18 +00:00
|
|
|
* Fix so that when scoped to a text column and the scope is set to nil before
|
|
|
|
|
running it through the matcher, the matcher does not fail. ([#521], [#607])
|
2015-02-09 23:40:52 +00:00
|
|
|
|
2015-01-15 19:18:22 +00:00
|
|
|
* Fix `define_enum_for` so that it actually tests that the attribute is present
|
|
|
|
|
in the list of defined enums, as you could fool it by merely defining a class
|
|
|
|
|
method that was the pluralized version of the attribute name. In the same
|
|
|
|
|
vein, passing a pluralized version of the attribute name to `define_enum_for`
|
|
|
|
|
would erroneously pass, and now it fails. ([#641])
|
|
|
|
|
|
Permit matcher now supports subparameters
Previously we were taking ActionController::Parameters and completely
overriding #require, forcing it to return `self`, i.e, the entire
ActionController::Parameters object. This meant that we broke its
functionality, which is to return a slice of the params hash instead.
The consequence of this is that attempting to call #permit on a slice of
the params hash obtained via #require would not work:
``` ruby
params = ActionController::Parameters.new(
{ "course" => { "foo" => "bar" } }
)
params.require(:course)
params.require(:course).permit(:foo)
```
This commit fixes the permit matcher so that #require is proxied
instead, retaining the existing behavior.
This commit also adds a qualifier, #on, for asserting that your action
places a restriction on a slice of the params hash. The `permit` matcher
will properly track calls on child `params` instances. For example:
``` ruby
class UsersController < ActionController::Base
def create
User.create!(user_params)
...
end
private
def user_params
params.require(:user).permit(:name, :age)
end
end
describe UsersController do
it { should permit(:name, :age).for(:create).on(:user) }
end
```
If this fails, you'll get the following error message:
```
Expected POST #create to restrict parameters for :user to :name and :age,
but restricted parameters were :first_name and :last_name.
```
2015-02-19 18:35:45 +00:00
|
|
|
* Fix `permit` so that it does not break the functionality of
|
|
|
|
|
ActionController::Parameters#require. ([#648], [#675])
|
|
|
|
|
|
2015-03-01 22:39:44 +00:00
|
|
|
* Fix `validate_uniqueness_of` + `scoped_to` so that it does not raise an error
|
|
|
|
|
if a record exists where the scoped attribute is nil. ([#677])
|
|
|
|
|
|
2015-03-30 23:14:33 +00:00
|
|
|
* Fix `route` matcher so if your route includes a default `format`, you can
|
|
|
|
|
specify this as a symbol or string. ([#693])
|
|
|
|
|
|
2015-03-31 13:44:09 +00:00
|
|
|
* Fix `validate_uniqueness_of` so that it allows you to test against scoped
|
|
|
|
|
attributes that are boolean columns. ([#457], [#694])
|
|
|
|
|
|
2015-04-09 14:27:26 +00:00
|
|
|
* Fix failure message for `validate_numericality_of` as it sometimes didn't
|
|
|
|
|
provide the reason for failure. ([#699])
|
|
|
|
|
|
Permit matcher now supports subparameters
Previously we were taking ActionController::Parameters and completely
overriding #require, forcing it to return `self`, i.e, the entire
ActionController::Parameters object. This meant that we broke its
functionality, which is to return a slice of the params hash instead.
The consequence of this is that attempting to call #permit on a slice of
the params hash obtained via #require would not work:
``` ruby
params = ActionController::Parameters.new(
{ "course" => { "foo" => "bar" } }
)
params.require(:course)
params.require(:course).permit(:foo)
```
This commit fixes the permit matcher so that #require is proxied
instead, retaining the existing behavior.
This commit also adds a qualifier, #on, for asserting that your action
places a restriction on a slice of the params hash. The `permit` matcher
will properly track calls on child `params` instances. For example:
``` ruby
class UsersController < ActionController::Base
def create
User.create!(user_params)
...
end
private
def user_params
params.require(:user).permit(:name, :age)
end
end
describe UsersController do
it { should permit(:name, :age).for(:create).on(:user) }
end
```
If this fails, you'll get the following error message:
```
Expected POST #create to restrict parameters for :user to :name and :age,
but restricted parameters were :first_name and :last_name.
```
2015-02-19 18:35:45 +00:00
|
|
|
### Features
|
|
|
|
|
|
|
|
|
|
* Add `on` qualifier to `permit`. This allows you to make an assertion that
|
|
|
|
|
a restriction was placed on a slice of the `params` hash and not the entire
|
|
|
|
|
`params` hash. Although we don't require you to use this qualifier, we do
|
|
|
|
|
recommend it, as it's a more precise check. ([#675])
|
|
|
|
|
|
2014-12-03 22:06:23 +00:00
|
|
|
* Add `strict` qualifier to `validate_numericality_of`. ([#620])
|
|
|
|
|
|
2015-05-22 16:10:29 +00:00
|
|
|
* Add `on` qualifier to `validate_numericality_of`. ([9748869]; h/t [#356],
|
|
|
|
|
[#358])
|
2015-04-01 06:00:14 +00:00
|
|
|
|
2014-09-10 19:38:20 +00:00
|
|
|
* Add `join_table` qualifier to `have_and_belong_to_many`. ([#556])
|
|
|
|
|
|
2015-03-30 21:43:16 +00:00
|
|
|
* `allow_values` is now an alias for `allow_value`. This makes more sense when
|
|
|
|
|
checking against multiple values:
|
|
|
|
|
|
2015-05-22 16:48:42 +00:00
|
|
|
``` ruby
|
|
|
|
|
it { should allow_values('this', 'and', 'that') }
|
|
|
|
|
```
|
2015-03-30 21:43:16 +00:00
|
|
|
|
|
|
|
|
([#692])
|
|
|
|
|
|
2015-05-22 16:10:29 +00:00
|
|
|
[9748869]: https://github.com/thoughtbot/shoulda-matchers/commit/97488690910520ed8e1f2e164b1982eff5ef1f19
|
2015-02-11 21:34:18 +00:00
|
|
|
[#402]: https://github.com/thoughtbot/shoulda-matchers/pull/402
|
|
|
|
|
[#587]: https://github.com/thoughtbot/shoulda-matchers/pull/587
|
|
|
|
|
[#662]: https://github.com/thoughtbot/shoulda-matchers/pull/662
|
|
|
|
|
[#554]: https://github.com/thoughtbot/shoulda-matchers/pull/554
|
2015-01-15 19:18:22 +00:00
|
|
|
[#641]: https://github.com/thoughtbot/shoulda-matchers/pull/641
|
2015-02-11 21:34:18 +00:00
|
|
|
[#521]: https://github.com/thoughtbot/shoulda-matchers/pull/521
|
|
|
|
|
[#607]: https://github.com/thoughtbot/shoulda-matchers/pull/607
|
Permit matcher now supports subparameters
Previously we were taking ActionController::Parameters and completely
overriding #require, forcing it to return `self`, i.e, the entire
ActionController::Parameters object. This meant that we broke its
functionality, which is to return a slice of the params hash instead.
The consequence of this is that attempting to call #permit on a slice of
the params hash obtained via #require would not work:
``` ruby
params = ActionController::Parameters.new(
{ "course" => { "foo" => "bar" } }
)
params.require(:course)
params.require(:course).permit(:foo)
```
This commit fixes the permit matcher so that #require is proxied
instead, retaining the existing behavior.
This commit also adds a qualifier, #on, for asserting that your action
places a restriction on a slice of the params hash. The `permit` matcher
will properly track calls on child `params` instances. For example:
``` ruby
class UsersController < ActionController::Base
def create
User.create!(user_params)
...
end
private
def user_params
params.require(:user).permit(:name, :age)
end
end
describe UsersController do
it { should permit(:name, :age).for(:create).on(:user) }
end
```
If this fails, you'll get the following error message:
```
Expected POST #create to restrict parameters for :user to :name and :age,
but restricted parameters were :first_name and :last_name.
```
2015-02-19 18:35:45 +00:00
|
|
|
[#648]: https://github.com/thoughtbot/shoulda-matchers/pull/648
|
|
|
|
|
[#675]: https://github.com/thoughtbot/shoulda-matchers/pull/675
|
2015-03-01 22:39:44 +00:00
|
|
|
[#677]: https://github.com/thoughtbot/shoulda-matchers/pull/677
|
2014-12-03 22:06:23 +00:00
|
|
|
[#620]: https://github.com/thoughtbot/shoulda-matchers/pull/620
|
2015-03-30 23:14:33 +00:00
|
|
|
[#693]: https://github.com/thoughtbot/shoulda-matchers/pull/693
|
2015-04-01 06:00:14 +00:00
|
|
|
[#356]: https://github.com/thoughtbot/shoulda-matchers/pull/356
|
|
|
|
|
[#358]: https://github.com/thoughtbot/shoulda-matchers/pull/358
|
2014-09-10 19:38:20 +00:00
|
|
|
[#556]: https://github.com/thoughtbot/shoulda-matchers/pull/556
|
2015-03-31 13:44:09 +00:00
|
|
|
[#457]: https://github.com/thoughtbot/shoulda-matchers/pull/457
|
|
|
|
|
[#694]: https://github.com/thoughtbot/shoulda-matchers/pull/694
|
2015-03-30 21:43:16 +00:00
|
|
|
[#692]: https://github.com/thoughtbot/shoulda-matchers/pull/692
|
2015-04-09 14:27:26 +00:00
|
|
|
[#699]: https://github.com/thoughtbot/shoulda-matchers/pull/699
|
2015-01-15 19:18:22 +00:00
|
|
|
|
2015-01-30 17:42:00 +00:00
|
|
|
# 2.8.0
|
2014-05-09 21:07:18 +00:00
|
|
|
|
2014-11-04 21:21:30 +00:00
|
|
|
### Deprecations
|
|
|
|
|
|
|
|
|
|
* `ensure_length_of` has been renamed to `validate_length_of`.
|
|
|
|
|
`ensure_length_of` is deprecated and will be removed in 3.0.0.
|
|
|
|
|
|
2014-11-21 18:35:38 +00:00
|
|
|
* `set_the_flash` has been renamed to `set_flash`. `set_the_flash` is
|
|
|
|
|
deprecated and will be removed in 3.0.0.
|
|
|
|
|
|
2014-11-21 18:30:02 +00:00
|
|
|
* `set_session(:foo)` is deprecated in favor of `set_session[:foo]`.
|
|
|
|
|
`set_session(:foo)` will be invalid syntax in 3.0.0.
|
|
|
|
|
|
|
|
|
|
* Using `should set_session[:key].to(nil)` to assert that that a value has not
|
|
|
|
|
been set is deprecated. Please use `should_not set_session[:key]` instead.
|
|
|
|
|
In 3.0.0, `should set_session[:key].to(nil)` will only pass if the value is
|
|
|
|
|
truly nil.
|
|
|
|
|
|
2014-10-09 04:45:12 +00:00
|
|
|
### Bug fixes
|
|
|
|
|
|
2014-10-09 06:30:27 +00:00
|
|
|
* Fix `delegate_method` so that it works again with shoulda-context. ([#591])
|
|
|
|
|
|
|
|
|
|
* Fix `validate_uniqueness_of` when used with `scoped_to` so that when one of
|
|
|
|
|
the scope attributes is a polymorphic `*_type` attribute and the model has
|
|
|
|
|
another validation on the same attribute, the matcher does not fail with an
|
|
|
|
|
error. ([#592])
|
|
|
|
|
|
2014-09-21 22:21:52 +00:00
|
|
|
* Fix `has_many` used with `through` so that when the association does not
|
|
|
|
|
exist, and the matcher fails, it does not raise an error when producing the
|
|
|
|
|
failure message. ([#588])
|
|
|
|
|
|
2014-09-10 20:32:46 +00:00
|
|
|
* Fix `have_and_belong_to_many` used with `join_table` so that it does not fail
|
|
|
|
|
when `foreign_key` and/or `association_foreign_key` was specified on the
|
|
|
|
|
association as a symbol instead of a string. ([#584])
|
|
|
|
|
|
2014-10-21 07:35:29 +00:00
|
|
|
* Fix `allow_value` when an i18n translation key is passed to `with_message` and
|
|
|
|
|
the `:against` option is used to specify an alternate attribute. A bug here
|
|
|
|
|
also happened to affect `validate_confirmation_of` when an i18n translation
|
|
|
|
|
key is passed to `with_message`. ([#593])
|
|
|
|
|
|
2014-11-05 18:07:29 +00:00
|
|
|
* Fix `class_name` qualifier for association matchers so that if the model being
|
|
|
|
|
referenced is namespaced, the matcher will correctly resolve the class before
|
|
|
|
|
checking it against the association's `class_name`. ([#537])
|
|
|
|
|
|
2014-10-10 05:50:03 +00:00
|
|
|
* Fix `validate_inclusion_of` used with `with_message` so that it fails if given
|
|
|
|
|
a message that does not match the message on the validation. ([#598])
|
|
|
|
|
|
2014-11-18 09:22:39 +00:00
|
|
|
* Fix `route` matcher so that when controller and action are specified in hash
|
|
|
|
|
notation (e.g. `posts#show`), route parameters such as `id` do not need to be
|
2014-11-20 19:48:22 +00:00
|
|
|
specified as a string but may be specified as a number as well. ([#602])
|
2014-11-18 09:22:39 +00:00
|
|
|
|
2015-01-30 17:42:00 +00:00
|
|
|
* Fix `allow_value`, `validate_numericality_of` and `validate_inclusion_of` so
|
|
|
|
|
that they handle RangeErrors emitted from ActiveRecord 4.2. These exceptions
|
|
|
|
|
arise whenever we attempt to set an attribute using a value that lies outside
|
|
|
|
|
the range of the column (assuming the column is an integer). RangeError is now
|
|
|
|
|
treated specially, failing the test instead of bubbling up as an error.
|
|
|
|
|
([#634], [#637], [#642])
|
|
|
|
|
|
2014-11-04 21:23:53 +00:00
|
|
|
### Features
|
|
|
|
|
|
|
|
|
|
* Add ability to test `:primary_key` option on associations. ([#597])
|
2014-11-21 18:30:02 +00:00
|
|
|
|
2014-11-20 19:27:12 +00:00
|
|
|
* Add `allow_blank` qualifier to `validate_uniqueness_of` to complement
|
2014-11-20 19:48:22 +00:00
|
|
|
the `allow_blank` option. ([#543])
|
2014-11-04 21:23:53 +00:00
|
|
|
|
2014-11-21 18:30:02 +00:00
|
|
|
* Change `set_session` so that #[] and #to qualifiers are optional, similar to
|
|
|
|
|
`set_flash`. That is, you can now say `should set_session` to assert that any
|
|
|
|
|
flash value has been set, or `should set_session.to('value')` to assert that
|
|
|
|
|
any value in the session is 'value'.
|
|
|
|
|
|
|
|
|
|
* Change `set_session` so that its #to qualifier supports regexps, similar to
|
|
|
|
|
`set_flash`.
|
|
|
|
|
|
2014-12-04 11:07:34 +00:00
|
|
|
* Add `with_prefix` qualifier to `delegate_method` to correspond to the `prefix`
|
2014-12-25 06:03:18 +00:00
|
|
|
option for Rails's `delegate` macro. ([#622])
|
2014-12-04 11:07:34 +00:00
|
|
|
|
2014-12-25 06:03:18 +00:00
|
|
|
* Add support for Rails 4.2, especially fixing `serialize` matcher to remove
|
|
|
|
|
warning about `serialized_attributes` being deprecated. ([#627])
|
2014-12-25 05:56:33 +00:00
|
|
|
|
2015-01-30 17:42:00 +00:00
|
|
|
* Update `dependent` qualifier on association matchers to support `:destroy`,
|
|
|
|
|
`:delete`, `:nullify`, `:restrict`, `:restrict_with_exception`, and
|
|
|
|
|
`:restrict_with_error`. You can also pass `true` or `false` to assert that
|
|
|
|
|
the association has (or has not) been declared with *any* dependent option.
|
|
|
|
|
([#631])
|
|
|
|
|
|
2014-10-21 07:35:29 +00:00
|
|
|
### Improvements
|
|
|
|
|
|
|
|
|
|
* Tweak `allow_value` failure message so that it reads a bit nicer when listing
|
|
|
|
|
existing errors.
|
|
|
|
|
|
2014-10-09 06:30:27 +00:00
|
|
|
[#591]: https://github.com/thoughtbot/shoulda-matchers/pull/591
|
|
|
|
|
[#592]: https://github.com/thoughtbot/shoulda-matchers/pull/592
|
2014-09-21 22:21:52 +00:00
|
|
|
[#588]: https://github.com/thoughtbot/shoulda-matchers/pull/588
|
2014-09-10 20:32:46 +00:00
|
|
|
[#584]: https://github.com/thoughtbot/shoulda-matchers/pull/584
|
2014-10-21 07:35:29 +00:00
|
|
|
[#593]: https://github.com/thoughtbot/shoulda-matchers/pull/593
|
2014-10-07 21:05:16 +00:00
|
|
|
[#597]: https://github.com/thoughtbot/shoulda-matchers/pull/597
|
2014-11-05 18:07:29 +00:00
|
|
|
[#537]: https://github.com/thoughtbot/shoulda-matchers/pull/537
|
2014-10-10 05:50:03 +00:00
|
|
|
[#598]: https://github.com/thoughtbot/shoulda-matchers/pull/598
|
2014-11-18 09:22:39 +00:00
|
|
|
[#602]: https://github.com/thoughtbot/shoulda-matchers/pull/602
|
2014-11-20 19:48:22 +00:00
|
|
|
[#543]: https://github.com/thoughtbot/shoulda-matchers/pull/543
|
2014-12-04 11:07:34 +00:00
|
|
|
[#622]: https://github.com/thoughtbot/shoulda-matchers/pull/622
|
2014-12-25 06:03:18 +00:00
|
|
|
[#627]: https://github.com/thoughtbot/shoulda-matchers/pull/627
|
2015-01-30 17:42:00 +00:00
|
|
|
[#631]: https://github.com/thoughtbot/shoulda-matchers/pull/631
|
|
|
|
|
[#634]: https://github.com/thoughtbot/shoulda-matchers/pull/634
|
|
|
|
|
[#637]: https://github.com/thoughtbot/shoulda-matchers/pull/637
|
|
|
|
|
[#642]: https://github.com/thoughtbot/shoulda-matchers/pull/642
|
2014-10-09 04:45:12 +00:00
|
|
|
|
2014-09-03 06:38:41 +00:00
|
|
|
# 2.7.0
|
|
|
|
|
|
2014-09-03 06:31:03 +00:00
|
|
|
### Deprecations
|
|
|
|
|
|
|
|
|
|
* `ensure_inclusion_of` has been renamed to `validate_inclusion_of`.
|
|
|
|
|
`ensure_inclusion_of` is deprecated and will be removed in 3.0.0.
|
|
|
|
|
|
|
|
|
|
* `ensure_exclusion_of` has been renamed to `validate_exclusion_of`.
|
|
|
|
|
`ensure_exclusion_of` is deprecated and will be removed in 3.0.0.
|
|
|
|
|
|
2014-05-24 18:57:18 +00:00
|
|
|
### Bug fixes
|
|
|
|
|
|
2014-07-26 05:33:05 +00:00
|
|
|
* Fix `delegate_method` so that it does not raise an error if the method that
|
|
|
|
|
returns the delegate object is private.
|
2014-05-24 18:57:18 +00:00
|
|
|
|
2014-05-26 02:27:49 +00:00
|
|
|
* Warn when `ensure_inclusion_of` is chained with `.in_array([false, true])`
|
|
|
|
|
as well as with `.in_array([true, false])`.
|
|
|
|
|
|
2014-08-08 20:21:10 +00:00
|
|
|
* Fix `set_session` so that the `to` qualifier if given nil checks that the
|
|
|
|
|
session variable in question was set to nil (previously this actually did
|
|
|
|
|
nothing).
|
|
|
|
|
|
2014-08-07 22:06:29 +00:00
|
|
|
* Fix `filter_param` so that it works when `config.filter_parameters` contains
|
|
|
|
|
regexes.
|
|
|
|
|
|
2014-08-02 14:55:56 +00:00
|
|
|
* Fix `delegate_method` so that it can be required independent of Active
|
|
|
|
|
Support.
|
|
|
|
|
|
2014-08-07 14:03:28 +00:00
|
|
|
* Fix `validate_uniqueness_of`. When used against an unpersisted record whose
|
|
|
|
|
model contained a non-nullable column other than the one being validated, the
|
|
|
|
|
matcher would break. Even if the test set that column to a value beforehand,
|
|
|
|
|
the record had to be persisted in order for the matcher to work. Now this is
|
|
|
|
|
no longer the case and the record can remain unpersisted.
|
|
|
|
|
|
2014-04-25 13:39:24 +00:00
|
|
|
* Fix `validate_absence_of`: it required that a string be passed as the
|
|
|
|
|
attribute name rather than a symbol (which is the usual and documented usage).
|
|
|
|
|
|
2014-11-04 21:23:53 +00:00
|
|
|
### Features
|
|
|
|
|
|
|
|
|
|
* Add new matcher `define_enum_for` to test usage of the `enum` macro introduced
|
|
|
|
|
in Rails 4.1.
|
|
|
|
|
|
2014-07-21 06:10:03 +00:00
|
|
|
### Improvements
|
|
|
|
|
|
|
|
|
|
* `have_and_belongs_to_many` now checks to make sure that the join table
|
|
|
|
|
contains the correct columns for the left- and right-hand side of the
|
|
|
|
|
association.
|
|
|
|
|
|
2014-09-03 05:52:09 +00:00
|
|
|
* Reword failure message for `delegate_method` so that it's a little more
|
|
|
|
|
helpful.
|
|
|
|
|
|
2014-07-19 00:07:32 +00:00
|
|
|
# 2.6.2
|
|
|
|
|
|
2014-06-12 22:12:54 +00:00
|
|
|
### Bug fixes
|
|
|
|
|
|
Use same assertion class as Rails, if loaded
Given this scenario:
* Using Rails 4.1
* Gemfile has `gem 'shoulda-matchers', require: false`
* spec_helper has `require 'shoulda/matchers'` following
`require 'rspec/rails'`
* Using Spring to run tests
matchers that delegate to assertions in Rails (e.g. `render_template`
and `route`) will fail in the wrong way if used. They fail because in
order to use these assertions, we expect that the assertions will
raise a specific exception, an exception that corresponds to whichever
test framework that Rails is using. For Rails versions that used
Test::Unit, this is Test::Unit::AssertionFailedError. For current Rails
versions, which now use Minitest, this exception is Minitest::Assertion.
The problem is that instead of asking Rails which exception class it's
using, we are trying to detect this exception class ourselves (for
cases in which Rails is not being used). This leads to the wrong class
being detected: when using a Rails version that uses Minitest, we choose
Test::Unit::AssertionFailedError as the class. This happens using the
exact scenario above because even though shoulda-matchers is loaded
after rspec-rails, rspec-rails itself defines
Test::Unit::AssertionFailedError.
Also add Cucumber tests that confirms this exact scenario works.
2014-06-22 03:24:22 +00:00
|
|
|
* If you have a Rails >= 4.1 project and you are running tests using Spring,
|
|
|
|
|
matchers that depend on assertions within Rails' testing layer (e.g.
|
|
|
|
|
`render_template` and `route`) will no longer fail.
|
|
|
|
|
|
2014-06-12 22:12:54 +00:00
|
|
|
* Fix `permit` so that it can be used more than once in the same test.
|
|
|
|
|
|
2014-05-09 21:07:18 +00:00
|
|
|
* Revert change to `validate_uniqueness_of` made in 2.6.0 so that it no longer
|
|
|
|
|
provides default values for non-primary, non-nullable columns. This approach
|
|
|
|
|
was causing test failures because it makes the assumption that none of these
|
|
|
|
|
columns allow only specific values, which is not true. If you get an error
|
|
|
|
|
from `validate_uniqueness_of`, your best bet continues to be creating a record
|
|
|
|
|
manually and calling `validate_uniqueness_of` on that instead.
|
|
|
|
|
|
2014-06-27 22:39:39 +00:00
|
|
|
* The majority of warnings that the gem produced have been removed. The gem
|
|
|
|
|
still produces warnings under Ruby 1.9.3; we will address this in a future
|
|
|
|
|
release.
|
|
|
|
|
|
2014-04-30 21:52:47 +00:00
|
|
|
# 2.6.1
|
2014-04-15 21:16:01 +00:00
|
|
|
|
2014-05-09 21:07:18 +00:00
|
|
|
### Bug fixes
|
2014-04-26 15:10:17 +00:00
|
|
|
|
2014-04-26 15:13:57 +00:00
|
|
|
* Revert changes to `validate_numericality_of` made in the last release, which
|
|
|
|
|
made it so that comparison qualifiers specified on the validation are tested
|
|
|
|
|
using a very small decimal number offset rather than a whole number by
|
|
|
|
|
default, except if the matcher was qualified with `only_integer`. This means
|
|
|
|
|
that prior to 2.6.0, if your validation specified `only_integer` and you did
|
2014-04-30 21:52:47 +00:00
|
|
|
not, then after 2.6.0 that test would fail. This is now fixed.
|
2014-04-15 21:16:01 +00:00
|
|
|
|
2014-04-30 21:52:47 +00:00
|
|
|
* Fix regression in previous release where ActiveRecord matchers would not be
|
|
|
|
|
included when ActiveRecord wasn't defined (i.e. if you were using ActiveModel
|
|
|
|
|
only).
|
2014-04-15 13:16:32 +00:00
|
|
|
|
2014-04-16 06:24:02 +00:00
|
|
|
* Revert the behavior of `allow_value` changed in 2.6.0 (it will no longer raise
|
|
|
|
|
CouldNotClearAttribute). This was originally done as a part of a fix for
|
|
|
|
|
`validate_presence_of` when used in conjunction with `has_secure_password`.
|
|
|
|
|
That fix has been updated so that it does not affect `allow_value`.
|
|
|
|
|
|
2014-04-16 20:12:36 +00:00
|
|
|
* Fix callback matchers and correct test coverage.
|
|
|
|
|
|
2014-04-20 02:48:43 +00:00
|
|
|
* Fix `permit` so that it does not interfere with different usages of `params`
|
|
|
|
|
in your controller action. Specifically, this will not raise an error:
|
|
|
|
|
`params.fetch(:foo, {}).permit(:bar, :baz)` (the `permit` will have no
|
|
|
|
|
problems recognizing that :bar and :baz are permitted params).
|
|
|
|
|
|
|
|
|
|
* Fix `permit` on Rails 4.1 to use PATCH by default for #update instead of PUT.
|
|
|
|
|
Previously you had to specify this manually.
|
|
|
|
|
|
|
|
|
|
* Fix `permit` so that it track multiple calls to #permit in your controller
|
|
|
|
|
action. Previously only the last usage of #permit would be considered in
|
|
|
|
|
determining whether the matcher matched.
|
|
|
|
|
|
|
|
|
|
* Fix `permit` so that if the route for your action requires params (such as id)
|
|
|
|
|
then you can now specify those params:
|
|
|
|
|
`permit(:first_name, :last_name).for(:update, params: { id: 42 })`.
|
2014-04-16 08:58:05 +00:00
|
|
|
|
2014-04-20 23:12:25 +00:00
|
|
|
* Fix `delegate_method` so that it does not stub the target method forever,
|
|
|
|
|
returning it to its original implementation after the match ends.
|
|
|
|
|
|
2014-04-19 15:53:51 +00:00
|
|
|
* Fix `validate_uniqueness_of` to work with Rails 4.1 enum columns.
|
|
|
|
|
|
2014-11-04 21:23:53 +00:00
|
|
|
### Features
|
|
|
|
|
|
|
|
|
|
* Teach `with_message` qualifier on `allow_value` to accept a hash of i18n
|
|
|
|
|
interpolation values:
|
|
|
|
|
`allow_value('foo').for(:attr).with_message(:greater_than, values: { count: 20 })`.
|
|
|
|
|
|
2014-04-12 21:42:19 +00:00
|
|
|
# 2.6.0
|
2013-09-20 20:11:59 +00:00
|
|
|
|
2014-04-11 21:30:19 +00:00
|
|
|
* The boolean argument to `have_db_index`'s `unique` option is now optional, for
|
|
|
|
|
consistency with other matchers.
|
2014-03-04 12:47:16 +00:00
|
|
|
|
2014-01-10 17:25:14 +00:00
|
|
|
* Association matchers now test that the model being referred to (either
|
|
|
|
|
implicitly or explicitly, using `:class_name`) actually exists.
|
|
|
|
|
|
2014-01-22 20:40:38 +00:00
|
|
|
* Add ability to test `:autosave` option on associations.
|
|
|
|
|
|
2014-01-20 22:26:34 +00:00
|
|
|
* Fix `validate_uniqueness_of(...).allow_nil` so that it can be used against an
|
|
|
|
|
non-password attribute which is in a model that `has_secure_password`. Doing
|
|
|
|
|
so previously would result in a "Password digest missing on new record" error.
|
|
|
|
|
|
2014-01-13 01:43:36 +00:00
|
|
|
* Fix description for `validate_numericality_of` so that if the matcher fails,
|
|
|
|
|
the error message reported does not say the matcher accepts integer values if
|
|
|
|
|
you didn't specify that.
|
|
|
|
|
|
Handle ensure_inclusion_of for boolean columns
Currently, using `ensure_inclusion_of` against a boolean column doesn't
work. We can assert that the column allows boolean values, but what
about values that should be rejected? Well, it depends on what you give
to `ensure_inclusion_of`. Here's how it works now:
* `ensure_inclusion_of(:attr).in_array([true])` asserts that false is
rejected
* `ensure_inclusion_of(:attr).in_array([false])` asserts that true is
rejected
* `ensure_inclusion_of(:attr).in_array([true, false])` does not assert
that anything is rejected, instead informing the developer how
this sort of expectation is not fully testable (anything other than
true, false, or nil will be converted to false).
* `ensure_inclusion_of(:attr).in_array([nil])`, when the column is
nullable, does not assert that anything is rejected, either, also
printing a warning
* `ensure_inclusion_of(:attr).in_array([nil])`, when the column is
non-nullable, raises an error because this expectation is not testable
in any way, as setting a boolean column to nil this way will get
converted to false.
2014-01-21 23:46:23 +00:00
|
|
|
* Fix `ensure_inclusion_of` so that you can use it against a boolean column
|
|
|
|
|
(and pass boolean values to `in_array`). There are two caveats:
|
|
|
|
|
|
|
|
|
|
* You should not test that your attribute allows both true and false
|
|
|
|
|
(`.in_array([true, false]`); there's no way to test that it doesn't accept
|
|
|
|
|
anything other than that.
|
|
|
|
|
* You cannot test that your attribute allows nil (`.in_array([nil])`) if
|
|
|
|
|
the column does not allow null values.
|
|
|
|
|
|
2014-02-10 22:52:40 +00:00
|
|
|
* Change `validate_uniqueness_of(...)` so that it provides default values for
|
|
|
|
|
non-nullable attributes.
|
|
|
|
|
|
2014-04-25 13:39:24 +00:00
|
|
|
* Running `rake` now installs Appraisals before running the test suite.
|
2014-04-11 21:30:19 +00:00
|
|
|
(Additionally, we now manage Appraisals using the `appraisal` executable in
|
|
|
|
|
Appraisal 1.0.0.)
|
2014-01-20 18:39:18 +00:00
|
|
|
|
2014-02-21 22:31:48 +00:00
|
|
|
* Add `allow_nil` option to `validate_numericality_of` so that you can validate
|
|
|
|
|
that numeric values are validated only if a value is supplied.
|
|
|
|
|
|
2014-02-27 03:26:37 +00:00
|
|
|
* Fix `validate_numericality_of` so that test fails when the value with
|
|
|
|
|
`greater_than`, `greater_than_or_equal_to`, `less_than`, `less_than_or_equal_
|
|
|
|
|
to` or `equal_to` is not appropriate.
|
|
|
|
|
|
2013-11-22 20:46:59 +00:00
|
|
|
* Change `validate_presence_of` under Rails 4 so that if you are using it with a
|
|
|
|
|
user whose model `has_secure_password` and whose password is set to a value,
|
|
|
|
|
you will be instructed to use a user whose password is blank instead. The
|
|
|
|
|
reason for this change is due to the fact that Rails 4's version of
|
|
|
|
|
`has_secure_password` defines #password= such that `nil` will be ignored,
|
|
|
|
|
which interferes with how `validate_presence_of` works.
|
|
|
|
|
|
2014-03-19 03:13:28 +00:00
|
|
|
* Add ability to test `belongs_to` associations defined with `:inverse_of`.
|
|
|
|
|
|
2014-04-11 21:30:19 +00:00
|
|
|
* Add back matchers that were removed in 2.0.0: `permit`, for testing strong
|
|
|
|
|
parameters, and `delegate_method`, for testing delegation.
|
|
|
|
|
|
|
|
|
|
* Add new matchers for testing controller filters: `before_filter`,
|
|
|
|
|
`after_filter`, and `around_filter` (aliased to `before_action`,
|
|
|
|
|
`after_action` and `around_action` for Rails 4).
|
|
|
|
|
|
2014-02-18 22:54:27 +00:00
|
|
|
* Fix `rescue_from` matcher so that it does not raise an error when testing
|
|
|
|
|
a method handler which has been marked as protected or private.
|
|
|
|
|
|
2014-04-11 21:30:19 +00:00
|
|
|
* Fix compatibility issues with Rails 4.1:
|
2014-04-11 20:48:52 +00:00
|
|
|
* `set_the_flash` and `have_and_belongs_to_many` no longer raise errors
|
|
|
|
|
* Minitest no longer prints warnings whenever shoulda-matchers is required
|
|
|
|
|
|
2014-01-10 22:37:34 +00:00
|
|
|
# v 2.5.0
|
|
|
|
|
|
2013-10-10 19:34:51 +00:00
|
|
|
* Fix Rails/Test::Unit integration to ensure that the test case classes we are
|
|
|
|
|
re-opening actually exist.
|
|
|
|
|
|
2014-01-10 22:14:19 +00:00
|
|
|
* Fix `ensure_length_of` so that it uses the right message to validate when
|
|
|
|
|
`is_equal_to` is specified in conjunction with a custom message.
|
|
|
|
|
|
2013-10-15 22:12:17 +00:00
|
|
|
* The `route` matcher now accepts specifying a controller/action pair as a
|
|
|
|
|
string instead of only a hash (e.g. `route(...).to('posts#index')` instead of
|
|
|
|
|
`route(...).to(controller: 'posts', action: 'index')`).
|
|
|
|
|
|
2013-10-25 20:41:59 +00:00
|
|
|
* The `ensure_inclusion_of` matcher now works with a decimal column.
|
|
|
|
|
|
2014-01-10 22:14:19 +00:00
|
|
|
* Under Rails 3, if you had an association matcher chained with the
|
|
|
|
|
the `order` submatcher -- e.g. `should have_many(:foos).order(:bar)` -- and
|
|
|
|
|
your association had an `:include` on it, using the matcher would raise an
|
|
|
|
|
error. This has been fixed.
|
2013-10-21 00:41:30 +00:00
|
|
|
|
2014-01-10 22:14:19 +00:00
|
|
|
* Fix `validate_uniqueness_of` so it doesn't fail if the attribute under
|
|
|
|
|
test has a limit of fewer than 16 characters.
|
2013-11-11 23:38:07 +00:00
|
|
|
|
2013-11-27 18:18:46 +00:00
|
|
|
* You can now test that your `has_many :through` or `has_one :through`
|
|
|
|
|
associations are defined with a `:source` option.
|
|
|
|
|
|
2014-01-10 22:14:19 +00:00
|
|
|
* Add new matcher `validates_absence_of`.
|
|
|
|
|
|
|
|
|
|
* Update matchers so that they use `failure_message` and
|
|
|
|
|
`failure_message_when_negated` to define error messages. These are new methods
|
|
|
|
|
in the upcoming RSpec 3 release which replace `failure_message_for_should` and
|
|
|
|
|
`failure_message_for_should_not`. We've kept backward compatibility so all of
|
|
|
|
|
your existing tests should still work -- this is just to make sure when RSpec
|
|
|
|
|
3 is released you don't get a bunch of warnings.
|
2013-12-05 16:38:30 +00:00
|
|
|
|
2013-09-20 20:11:59 +00:00
|
|
|
# v 2.4.0
|
2013-10-10 19:34:51 +00:00
|
|
|
|
2013-09-13 18:23:39 +00:00
|
|
|
* Fix a bug with the `validate_numericality_of` matcher that would not allow the
|
|
|
|
|
`with_message` option on certain submatchers.
|
2013-03-28 19:56:05 +00:00
|
|
|
|
2013-08-28 10:08:06 +00:00
|
|
|
* Fix a regression with context-dependent validations in ActiveResource
|
|
|
|
|
|
2013-08-16 22:47:08 +00:00
|
|
|
* shoulda-matchers is now fully compatible with Rails 4.
|
|
|
|
|
|
|
|
|
|
* When not using RSpec, shoulda-matchers is now auto-included into
|
|
|
|
|
ActiveSupport::TestCase instead of Test::Unit::TestCase (in Rails 4
|
|
|
|
|
the former no longer inherits from the latter).
|
|
|
|
|
|
2013-08-16 17:05:00 +00:00
|
|
|
# v 2.3.0
|
|
|
|
|
|
2013-08-15 01:40:07 +00:00
|
|
|
* Fix a bug in `ensure_inclusion_of` that would cause issues with using
|
|
|
|
|
`in_array` with an integer value.
|
|
|
|
|
|
2013-08-06 07:26:02 +00:00
|
|
|
* Add support for PostgreSQL UUID columns to `validates_uniqueness_of` (#334).
|
|
|
|
|
|
2013-07-30 03:31:24 +00:00
|
|
|
* Fix `validates_numericality_of` so that `is_equal_to` submatcher works
|
|
|
|
|
correctly (#326).
|
|
|
|
|
|
2013-08-10 21:38:59 +00:00
|
|
|
* Fix context support for validation matchers and disallowed values (#313).
|
2013-07-02 02:16:32 +00:00
|
|
|
|
2013-08-10 21:38:59 +00:00
|
|
|
* Add a `counter_cache` submatcher for `belongs_to` associations (#311).
|
2013-06-19 23:52:46 +00:00
|
|
|
|
2013-08-10 21:38:59 +00:00
|
|
|
* Add a `rescue_from` matcher for Rails controllers which checks that the
|
|
|
|
|
correct ActiveSupport call has been made and that the handlers exist without
|
|
|
|
|
actually throwing an exception (#287).
|
2013-04-26 20:34:21 +00:00
|
|
|
|
2013-06-14 15:21:50 +00:00
|
|
|
* Changed the scope of AssociationMatcher methods from protected to private.
|
|
|
|
|
|
2013-06-07 14:14:27 +00:00
|
|
|
* Extracted `#order`, `#through`, and `#dependent` from AssociationMatcher as
|
2013-08-10 21:38:59 +00:00
|
|
|
their own submatchers.
|
2013-06-07 14:14:27 +00:00
|
|
|
|
2013-06-11 14:35:05 +00:00
|
|
|
# v 2.2.0
|
|
|
|
|
|
2013-05-03 22:31:37 +00:00
|
|
|
* Fix `have_and_belong_to_many` matcher issue for Rails 4.
|
|
|
|
|
|
2013-05-17 18:10:19 +00:00
|
|
|
* Fix `validate_uniqueness_of.scoped_to` issue when the scoped field is already
|
|
|
|
|
taken (#207).
|
|
|
|
|
|
2013-05-24 03:26:45 +00:00
|
|
|
* Add comparison submatchers to `validate_numericality_of` to correspond to the
|
|
|
|
|
comparison options you can give to `validates_numericality_of` (#244).
|
|
|
|
|
|
2013-05-05 15:51:57 +00:00
|
|
|
# v 2.1.0
|
|
|
|
|
|
2013-04-12 17:11:07 +00:00
|
|
|
* Add missing `failure_message_for_should_not` implementations to
|
|
|
|
|
`validate_numericality_of` and its submatchers
|
|
|
|
|
|
2013-08-10 21:38:59 +00:00
|
|
|
* Support validation contexts for testing validations `on: :create` and when
|
|
|
|
|
using custom contexts like `model.valid?(:my_context)`.
|
2013-03-04 03:34:38 +00:00
|
|
|
|
2013-03-26 12:59:05 +00:00
|
|
|
* Fix a bug in validations with autosaved models.
|
|
|
|
|
|
2013-04-26 15:48:44 +00:00
|
|
|
* Fix maximum value detection for the `ensure_inclusion_of` and
|
|
|
|
|
`ensure_exclusion_of` matchers.
|
|
|
|
|
|
2013-03-19 04:50:39 +00:00
|
|
|
* Add `:odd` and `:even` options to the `validate_numericality_of` matcher.
|
2013-04-26 15:48:44 +00:00
|
|
|
|
|
|
|
|
* Add `:touch` option to AssociationMatcher.
|
|
|
|
|
|
2013-03-15 20:52:55 +00:00
|
|
|
* Ruby 2.0.0 is now officially supported.
|
2013-04-26 15:48:44 +00:00
|
|
|
|
|
|
|
|
* Fix the issue where using `%{attribute}` or `%{model}` in I18n translations
|
|
|
|
|
raised exceptions.
|
|
|
|
|
|
|
|
|
|
* Support datetime columns in `validate_uniqueness_of.scoped_to`.
|
|
|
|
|
|
|
|
|
|
* Add `allow_nil` option to the `validate_uniqueness_of` matcher.
|
2012-11-02 18:48:35 +00:00
|
|
|
|
2013-03-19 22:55:19 +00:00
|
|
|
# v 2.0.0
|
|
|
|
|
* Remove the following matchers:
|
|
|
|
|
* `assign_to`
|
|
|
|
|
* `respond_with_content_type`
|
|
|
|
|
* `query_the_database`
|
|
|
|
|
* `validate_format_of`
|
|
|
|
|
* `have_sent_email`
|
|
|
|
|
* `permit` (strong parameters matcher)
|
|
|
|
|
* `delegate_method`
|
2013-04-26 15:48:44 +00:00
|
|
|
|
2013-03-19 22:55:19 +00:00
|
|
|
* For more information about 2.0 changes, see:
|
2013-04-26 15:48:44 +00:00
|
|
|
http://robots.thoughtbot.com/post/47031676783/shoulda-matchers-2-0.
|
2013-03-19 22:55:19 +00:00
|
|
|
|
2013-03-29 20:45:43 +00:00
|
|
|
# v 1.5.6
|
2013-04-26 15:48:44 +00:00
|
|
|
* Revert previous change in AllowValueMatcher that added a check for a
|
2013-03-29 20:10:01 +00:00
|
|
|
properly-set attribute.
|
|
|
|
|
|
2013-03-28 19:56:05 +00:00
|
|
|
# v 1.5.5
|
2013-04-26 15:48:44 +00:00
|
|
|
* AllowValueMatcher checks that the right value is used for attempts at
|
|
|
|
|
setting the attribute with it.
|
2013-03-26 22:16:04 +00:00
|
|
|
* Please note that previously-passing tests might now fail. It is likely that
|
|
|
|
|
it's not a bug, but please make sure that the code you're testing is written
|
|
|
|
|
properly before submitting an issue.
|
2013-04-26 15:48:44 +00:00
|
|
|
|
|
|
|
|
* Use DisallowValueMatcher for `disallows_value_of` method.
|
|
|
|
|
|
|
|
|
|
* Assert `class_name` value on real class name for AssociationMatcher.
|
|
|
|
|
|
|
|
|
|
* Correct the variable used for `validate_confirmation_of` matcher description.
|
2013-03-15 21:18:00 +00:00
|
|
|
|
2013-03-21 19:50:13 +00:00
|
|
|
# v 1.5.4
|
2013-04-26 15:48:44 +00:00
|
|
|
* Properly-released version of 1.5.3.
|
2013-03-21 19:50:13 +00:00
|
|
|
|
|
|
|
|
# v 1.5.3 - yanked due to mis-release
|
2013-04-26 15:48:44 +00:00
|
|
|
* Alleviate the need to add `rspec` gem to your app.
|
2013-03-21 19:18:50 +00:00
|
|
|
|
2013-03-19 13:37:56 +00:00
|
|
|
# v 1.5.1
|
2013-04-19 21:14:26 +00:00
|
|
|
* Bump version dependency of Bourne to allow for Mocha upgrade.
|
2013-04-26 15:48:44 +00:00
|
|
|
|
2013-04-19 21:14:26 +00:00
|
|
|
* Should fix incompatibility with MiniTest.
|
2013-03-19 13:37:56 +00:00
|
|
|
|
2013-03-15 21:18:00 +00:00
|
|
|
# v 1.5.0
|
|
|
|
|
* Deprecate the following matchers:
|
2013-04-26 15:48:44 +00:00
|
|
|
* `assign_to`
|
|
|
|
|
* `respond_with_content_type`
|
|
|
|
|
* `query_the_database`
|
|
|
|
|
* `validate_format_of`
|
|
|
|
|
* `have_sent_email`
|
|
|
|
|
* `permit` (strong parameters matcher)
|
|
|
|
|
* `delegate_method`
|
2013-03-15 21:18:00 +00:00
|
|
|
|
2012-12-25 22:26:33 +00:00
|
|
|
* Use RSpec's native `configure.include` syntax for including matchers into
|
2013-04-26 15:48:44 +00:00
|
|
|
RSpec (#204).
|
2012-12-25 22:26:33 +00:00
|
|
|
|
2013-04-19 21:14:26 +00:00
|
|
|
* Do not force MiniTest loading when test-unit is available (this was fixed
|
2013-04-26 15:48:44 +00:00
|
|
|
before 1.3.0 then reverted in 1.3.0).
|
2013-01-03 20:17:38 +00:00
|
|
|
|
2012-11-30 15:31:52 +00:00
|
|
|
# v1.4.2
|
2013-04-26 15:48:44 +00:00
|
|
|
* Add a new `delegate_method` matcher.
|
2012-11-30 15:31:52 +00:00
|
|
|
|
2012-10-15 15:48:11 +00:00
|
|
|
# v1.4.1
|
2013-04-26 15:48:44 +00:00
|
|
|
* Fix an issue when used with Test::Unit on the allow value matcher.
|
2012-10-15 15:48:11 +00:00
|
|
|
|
2013-04-26 15:48:44 +00:00
|
|
|
* Fix an issue with using `ensure_inclusion_of(:attr)` given an array of true or false values.
|
2012-10-15 15:48:11 +00:00
|
|
|
|
2012-10-05 17:25:13 +00:00
|
|
|
# v1.4.0
|
|
|
|
|
|
2013-04-26 15:48:44 +00:00
|
|
|
* Add `strict` option to validation matchers.
|
2012-10-05 17:25:13 +00:00
|
|
|
|
|
|
|
|
* Verify that arguments to `set_the_flash` matcher are valid.
|
|
|
|
|
|
|
|
|
|
* Fix issue in ValidateUniquenessMatcher that could cause an error on postgres.
|
|
|
|
|
|
|
|
|
|
* You can now pass an array to `ensure_exclusion_of` using `in_array`.
|
|
|
|
|
|
2013-01-03 20:17:38 +00:00
|
|
|
* Allow testing of `:foreign_key` option for `has_one` relationships using the association matcher.
|
2012-10-05 17:25:13 +00:00
|
|
|
|
|
|
|
|
* Fix bug where `ensure_length_of` would pass if the given string was too long.
|
|
|
|
|
|
|
|
|
|
* `allow_blank` will now allow values such as: ' ', '\n', and '\r'.
|
|
|
|
|
|
|
|
|
|
* Test outside values for `ensure_inclusion_of` when given an array.
|
|
|
|
|
|
2013-04-26 15:48:44 +00:00
|
|
|
* Fix the output of the `set_the_flash` matcher.
|
2012-10-05 17:25:13 +00:00
|
|
|
|
2012-08-30 18:19:26 +00:00
|
|
|
# v1.3.0
|
2012-06-15 17:28:56 +00:00
|
|
|
|
2013-04-26 15:48:44 +00:00
|
|
|
* `validate_format_of` will accept `allow_blank(bool)` and `allow_nil(bool)`.
|
2012-07-04 14:14:30 +00:00
|
|
|
|
2013-04-19 21:14:26 +00:00
|
|
|
* Prefer Test::Unit to MiniTest when loading integrations so that RubyMine is
|
2012-06-15 17:28:56 +00:00
|
|
|
happy (#88).
|
|
|
|
|
|
2012-05-11 15:36:22 +00:00
|
|
|
* `validates_uniqueness_of` will now create a record if one does not exist.
|
|
|
|
|
Previously, users were required to create a record in the database before
|
|
|
|
|
using this matcher.
|
|
|
|
|
|
2012-07-20 14:38:56 +00:00
|
|
|
* Fix an edge case when where the matchers weren't loaded into Test::Unit when
|
|
|
|
|
mixing RSpec and Test::Unit tests and also loading both the 'rspec-rails' gem
|
|
|
|
|
and 'shoulda-matchers' gem from the same Gemfile group, namely [:test,
|
|
|
|
|
:development].
|
|
|
|
|
|
2012-07-20 14:59:27 +00:00
|
|
|
* `controller.should_not render_partial` now correctly matches `render partial: "partial"`.
|
|
|
|
|
|
2012-06-14 19:40:39 +00:00
|
|
|
# v1.2.0
|
2012-04-20 15:46:47 +00:00
|
|
|
|
|
|
|
|
* `ensure_inclusion_of` now has an `in_array` parameter:
|
|
|
|
|
`ensure_inclusion_of(:attr).in_array(['foo', 'bar'])`. It cannot be used with
|
2012-04-20 15:47:21 +00:00
|
|
|
the `.in_range` option. (vpereira)
|
2012-04-20 15:46:47 +00:00
|
|
|
|
2012-05-10 15:15:40 +00:00
|
|
|
* `ensure_in_inclusion_of` with `in_array` will accept `allow_blank(bool)` and `allow_nil(false)`
|
|
|
|
|
|
2012-04-20 18:50:29 +00:00
|
|
|
* Test against Rails 3.2.
|
|
|
|
|
|
2012-04-20 18:56:58 +00:00
|
|
|
* Fix `ensure_length_of` to use all possible I18n error messages.
|
|
|
|
|
|
2012-04-23 21:37:40 +00:00
|
|
|
* `have_db_index.unique(nil)` used to function exactly the same as
|
|
|
|
|
`have_db_index` with no unique option. It now functions the same as
|
|
|
|
|
`have_db_index.unique(false)`.
|
|
|
|
|
|
2012-06-14 19:40:39 +00:00
|
|
|
* In 1.1.0, `have_sent_email` checked all emails to ensure they matched. It now
|
|
|
|
|
checks that only one email matches, which restores 1.0.0 behavior.
|
|
|
|
|
|
2012-04-13 15:02:27 +00:00
|
|
|
# v1.1.0
|
2012-04-04 00:57:53 +00:00
|
|
|
|
2013-04-26 15:48:44 +00:00
|
|
|
* Add `only_integer` option to `validate_numericality_of`:
|
2012-04-04 00:57:53 +00:00
|
|
|
`should validate_numericality_of(:attribute).only_integer`
|
2012-04-10 00:41:20 +00:00
|
|
|
|
2013-04-26 15:48:44 +00:00
|
|
|
* Add a `query_the_database` matcher:
|
2012-04-04 00:57:53 +00:00
|
|
|
|
|
|
|
|
`it { should query_the_database(4.times).when_calling(:complicated_method) }`
|
|
|
|
|
`it { should query_the_database(4.times).or_less.when_calling(:complicated_method) }`
|
|
|
|
|
`it { should_not query_the_database.when_calling(:complicated_method) }`
|
|
|
|
|
|
|
|
|
|
* Database columns are now correctly checked for primality. E.G., this works
|
|
|
|
|
now: `it { should have_db_column(:id).with_options(:primary => true) }`
|
|
|
|
|
|
|
|
|
|
* The flash matcher can check specific flash keys using [], like so:
|
|
|
|
|
`it { should set_the_flash[:alert].to("Password doesn't match") }`
|
|
|
|
|
|
2012-04-10 00:41:20 +00:00
|
|
|
* The `have_sent_email` matcher can check `reply_to`:
|
2012-04-04 00:57:53 +00:00
|
|
|
` it { should have_sent_email.reply_to([user, other]) }`
|
|
|
|
|
|
2013-04-26 15:48:44 +00:00
|
|
|
* Add `validates_confirmation_of` matcher:
|
2012-04-04 00:57:53 +00:00
|
|
|
`it { should validate_confirmation_of(:password) }`
|
|
|
|
|
|
2013-04-26 15:48:44 +00:00
|
|
|
* Add `serialize` matcher:
|
2012-04-04 00:57:53 +00:00
|
|
|
`it { should serialize(:details).as(Hash).as_instance_of(Hash) }`
|
2012-04-10 00:43:40 +00:00
|
|
|
|
|
|
|
|
* shoulda-matchers checks for all possible I18n keys, instead of just
|
|
|
|
|
e.g. `activerecord.errors.messages.blank`
|
2012-04-10 00:46:18 +00:00
|
|
|
|
2012-04-13 14:58:56 +00:00
|
|
|
* Add `accept_nested_attributes` matcher
|
|
|
|
|
|
2012-04-11 03:23:24 +00:00
|
|
|
* Our very first dependency: ActiveSupport >= 3.0.0
|