kotovalexarian-likes-github/thoughtbot--shoulda-matchers
1
0
Fork 0
mirror of https://github.com/thoughtbot/shoulda-matchers.git synced 2022-11-09 12:01:38 -05:00
Code Releases Activity
thoughtbot--shoulda-matchers/.rubocop.yml

255 lines
5.3 KiB
YAML
Raw Normal View History

Add the Packaging extension of RuboCop More about the extension can be found at: https://docs.rubocop.org/rubocop-packaging/ Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
2020-09-11 19:23:14 -04:00
require:
- rubocop-packaging
- rubocop-rails
Update Rubocop settings
2018-01-24 01:51:35 -05:00
AllCops:
Bump Rubocop from 0.71.0 to 0.89.1 Fix warning: The Metrics/LineLength has the wrong namespace - should be Layout Fix warning: The `Layout/AlignArguments` cop has been renamed to `Layout/ArgumentAlignment`. Fix warning: The `Layout/AlignParameters` cop has been renamed to `Layout/ParameterAlignment`. Fix warning: The `Layout/IndentHeredoc` cop has been renamed to `Layout/HeredocIndentation`. Fix warning: The `Lint/HandleExceptions` cop has been renamed to `Lint/SuppressedException`. Set new cops as disable for default
2020-08-29 11:51:21 -04:00
NewCops: disable
Update Rubocop settings
2018-01-24 01:51:35 -05:00
TargetRubyVersion: 2.4
fix(rubocop): Fix Layout/LineLength - bump rubocop to v1.0 - Fix Layout/MultilineAssignmentLayout and other remaining offences - Exculde appraisal generated gemfiles in rubocop - Replace NON_NUMERIC_VALUE constant with instance method against failing test case in rails <= 5.1 and postgres adapter. This is a defect in rails where a frozen string is modified in https://github.com/rails/rails/blob/v5.1.7/activerecord/lib/active_record/connection_adapters/postgresql/oid/money.rb#L25
2020-11-03 00:56:49 -05:00
Exclude:
- 'gemfiles/*'
Bundler/OrderedGems:
Include:
- '**/Gemfile'
Bump Rubocop from 0.71.0 to 0.89.1 Fix warning: The Metrics/LineLength has the wrong namespace - should be Layout Fix warning: The `Layout/AlignArguments` cop has been renamed to `Layout/ArgumentAlignment`. Fix warning: The `Layout/AlignParameters` cop has been renamed to `Layout/ParameterAlignment`. Fix warning: The `Layout/IndentHeredoc` cop has been renamed to `Layout/HeredocIndentation`. Fix warning: The `Lint/HandleExceptions` cop has been renamed to `Lint/SuppressedException`. Set new cops as disable for default
2020-08-29 11:51:21 -04:00
Layout/ArgumentAlignment:
Configure Hound * Prefer single quotes to double quotes * Align method parameters with fixed indentation [ci skip]
2015-01-03 20:19:00 -05:00
EnforcedStyle: with_fixed_indentation
Update Rubocop & Rubocop config
2019-05-30 02:28:00 -04:00
Layout/CommentIndentation:
Enabled: false
Simplify Rubocop configuration The original Rubocop configuration was copied from other thoughtbot projects. Of course, Rubocop comes with its own set of default settings. Therefore, we don't need to re-specify settings that it already has -- we only need to specify the ones that we're overriding. Besides this, Rubocop isn't even in the Gemfile, so even though Hound runs on GitHub automatically, it'd be nice to spot style issues as you are editing files. Given this, this commit simplifies the Rubocop configuration and also adds Rubocop to the Gemfile so that you can configure your editor to lint files as you are editing them.
2018-09-12 23:33:48 -04:00
Layout/ConditionPosition:
Enabled: false
Layout/DotPosition:
EnforcedStyle: trailing
Update Rubocop & Rubocop config
2019-05-30 02:28:00 -04:00
Layout/EmptyLineBetweenDefs:
AllowAdjacentOneLineDefs: true
Bump Rubocop from 0.71.0 to 0.89.1 Fix warning: The Metrics/LineLength has the wrong namespace - should be Layout Fix warning: The `Layout/AlignArguments` cop has been renamed to `Layout/ArgumentAlignment`. Fix warning: The `Layout/AlignParameters` cop has been renamed to `Layout/ParameterAlignment`. Fix warning: The `Layout/IndentHeredoc` cop has been renamed to `Layout/HeredocIndentation`. Fix warning: The `Lint/HandleExceptions` cop has been renamed to `Lint/SuppressedException`. Set new cops as disable for default
2020-08-29 11:51:21 -04:00
Layout/HeredocIndentation:
Update Rubocop & Rubocop config
2019-05-30 02:28:00 -04:00
Enabled: false
Bump Rubocop from 0.71.0 to 0.89.1 Fix warning: The Metrics/LineLength has the wrong namespace - should be Layout Fix warning: The `Layout/AlignArguments` cop has been renamed to `Layout/ArgumentAlignment`. Fix warning: The `Layout/AlignParameters` cop has been renamed to `Layout/ParameterAlignment`. Fix warning: The `Layout/IndentHeredoc` cop has been renamed to `Layout/HeredocIndentation`. Fix warning: The `Lint/HandleExceptions` cop has been renamed to `Lint/SuppressedException`. Set new cops as disable for default
2020-08-29 11:51:21 -04:00
Layout/LineLength:
fix(rubocop): Fix Style, Layout, Lint and other offenses [ci skip] Updated Layout/LineLength cop to Max 120 lenght and ignore everything inside specs/**/* Added rules for below cops in .rubocop.yml Lint/AmbiguousBlockAssociation Naming/HeredocDelimiterNaming Rails/SkipsModelValidations Style/FormatStringToken Fixed below mentioned cops: - Layout/CaseIndentation - Layout/DotPosition - Layout/ElseAlignment - Layout/IndentationWidth - Layout/LineLength - Layout/MultilineBlockLayout - Layout/MultilineOperationIndentation - Lint/AmbiguousBlockAssociation - Lint/MissingCopEnableDirective - Lint/NestedMethodDefinition - Lint/RedundantCopDisableDirective - Lint/RedundantRequireStatement - Lint/UnusedBlockArgument - Lint/UnusedMethodArgument - Metrics/ModuleLength - Naming/MemoizedInstanceVariableName - Naming/RescuedExceptionsVariableName - Rails/Output - Rails/Presence - Security/Eval - Security/Open - Style/ClassCheck - Style/CollectionMethods - Style/ConditionalAssignment - Style/EvalWithLocation - Style/FormatStringToken - Style/InverseMethods - Style/MutableConstant - Style/ParallelAssignment - Style/RedundantBegin - Style/RedundantCondition - Style/RedundantInterpolation - Style/RedundantSelf - Style/RedundantSort - Style/RescueStandardError - Style/SafeNavigation - Style/StringLiteralsInInterpolation - Style/SymbolProc
2020-09-06 09:09:31 -04:00
Exclude:
- spec/**/*
Bump Rubocop from 0.71.0 to 0.89.1 Fix warning: The Metrics/LineLength has the wrong namespace - should be Layout Fix warning: The `Layout/AlignArguments` cop has been renamed to `Layout/ArgumentAlignment`. Fix warning: The `Layout/AlignParameters` cop has been renamed to `Layout/ParameterAlignment`. Fix warning: The `Layout/IndentHeredoc` cop has been renamed to `Layout/HeredocIndentation`. Fix warning: The `Lint/HandleExceptions` cop has been renamed to `Lint/SuppressedException`. Set new cops as disable for default
2020-08-29 11:51:21 -04:00
IgnoredPatterns:
fix(rubocop): Fix Layout/LineLength - bump rubocop to v1.0 - Fix Layout/MultilineAssignmentLayout and other remaining offences - Exculde appraisal generated gemfiles in rubocop - Replace NON_NUMERIC_VALUE constant with instance method against failing test case in rails <= 5.1 and postgres adapter. This is a defect in rails where a frozen string is modified in https://github.com/rails/rails/blob/v5.1.7/activerecord/lib/active_record/connection_adapters/postgresql/oid/money.rb#L25
2020-11-03 00:56:49 -05:00
- !ruby/regexp /\A +(it|describe|context|shared_examples|include_examples|it_behaves_like) ["']/
- !ruby/regexp /\A(require|require_relative) ["']/
fix(rubocop): Fix Style, Layout, Lint and other offenses [ci skip] Updated Layout/LineLength cop to Max 120 lenght and ignore everything inside specs/**/* Added rules for below cops in .rubocop.yml Lint/AmbiguousBlockAssociation Naming/HeredocDelimiterNaming Rails/SkipsModelValidations Style/FormatStringToken Fixed below mentioned cops: - Layout/CaseIndentation - Layout/DotPosition - Layout/ElseAlignment - Layout/IndentationWidth - Layout/LineLength - Layout/MultilineBlockLayout - Layout/MultilineOperationIndentation - Lint/AmbiguousBlockAssociation - Lint/MissingCopEnableDirective - Lint/NestedMethodDefinition - Lint/RedundantCopDisableDirective - Lint/RedundantRequireStatement - Lint/UnusedBlockArgument - Lint/UnusedMethodArgument - Metrics/ModuleLength - Naming/MemoizedInstanceVariableName - Naming/RescuedExceptionsVariableName - Rails/Output - Rails/Presence - Security/Eval - Security/Open - Style/ClassCheck - Style/CollectionMethods - Style/ConditionalAssignment - Style/EvalWithLocation - Style/FormatStringToken - Style/InverseMethods - Style/MutableConstant - Style/ParallelAssignment - Style/RedundantBegin - Style/RedundantCondition - Style/RedundantInterpolation - Style/RedundantSelf - Style/RedundantSort - Style/RescueStandardError - Style/SafeNavigation - Style/StringLiteralsInInterpolation - Style/SymbolProc
2020-09-06 09:09:31 -04:00
- '^[ ]*#.+$'
- '^[ ]*''.+?'' => ''.+?'',?$'
- '^[ ]*".+?" => ".+?",?$'
fix(rubocop): Fix Layout/LineLength - bump rubocop to v1.0 - Fix Layout/MultilineAssignmentLayout and other remaining offences - Exculde appraisal generated gemfiles in rubocop - Replace NON_NUMERIC_VALUE constant with instance method against failing test case in rails <= 5.1 and postgres adapter. This is a defect in rails where a frozen string is modified in https://github.com/rails/rails/blob/v5.1.7/activerecord/lib/active_record/connection_adapters/postgresql/oid/money.rb#L25
2020-11-03 00:56:49 -05:00
Max: 80
Update Rubocop config [ci skip]
2019-01-29 20:49:38 -05:00
Layout/MultilineMethodCallIndentation:
EnforcedStyle: indented
Bump Rubocop from 0.71.0 to 0.89.1 Fix warning: The Metrics/LineLength has the wrong namespace - should be Layout Fix warning: The `Layout/AlignArguments` cop has been renamed to `Layout/ArgumentAlignment`. Fix warning: The `Layout/AlignParameters` cop has been renamed to `Layout/ParameterAlignment`. Fix warning: The `Layout/IndentHeredoc` cop has been renamed to `Layout/HeredocIndentation`. Fix warning: The `Lint/HandleExceptions` cop has been renamed to `Lint/SuppressedException`. Set new cops as disable for default
2020-08-29 11:51:21 -04:00
Layout/ParameterAlignment:
EnforcedStyle: with_fixed_indentation
Update Rubocop & Rubocop config
2019-05-30 02:28:00 -04:00
Layout/SpaceInLambdaLiteral:
EnforcedStyle: require_space
Bump rubocop from 0.89.1 to 0.90 [ci skip] - Sort cops alphabetically in .rubocop.yml
2020-09-04 01:05:02 -04:00
Layout/SpaceInsideBlockBraces:
Enabled: false
fix(rubocop): Fix Style, Layout, Lint and other offenses [ci skip] Updated Layout/LineLength cop to Max 120 lenght and ignore everything inside specs/**/* Added rules for below cops in .rubocop.yml Lint/AmbiguousBlockAssociation Naming/HeredocDelimiterNaming Rails/SkipsModelValidations Style/FormatStringToken Fixed below mentioned cops: - Layout/CaseIndentation - Layout/DotPosition - Layout/ElseAlignment - Layout/IndentationWidth - Layout/LineLength - Layout/MultilineBlockLayout - Layout/MultilineOperationIndentation - Lint/AmbiguousBlockAssociation - Lint/MissingCopEnableDirective - Lint/NestedMethodDefinition - Lint/RedundantCopDisableDirective - Lint/RedundantRequireStatement - Lint/UnusedBlockArgument - Lint/UnusedMethodArgument - Metrics/ModuleLength - Naming/MemoizedInstanceVariableName - Naming/RescuedExceptionsVariableName - Rails/Output - Rails/Presence - Security/Eval - Security/Open - Style/ClassCheck - Style/CollectionMethods - Style/ConditionalAssignment - Style/EvalWithLocation - Style/FormatStringToken - Style/InverseMethods - Style/MutableConstant - Style/ParallelAssignment - Style/RedundantBegin - Style/RedundantCondition - Style/RedundantInterpolation - Style/RedundantSelf - Style/RedundantSort - Style/RescueStandardError - Style/SafeNavigation - Style/StringLiteralsInInterpolation - Style/SymbolProc
2020-09-06 09:09:31 -04:00
Lint/AmbiguousBlockAssociation:
Exclude:
- spec/**/*
Simplify Rubocop configuration The original Rubocop configuration was copied from other thoughtbot projects. Of course, Rubocop comes with its own set of default settings. Therefore, we don't need to re-specify settings that it already has -- we only need to specify the ones that we're overriding. Besides this, Rubocop isn't even in the Gemfile, so even though Hound runs on GitHub automatically, it'd be nice to spot style issues as you are editing files. Given this, this commit simplifies the Rubocop configuration and also adds Rubocop to the Gemfile so that you can configure your editor to lint files as you are editing them.
2018-09-12 23:33:48 -04:00
Lint/AmbiguousOperator:
Enabled: false
Lint/AmbiguousRegexpLiteral:
Enabled: false
Lint/AssignmentInCondition:
Enabled: false
Lint/DeprecatedClassMethods:
Enabled: false
Lint/ElseLayout:
Enabled: false
Update Rubocop & Rubocop config
2019-05-30 02:28:00 -04:00
Lint/FlipFlop:
Simplify Rubocop configuration The original Rubocop configuration was copied from other thoughtbot projects. Of course, Rubocop comes with its own set of default settings. Therefore, we don't need to re-specify settings that it already has -- we only need to specify the ones that we're overriding. Besides this, Rubocop isn't even in the Gemfile, so even though Hound runs on GitHub automatically, it'd be nice to spot style issues as you are editing files. Given this, this commit simplifies the Rubocop configuration and also adds Rubocop to the Gemfile so that you can configure your editor to lint files as you are editing them.
2018-09-12 23:33:48 -04:00
Enabled: false
Lint/LiteralInInterpolation:
Enabled: false
Lint/Loop:
Enabled: false
fix(rubocop): Fix Layout/LineLength - bump rubocop to v1.0 - Fix Layout/MultilineAssignmentLayout and other remaining offences - Exculde appraisal generated gemfiles in rubocop - Replace NON_NUMERIC_VALUE constant with instance method against failing test case in rails <= 5.1 and postgres adapter. This is a defect in rails where a frozen string is modified in https://github.com/rails/rails/blob/v5.1.7/activerecord/lib/active_record/connection_adapters/postgresql/oid/money.rb#L25
2020-11-03 00:56:49 -05:00
Lint/MissingSuper:
Enabled: false
Simplify Rubocop configuration The original Rubocop configuration was copied from other thoughtbot projects. Of course, Rubocop comes with its own set of default settings. Therefore, we don't need to re-specify settings that it already has -- we only need to specify the ones that we're overriding. Besides this, Rubocop isn't even in the Gemfile, so even though Hound runs on GitHub automatically, it'd be nice to spot style issues as you are editing files. Given this, this commit simplifies the Rubocop configuration and also adds Rubocop to the Gemfile so that you can configure your editor to lint files as you are editing them.
2018-09-12 23:33:48 -04:00
Lint/ParenthesesAsGroupedExpression:
Enabled: false
Lint/RequireParentheses:
Enabled: false
Turn off more Rubocop checks
2019-07-06 22:25:27 -04:00
Lint/SafeNavigationChain:
Enabled: false
Bump Rubocop from 0.71.0 to 0.89.1 Fix warning: The Metrics/LineLength has the wrong namespace - should be Layout Fix warning: The `Layout/AlignArguments` cop has been renamed to `Layout/ArgumentAlignment`. Fix warning: The `Layout/AlignParameters` cop has been renamed to `Layout/ParameterAlignment`. Fix warning: The `Layout/IndentHeredoc` cop has been renamed to `Layout/HeredocIndentation`. Fix warning: The `Lint/HandleExceptions` cop has been renamed to `Lint/SuppressedException`. Set new cops as disable for default
2020-08-29 11:51:21 -04:00
Lint/SuppressedException:
Enabled: false
Simplify Rubocop configuration The original Rubocop configuration was copied from other thoughtbot projects. Of course, Rubocop comes with its own set of default settings. Therefore, we don't need to re-specify settings that it already has -- we only need to specify the ones that we're overriding. Besides this, Rubocop isn't even in the Gemfile, so even though Hound runs on GitHub automatically, it'd be nice to spot style issues as you are editing files. Given this, this commit simplifies the Rubocop configuration and also adds Rubocop to the Gemfile so that you can configure your editor to lint files as you are editing them.
2018-09-12 23:33:48 -04:00
Lint/UnderscorePrefixedVariableName:
Enabled: false
Lint/Void:
Enabled: false
Update Rubocop & Rubocop config
2019-05-30 02:28:00 -04:00
Metrics/AbcSize:
fix(rubocop): Fix Layout/LineLength - bump rubocop to v1.0 - Fix Layout/MultilineAssignmentLayout and other remaining offences - Exculde appraisal generated gemfiles in rubocop - Replace NON_NUMERIC_VALUE constant with instance method against failing test case in rails <= 5.1 and postgres adapter. This is a defect in rails where a frozen string is modified in https://github.com/rails/rails/blob/v5.1.7/activerecord/lib/active_record/connection_adapters/postgresql/oid/money.rb#L25
2020-11-03 00:56:49 -05:00
Enabled: false
Simplify Rubocop configuration The original Rubocop configuration was copied from other thoughtbot projects. Of course, Rubocop comes with its own set of default settings. Therefore, we don't need to re-specify settings that it already has -- we only need to specify the ones that we're overriding. Besides this, Rubocop isn't even in the Gemfile, so even though Hound runs on GitHub automatically, it'd be nice to spot style issues as you are editing files. Given this, this commit simplifies the Rubocop configuration and also adds Rubocop to the Gemfile so that you can configure your editor to lint files as you are editing them.
2018-09-12 23:33:48 -04:00
Metrics/BlockLength:
Enabled: false
Metrics/ClassLength:
Enabled: false
fix(rubocop): Fix Layout/LineLength - bump rubocop to v1.0 - Fix Layout/MultilineAssignmentLayout and other remaining offences - Exculde appraisal generated gemfiles in rubocop - Replace NON_NUMERIC_VALUE constant with instance method against failing test case in rails <= 5.1 and postgres adapter. This is a defect in rails where a frozen string is modified in https://github.com/rails/rails/blob/v5.1.7/activerecord/lib/active_record/connection_adapters/postgresql/oid/money.rb#L25
2020-11-03 00:56:49 -05:00
Metrics/CyclomaticComplexity:
Enabled: false
Update Rubocop config [ci skip]
2019-01-29 20:49:38 -05:00
Metrics/MethodLength:
Max: 30
fix(rubocop): Fix Style, Layout, Lint and other offenses [ci skip] Updated Layout/LineLength cop to Max 120 lenght and ignore everything inside specs/**/* Added rules for below cops in .rubocop.yml Lint/AmbiguousBlockAssociation Naming/HeredocDelimiterNaming Rails/SkipsModelValidations Style/FormatStringToken Fixed below mentioned cops: - Layout/CaseIndentation - Layout/DotPosition - Layout/ElseAlignment - Layout/IndentationWidth - Layout/LineLength - Layout/MultilineBlockLayout - Layout/MultilineOperationIndentation - Lint/AmbiguousBlockAssociation - Lint/MissingCopEnableDirective - Lint/NestedMethodDefinition - Lint/RedundantCopDisableDirective - Lint/RedundantRequireStatement - Lint/UnusedBlockArgument - Lint/UnusedMethodArgument - Metrics/ModuleLength - Naming/MemoizedInstanceVariableName - Naming/RescuedExceptionsVariableName - Rails/Output - Rails/Presence - Security/Eval - Security/Open - Style/ClassCheck - Style/CollectionMethods - Style/ConditionalAssignment - Style/EvalWithLocation - Style/FormatStringToken - Style/InverseMethods - Style/MutableConstant - Style/ParallelAssignment - Style/RedundantBegin - Style/RedundantCondition - Style/RedundantInterpolation - Style/RedundantSelf - Style/RedundantSort - Style/RescueStandardError - Style/SafeNavigation - Style/StringLiteralsInInterpolation - Style/SymbolProc
2020-09-06 09:09:31 -04:00
Metrics/ModuleLength:
Enabled: true
Exclude:
- spec/**/*
Update Rubocop & Rubocop config
2019-05-30 02:28:00 -04:00
Metrics/ParameterLists:
CountKeywordArgs: false
Metrics/PerceivedComplexity:
fix(rubocop): Fix Layout/LineLength - bump rubocop to v1.0 - Fix Layout/MultilineAssignmentLayout and other remaining offences - Exculde appraisal generated gemfiles in rubocop - Replace NON_NUMERIC_VALUE constant with instance method against failing test case in rails <= 5.1 and postgres adapter. This is a defect in rails where a frozen string is modified in https://github.com/rails/rails/blob/v5.1.7/activerecord/lib/active_record/connection_adapters/postgresql/oid/money.rb#L25
2020-11-03 00:56:49 -05:00
Enabled: false
Simplify Rubocop configuration The original Rubocop configuration was copied from other thoughtbot projects. Of course, Rubocop comes with its own set of default settings. Therefore, we don't need to re-specify settings that it already has -- we only need to specify the ones that we're overriding. Besides this, Rubocop isn't even in the Gemfile, so even though Hound runs on GitHub automatically, it'd be nice to spot style issues as you are editing files. Given this, this commit simplifies the Rubocop configuration and also adds Rubocop to the Gemfile so that you can configure your editor to lint files as you are editing them.
2018-09-12 23:33:48 -04:00
Naming/AccessorMethodName:
Enabled: false
Naming/AsciiIdentifiers:
Enabled: false
Naming/BinaryOperatorParameterName:
Enabled: false
Bump rubocop from 0.89.1 to 0.90 [ci skip] - Sort cops alphabetically in .rubocop.yml
2020-09-04 01:05:02 -04:00
Naming/FileName:
Enabled: false
fix(rubocop): Fix Style, Layout, Lint and other offenses [ci skip] Updated Layout/LineLength cop to Max 120 lenght and ignore everything inside specs/**/* Added rules for below cops in .rubocop.yml Lint/AmbiguousBlockAssociation Naming/HeredocDelimiterNaming Rails/SkipsModelValidations Style/FormatStringToken Fixed below mentioned cops: - Layout/CaseIndentation - Layout/DotPosition - Layout/ElseAlignment - Layout/IndentationWidth - Layout/LineLength - Layout/MultilineBlockLayout - Layout/MultilineOperationIndentation - Lint/AmbiguousBlockAssociation - Lint/MissingCopEnableDirective - Lint/NestedMethodDefinition - Lint/RedundantCopDisableDirective - Lint/RedundantRequireStatement - Lint/UnusedBlockArgument - Lint/UnusedMethodArgument - Metrics/ModuleLength - Naming/MemoizedInstanceVariableName - Naming/RescuedExceptionsVariableName - Rails/Output - Rails/Presence - Security/Eval - Security/Open - Style/ClassCheck - Style/CollectionMethods - Style/ConditionalAssignment - Style/EvalWithLocation - Style/FormatStringToken - Style/InverseMethods - Style/MutableConstant - Style/ParallelAssignment - Style/RedundantBegin - Style/RedundantCondition - Style/RedundantInterpolation - Style/RedundantSelf - Style/RedundantSort - Style/RescueStandardError - Style/SafeNavigation - Style/StringLiteralsInInterpolation - Style/SymbolProc
2020-09-06 09:09:31 -04:00
Naming/HeredocDelimiterNaming:
Enabled: false
Tweak Rubocop config
2019-03-17 18:22:43 -04:00
Naming/MemoizedInstanceVariableName:
EnforcedStyleForLeadingUnderscores: required
Naming/PredicateName:
Enabled: false
fix(rubocop): Fix Layout/LineLength - bump rubocop to v1.0 - Fix Layout/MultilineAssignmentLayout and other remaining offences - Exculde appraisal generated gemfiles in rubocop - Replace NON_NUMERIC_VALUE constant with instance method against failing test case in rails <= 5.1 and postgres adapter. This is a defect in rails where a frozen string is modified in https://github.com/rails/rails/blob/v5.1.7/activerecord/lib/active_record/connection_adapters/postgresql/oid/money.rb#L25
2020-11-03 00:56:49 -05:00
Naming/RescuedExceptionsVariableName:
Enabled: false
Fix warnings and linter violations in inclusion matcher
2019-06-13 02:28:49 -04:00
Rails/Date:
Enabled: false
Simplify Rubocop configuration The original Rubocop configuration was copied from other thoughtbot projects. Of course, Rubocop comes with its own set of default settings. Therefore, we don't need to re-specify settings that it already has -- we only need to specify the ones that we're overriding. Besides this, Rubocop isn't even in the Gemfile, so even though Hound runs on GitHub automatically, it'd be nice to spot style issues as you are editing files. Given this, this commit simplifies the Rubocop configuration and also adds Rubocop to the Gemfile so that you can configure your editor to lint files as you are editing them.
2018-09-12 23:33:48 -04:00
Rails/Delegate:
Enabled: false
Rails/HttpPositionalArguments:
Enabled: false
fix(rubocop): Fix Style, Layout, Lint and other offenses [ci skip] Updated Layout/LineLength cop to Max 120 lenght and ignore everything inside specs/**/* Added rules for below cops in .rubocop.yml Lint/AmbiguousBlockAssociation Naming/HeredocDelimiterNaming Rails/SkipsModelValidations Style/FormatStringToken Fixed below mentioned cops: - Layout/CaseIndentation - Layout/DotPosition - Layout/ElseAlignment - Layout/IndentationWidth - Layout/LineLength - Layout/MultilineBlockLayout - Layout/MultilineOperationIndentation - Lint/AmbiguousBlockAssociation - Lint/MissingCopEnableDirective - Lint/NestedMethodDefinition - Lint/RedundantCopDisableDirective - Lint/RedundantRequireStatement - Lint/UnusedBlockArgument - Lint/UnusedMethodArgument - Metrics/ModuleLength - Naming/MemoizedInstanceVariableName - Naming/RescuedExceptionsVariableName - Rails/Output - Rails/Presence - Security/Eval - Security/Open - Style/ClassCheck - Style/CollectionMethods - Style/ConditionalAssignment - Style/EvalWithLocation - Style/FormatStringToken - Style/InverseMethods - Style/MutableConstant - Style/ParallelAssignment - Style/RedundantBegin - Style/RedundantCondition - Style/RedundantInterpolation - Style/RedundantSelf - Style/RedundantSort - Style/RescueStandardError - Style/SafeNavigation - Style/StringLiteralsInInterpolation - Style/SymbolProc
2020-09-06 09:09:31 -04:00
Rails/SkipsModelValidations:
Exclude:
- spec/**/*
Bump rubocop from 0.89.1 to 0.90 [ci skip] - Sort cops alphabetically in .rubocop.yml
2020-09-04 01:05:02 -04:00
Rails/TimeZone:
Enabled: false
Simplify Rubocop configuration The original Rubocop configuration was copied from other thoughtbot projects. Of course, Rubocop comes with its own set of default settings. Therefore, we don't need to re-specify settings that it already has -- we only need to specify the ones that we're overriding. Besides this, Rubocop isn't even in the Gemfile, so even though Hound runs on GitHub automatically, it'd be nice to spot style issues as you are editing files. Given this, this commit simplifies the Rubocop configuration and also adds Rubocop to the Gemfile so that you can configure your editor to lint files as you are editing them.
2018-09-12 23:33:48 -04:00
Style/Alias:
Enabled: false
Style/ArrayJoin:
Enabled: false
Style/AsciiComments:
Enabled: false
Style/Attr:
Enabled: false
Bump rubocop from 0.89.1 to 0.90 [ci skip] - Sort cops alphabetically in .rubocop.yml
2020-09-04 01:05:02 -04:00
Style/BlockDelimiters:
Enabled: false
Simplify Rubocop configuration The original Rubocop configuration was copied from other thoughtbot projects. Of course, Rubocop comes with its own set of default settings. Therefore, we don't need to re-specify settings that it already has -- we only need to specify the ones that we're overriding. Besides this, Rubocop isn't even in the Gemfile, so even though Hound runs on GitHub automatically, it'd be nice to spot style issues as you are editing files. Given this, this commit simplifies the Rubocop configuration and also adds Rubocop to the Gemfile so that you can configure your editor to lint files as you are editing them.
2018-09-12 23:33:48 -04:00
Style/CaseEquality:
Enabled: false
Style/CharacterLiteral:
Enabled: false
Style/ClassAndModuleChildren:
Enabled: false
Bump rubocop from 0.89.1 to 0.90 [ci skip] - Sort cops alphabetically in .rubocop.yml
2020-09-04 01:05:02 -04:00
Style/ClassVars:
Enabled: false
Update .rubocop.yml Import all of the Rubocop rules from Hound so that the comments that Hound produces are the same ones that would be produced in Vim. [ci skip]
2017-02-06 16:06:49 -05:00
Style/CollectionMethods:
Teach have_db_index about expression indexes In Rails 5, the schema layer was updated so that indexes could be created on expressions rather that simply columns. Update `have_db_index` so that you can test for this. More reading: <https://github.com/rails/rails/commit/edc2b7718725016e988089b5fb6d6fb9d6e16882>
2019-05-30 02:24:24 -04:00
Enabled: true
Rewrite tests for validate_uniqueness_of * The main problem I had with the old tests is that information that the reader didn't need to care about was not properly abstracted away. For instance, a helper method used by almost all tests will always create a model called Example, and will always use an attribute called "attr" (on which the validation is present). However, in some tests the class or attribute is referred to directly. The reader shouldn't have to care about either of these things, since they are constant -- the tests should be readable enough so that this information is not necessary to understand the case being tested against. * Speaking of this helper method, some of the tests used it and some didn't. Some defined their own helper methods to represent a particular case (`case_sensitive: true`, `allow_nil`, etc.). This is now fixed so that all but two tests use the same helper method to define a model. This model is completely customizable -- one can specify the type of the attribute being validated, the names and types of scoped attributes, etc. * The tests around scoped attributes and different types are all basically the same, so they are now compressed into a shared context. * Related to this, we no longer have to worry about setting a proper value for a scope attribute. One had to know which type that attribute had and come up with a reasonable default for that type. Now there is a helper method that worries about this automatically. * Finally, we remove tests around case_insensitive against an integer attribute (these don't make any sense, and don't work).
2015-02-08 14:10:23 -05:00
PreferredMethods:
collect: map
Bump rubocop from 0.89.1 to 0.90 [ci skip] - Sort cops alphabetically in .rubocop.yml
2020-09-04 01:05:02 -04:00
find: detect
Rewrite tests for validate_uniqueness_of * The main problem I had with the old tests is that information that the reader didn't need to care about was not properly abstracted away. For instance, a helper method used by almost all tests will always create a model called Example, and will always use an attribute called "attr" (on which the validation is present). However, in some tests the class or attribute is referred to directly. The reader shouldn't have to care about either of these things, since they are constant -- the tests should be readable enough so that this information is not necessary to understand the case being tested against. * Speaking of this helper method, some of the tests used it and some didn't. Some defined their own helper methods to represent a particular case (`case_sensitive: true`, `allow_nil`, etc.). This is now fixed so that all but two tests use the same helper method to define a model. This model is completely customizable -- one can specify the type of the attribute being validated, the names and types of scoped attributes, etc. * The tests around scoped attributes and different types are all basically the same, so they are now compressed into a shared context. * Related to this, we no longer have to worry about setting a proper value for a scope attribute. One had to know which type that attribute had and come up with a reasonable default for that type. Now there is a helper method that worries about this automatically. * Finally, we remove tests around case_insensitive against an integer attribute (these don't make any sense, and don't work).
2015-02-08 14:10:23 -05:00
find_all: select
Bump rubocop from 0.89.1 to 0.90 [ci skip] - Sort cops alphabetically in .rubocop.yml
2020-09-04 01:05:02 -04:00
reduce: inject
Style/ColonMethodCall:
Enabled: false
Simplify Rubocop configuration The original Rubocop configuration was copied from other thoughtbot projects. Of course, Rubocop comes with its own set of default settings. Therefore, we don't need to re-specify settings that it already has -- we only need to specify the ones that we're overriding. Besides this, Rubocop isn't even in the Gemfile, so even though Hound runs on GitHub automatically, it'd be nice to spot style issues as you are editing files. Given this, this commit simplifies the Rubocop configuration and also adds Rubocop to the Gemfile so that you can configure your editor to lint files as you are editing them.
2018-09-12 23:33:48 -04:00
Style/CommentAnnotation:
Enabled: false
Style/Documentation:
Enabled: false
Style/DoubleNegation:
Enabled: false
Style/EachWithObject:
Enabled: false
Turn off more Rubocop checks
2019-07-06 22:25:27 -04:00
Style/EmptyElse:
Enabled: false
Simplify Rubocop configuration The original Rubocop configuration was copied from other thoughtbot projects. Of course, Rubocop comes with its own set of default settings. Therefore, we don't need to re-specify settings that it already has -- we only need to specify the ones that we're overriding. Besides this, Rubocop isn't even in the Gemfile, so even though Hound runs on GitHub automatically, it'd be nice to spot style issues as you are editing files. Given this, this commit simplifies the Rubocop configuration and also adds Rubocop to the Gemfile so that you can configure your editor to lint files as you are editing them.
2018-09-12 23:33:48 -04:00
Style/EmptyLiteral:
Enabled: false
fix(rubocop): Fix Layout/LineLength - bump rubocop to v1.0 - Fix Layout/MultilineAssignmentLayout and other remaining offences - Exculde appraisal generated gemfiles in rubocop - Replace NON_NUMERIC_VALUE constant with instance method against failing test case in rails <= 5.1 and postgres adapter. This is a defect in rails where a frozen string is modified in https://github.com/rails/rails/blob/v5.1.7/activerecord/lib/active_record/connection_adapters/postgresql/oid/money.rb#L25
2020-11-03 00:56:49 -05:00
Style/EmptyMethod:
EnforcedStyle: expanded
Simplify Rubocop configuration The original Rubocop configuration was copied from other thoughtbot projects. Of course, Rubocop comes with its own set of default settings. Therefore, we don't need to re-specify settings that it already has -- we only need to specify the ones that we're overriding. Besides this, Rubocop isn't even in the Gemfile, so even though Hound runs on GitHub automatically, it'd be nice to spot style issues as you are editing files. Given this, this commit simplifies the Rubocop configuration and also adds Rubocop to the Gemfile so that you can configure your editor to lint files as you are editing them.
2018-09-12 23:33:48 -04:00
Style/Encoding:
Enabled: false
Style/EvenOdd:
Enabled: false
Style/FormatString:
Enabled: false
fix(rubocop): Fix Style, Layout, Lint and other offenses [ci skip] Updated Layout/LineLength cop to Max 120 lenght and ignore everything inside specs/**/* Added rules for below cops in .rubocop.yml Lint/AmbiguousBlockAssociation Naming/HeredocDelimiterNaming Rails/SkipsModelValidations Style/FormatStringToken Fixed below mentioned cops: - Layout/CaseIndentation - Layout/DotPosition - Layout/ElseAlignment - Layout/IndentationWidth - Layout/LineLength - Layout/MultilineBlockLayout - Layout/MultilineOperationIndentation - Lint/AmbiguousBlockAssociation - Lint/MissingCopEnableDirective - Lint/NestedMethodDefinition - Lint/RedundantCopDisableDirective - Lint/RedundantRequireStatement - Lint/UnusedBlockArgument - Lint/UnusedMethodArgument - Metrics/ModuleLength - Naming/MemoizedInstanceVariableName - Naming/RescuedExceptionsVariableName - Rails/Output - Rails/Presence - Security/Eval - Security/Open - Style/ClassCheck - Style/CollectionMethods - Style/ConditionalAssignment - Style/EvalWithLocation - Style/FormatStringToken - Style/InverseMethods - Style/MutableConstant - Style/ParallelAssignment - Style/RedundantBegin - Style/RedundantCondition - Style/RedundantInterpolation - Style/RedundantSelf - Style/RedundantSort - Style/RescueStandardError - Style/SafeNavigation - Style/StringLiteralsInInterpolation - Style/SymbolProc
2020-09-06 09:09:31 -04:00
Style/FormatStringToken:
EnforcedStyle: template
Update .rubocop.yml Import all of the Rubocop rules from Hound so that the comments that Hound produces are the same ones that would be produced in Vim. [ci skip]
2017-02-06 16:06:49 -05:00
Style/FrozenStringLiteralComment:
Enabled: false
Simplify Rubocop configuration The original Rubocop configuration was copied from other thoughtbot projects. Of course, Rubocop comes with its own set of default settings. Therefore, we don't need to re-specify settings that it already has -- we only need to specify the ones that we're overriding. Besides this, Rubocop isn't even in the Gemfile, so even though Hound runs on GitHub automatically, it'd be nice to spot style issues as you are editing files. Given this, this commit simplifies the Rubocop configuration and also adds Rubocop to the Gemfile so that you can configure your editor to lint files as you are editing them.
2018-09-12 23:33:48 -04:00
Style/GlobalVars:
Enabled: false
Style/GuardClause:
Enabled: false
Style/IfUnlessModifier:
Enabled: false
Style/IfWithSemicolon:
Enabled: false
Style/InlineComment:
Enabled: false
fix(rubocop): Fix Layout/LineLength - bump rubocop to v1.0 - Fix Layout/MultilineAssignmentLayout and other remaining offences - Exculde appraisal generated gemfiles in rubocop - Replace NON_NUMERIC_VALUE constant with instance method against failing test case in rails <= 5.1 and postgres adapter. This is a defect in rails where a frozen string is modified in https://github.com/rails/rails/blob/v5.1.7/activerecord/lib/active_record/connection_adapters/postgresql/oid/money.rb#L25
2020-11-03 00:56:49 -05:00
Style/InverseMethods:
Enabled: false
Simplify Rubocop configuration The original Rubocop configuration was copied from other thoughtbot projects. Of course, Rubocop comes with its own set of default settings. Therefore, we don't need to re-specify settings that it already has -- we only need to specify the ones that we're overriding. Besides this, Rubocop isn't even in the Gemfile, so even though Hound runs on GitHub automatically, it'd be nice to spot style issues as you are editing files. Given this, this commit simplifies the Rubocop configuration and also adds Rubocop to the Gemfile so that you can configure your editor to lint files as you are editing them.
2018-09-12 23:33:48 -04:00
Style/Lambda:
Enabled: false
Style/LambdaCall:
Enabled: false
Style/LineEndConcatenation:
Enabled: false
Style/MethodCalledOnDoEndBlock:
Enabled: false
Style/ModuleFunction:
Enabled: false
Style/NegatedIf:
Enabled: false
Style/NegatedWhile:
Enabled: false
Style/Next:
Enabled: false
Style/NilComparison:
Enabled: false
Style/Not:
Enabled: false
Style/NumericLiterals:
Enabled: false
Style/NumericPredicate:
Enabled: false
Style/OneLineConditional:
Enabled: false
fix(rubocop): Fix Layout/LineLength - bump rubocop to v1.0 - Fix Layout/MultilineAssignmentLayout and other remaining offences - Exculde appraisal generated gemfiles in rubocop - Replace NON_NUMERIC_VALUE constant with instance method against failing test case in rails <= 5.1 and postgres adapter. This is a defect in rails where a frozen string is modified in https://github.com/rails/rails/blob/v5.1.7/activerecord/lib/active_record/connection_adapters/postgresql/oid/money.rb#L25
2020-11-03 00:56:49 -05:00
Style/OptionalBooleanParameter:
Enabled: false
Fix warnings and linter violations in inclusion matcher
2019-06-13 02:28:49 -04:00
Style/ParenthesesAroundCondition:
Enabled: false
Simplify Rubocop configuration The original Rubocop configuration was copied from other thoughtbot projects. Of course, Rubocop comes with its own set of default settings. Therefore, we don't need to re-specify settings that it already has -- we only need to specify the ones that we're overriding. Besides this, Rubocop isn't even in the Gemfile, so even though Hound runs on GitHub automatically, it'd be nice to spot style issues as you are editing files. Given this, this commit simplifies the Rubocop configuration and also adds Rubocop to the Gemfile so that you can configure your editor to lint files as you are editing them.
2018-09-12 23:33:48 -04:00
Style/PercentLiteralDelimiters:
Enabled: false
Style/PerlBackrefs:
Enabled: false
Style/PreferredHashMethods:
Enabled: false
Style/Proc:
Enabled: false
Style/RaiseArgs:
Enabled: false
Style/RegexpLiteral:
Enabled: false
Style/SelfAssignment:
Enabled: false
Style/SignalException:
Enabled: false
Style/SingleLineBlockParams:
Enabled: false
Style/SingleLineMethods:
Enabled: false
Style/SpecialGlobalVars:
Enabled: false
Update .rubocop.yml Import all of the Rubocop rules from Hound so that the comments that Hound produces are the same ones that would be produced in Vim. [ci skip]
2017-02-06 16:06:49 -05:00
Style/StringLiterals:
EnforcedStyle: single_quotes
Simplify Rubocop configuration The original Rubocop configuration was copied from other thoughtbot projects. Of course, Rubocop comes with its own set of default settings. Therefore, we don't need to re-specify settings that it already has -- we only need to specify the ones that we're overriding. Besides this, Rubocop isn't even in the Gemfile, so even though Hound runs on GitHub automatically, it'd be nice to spot style issues as you are editing files. Given this, this commit simplifies the Rubocop configuration and also adds Rubocop to the Gemfile so that you can configure your editor to lint files as you are editing them.
2018-09-12 23:33:48 -04:00
Style/SymbolArray:
Enabled: false
Style/TrailingCommaInArguments:
EnforcedStyleForMultiline: consistent_comma
Style/TrailingCommaInArrayLiteral:
EnforcedStyleForMultiline: consistent_comma
Style/TrailingCommaInHashLiteral:
EnforcedStyleForMultiline: consistent_comma
Style/TrivialAccessors:
Enabled: false
Bump rubocop from 0.89.1 to 0.90 [ci skip] - Sort cops alphabetically in .rubocop.yml
2020-09-04 01:05:02 -04:00
Style/VariableInterpolation:
Enabled: false
Simplify Rubocop configuration The original Rubocop configuration was copied from other thoughtbot projects. Of course, Rubocop comes with its own set of default settings. Therefore, we don't need to re-specify settings that it already has -- we only need to specify the ones that we're overriding. Besides this, Rubocop isn't even in the Gemfile, so even though Hound runs on GitHub automatically, it'd be nice to spot style issues as you are editing files. Given this, this commit simplifies the Rubocop configuration and also adds Rubocop to the Gemfile so that you can configure your editor to lint files as you are editing them.
2018-09-12 23:33:48 -04:00
Style/WhenThen:
Enabled: false
Style/WhileUntilModifier:
Enabled: false
Style/WordArray:
Enabled: false
Copy permalink