b7e02184d9
fix(rubocop): Fix Layout/LineLength
...
- bump rubocop to v1.0
- Fix Layout/MultilineAssignmentLayout and other remaining offences
- Exculde appraisal generated gemfiles in rubocop
- Replace NON_NUMERIC_VALUE constant with instance method against
failing test case in rails <= 5.1 and postgres adapter.
This is a defect in rails where a frozen string is modified in
https://github.com/rails/rails/blob/v5.1.7/activerecord/lib/active_record/connection_adapters/postgresql/oid/money.rb#L25
2020-11-03 10:05:25 -07:00
3e88500318
fix(rubocop): Fix Style, Layout, Lint and other offenses [ci skip]
...
Updated Layout/LineLength cop to Max 120 lenght and ignore everything
inside specs/**/*
Added rules for below cops in .rubocop.yml
Lint/AmbiguousBlockAssociation
Naming/HeredocDelimiterNaming
Rails/SkipsModelValidations
Style/FormatStringToken
Fixed below mentioned cops:
- Layout/CaseIndentation
- Layout/DotPosition
- Layout/ElseAlignment
- Layout/IndentationWidth
- Layout/LineLength
- Layout/MultilineBlockLayout
- Layout/MultilineOperationIndentation
- Lint/AmbiguousBlockAssociation
- Lint/MissingCopEnableDirective
- Lint/NestedMethodDefinition
- Lint/RedundantCopDisableDirective
- Lint/RedundantRequireStatement
- Lint/UnusedBlockArgument
- Lint/UnusedMethodArgument
- Metrics/ModuleLength
- Naming/MemoizedInstanceVariableName
- Naming/RescuedExceptionsVariableName
- Rails/Output
- Rails/Presence
- Security/Eval
- Security/Open
- Style/ClassCheck
- Style/CollectionMethods
- Style/ConditionalAssignment
- Style/EvalWithLocation
- Style/FormatStringToken
- Style/InverseMethods
- Style/MutableConstant
- Style/ParallelAssignment
- Style/RedundantBegin
- Style/RedundantCondition
- Style/RedundantInterpolation
- Style/RedundantSelf
- Style/RedundantSort
- Style/RescueStandardError
- Style/SafeNavigation
- Style/StringLiteralsInInterpolation
- Style/SymbolProc
2020-11-03 10:05:25 -07:00
afa6a7b666
Update RSpec test style across docs
...
Instead of using
describe Foo do
# ...
end
use
RSpec.describe Foo, type: :model do
# ...
end
instead. This is not exactly official, as the former style still works,
but the latter style is highly suggested in RSpec documentation and the
like, so this is what people are used to.
[ci skip]
2016-06-15 18:02:07 -06:00
142366ef16
Refer to Minitest in docs over Test::Unit
...
Minitest has been used instead of Test::Unit for quite some time now,
let's get with the times.
[ci skip]
2015-09-30 13:18:23 -06:00
32c0e62596
Drop support for RSpec 2
2015-09-22 13:12:46 -06:00
1cd4a4cd12
FilterParamMatcher supports Regexps
2014-08-13 22:21:53 -04:00
c22d7c89e0
Extract examples in README to inline documentation
2014-06-20 16:41:27 -06:00
1878e89a13
Update deprecated matcher protocol for RSpec 3.
...
The methods failure_message_for_should and failure_message_for_should_not
have been updated to failure_message and failure_message_negated respectively.
Alias to the old methods to remain backwards compatibility with RSpec 2.
2013-12-24 22:34:26 +11:00
4f8684c6db
Rename failure_message and negative_failure_message
...
* fixes #108 : RSpec 2.10 compatibility
* remove unnecessary attr_readr
2013-03-08 14:49:12 -05:00
8d01c6f9e8
Remove unused ivar
2012-12-27 19:42:50 -05:00
7b3d6d0f86
Continue cleaning up matchers.
2012-03-30 11:50:59 -04:00
56b0a0439e
Move into the Matchers namespace
2010-12-15 17:34:19 -05:00
Kapil Sachdev