* Update ruby to the latest version
* Bump Rubocop to 1.36.0
* Fix "Style/RedundantBegin: Redundant begin block detected" rubocop offense
* Disable Naming/VariableNumber offense
* Fix "Style/RedundantParentheses: Don't use parentheses around a literal" rubocop offense
* Fix "Lint/RedundantCopDisableDirective: Unnecessary disabling of Style/FormatStringToken." rubocop offense
* Fix "Layout/ArgumentAlignment: Use one level of indentation for arguments following the first line of a multi-line method call" rubocop offense
* Bump Ruby to 3.1.2
* Bump rubocop-rails to 2.16.1
* Bump rubocop-packaging to 0.5.2
Fix warning: The Metrics/LineLength has the wrong namespace - should be Layout
Fix warning: The `Layout/AlignArguments` cop has been renamed to `Layout/ArgumentAlignment`.
Fix warning: The `Layout/AlignParameters` cop has been renamed to `Layout/ParameterAlignment`.
Fix warning: The `Layout/IndentHeredoc` cop has been renamed to `Layout/HeredocIndentation`.
Fix warning: The `Lint/HandleExceptions` cop has been renamed to `Lint/SuppressedException`.
Set new cops as disable for default
After installing Rubocop 0.71, I received this warning:
Rails cops will be removed from RuboCop 0.72. Use the `rubocop-rails` gem instead.
This commit follows these instructions.
[ci skip]
In Rails 5, the schema layer was updated so that indexes could be
created on expressions rather that simply columns. Update
`have_db_index` so that you can test for this.
More reading: <edc2b77187>
The original Rubocop configuration was copied from other thoughtbot
projects. Of course, Rubocop comes with its own set of default settings.
Therefore, we don't need to re-specify settings that it already has --
we only need to specify the ones that we're overriding.
Besides this, Rubocop isn't even in the Gemfile, so even though Hound
runs on GitHub automatically, it'd be nice to spot style issues as you
are editing files.
Given this, this commit simplifies the Rubocop configuration and also
adds Rubocop to the Gemfile so that you can configure your editor to
lint files as you are editing them.