Commit Graph

12 Commits

Author SHA1 Message Date
Elliot Winkler 34020fbf91 Turn off more Rubocop checks 2019-07-08 19:24:35 -06:00
Elliot Winkler f52e785258 Fix warnings and linter violations in inclusion matcher 2019-06-13 00:39:00 -06:00
Elliot Winkler 5829f883fb Tweak Rubocop configuration 2019-06-09 01:56:32 -06:00
Elliot Winkler 002f15b6c7 Bring in Rails cops using rubocop-rails
After installing Rubocop 0.71, I received this warning:

    Rails cops will be removed from RuboCop 0.72. Use the `rubocop-rails` gem instead.

This commit follows these instructions.

[ci skip]
2019-06-07 21:57:40 -06:00
Elliot Winkler 4e2448d775 Teach have_db_index about expression indexes
In Rails 5, the schema layer was updated so that indexes could be
created on expressions rather that simply columns. Update
`have_db_index` so that you can test for this.

More reading: <edc2b77187>
2019-05-31 00:12:10 -06:00
Elliot Winkler a5aea2ee24 Update Rubocop & Rubocop config 2019-05-30 21:15:52 -06:00
Elliot Winkler 9982926beb Tweak Rubocop config 2019-03-20 22:59:12 -07:00
Elliot Winkler da4e6ddd06 Add failing tests for issue 1146 2019-01-29 23:33:06 -07:00
Elliot Winkler 13b2338312 Update Rubocop config
[ci skip]
2019-01-29 18:49:39 -07:00
Elliot Winkler e2154f9e4e Simplify Rubocop configuration
The original Rubocop configuration was copied from other thoughtbot
projects. Of course, Rubocop comes with its own set of default settings.
Therefore, we don't need to re-specify settings that it already has --
we only need to specify the ones that we're overriding.

Besides this, Rubocop isn't even in the Gemfile, so even though Hound
runs on GitHub automatically, it'd be nice to spot style issues as you
are editing files.

Given this, this commit simplifies the Rubocop configuration and also
adds Rubocop to the Gemfile so that you can configure your editor to
lint files as you are editing them.
2018-10-04 21:30:01 -03:00
Elliot Winkler ba5b663235 Update Rubocop settings 2018-01-24 00:52:01 -06:00
Elliot Winkler e8f1492d5a Update .rubocop.yml
Import all of the Rubocop rules from Hound so that the comments that
Hound produces are the same ones that would be produced in Vim.

[ci skip]
2017-02-06 22:08:20 +01:00