1
0
Fork 0
mirror of https://github.com/thoughtbot/shoulda-matchers.git synced 2022-11-09 12:01:38 -05:00
Simple one-liner tests for common Rails functionality
Find a file
Elliot Winkler ad9b112cca Fix inclusion to correctly disallow outside values
The inclusion matcher, when qualified with `in_array`, was using
AllowValueMatcher to check that values outside the array were disallowed
by the model (and then inverting its result). However, it should have
been using DisallowValueMatcher all this time. This commit fixes that.

Without this fix, the following error is raised when using the inclusion
matcher against a model which does not have the proper inclusion
validation on it:

    undefined method `attribute_setter' for nil:NilClass

This happens because the inclusion matcher is a complex matcher, i.e.,
it runs a series of submatchers internally and the result of those
submatchers contributes to whether or not the matcher matches. If one of
those submatchers fails, the inclusion matcher immediately fails and
spits out the failure message associated with that submatcher.

However, there is a fundamental difference between AllowValueMatcher and
DisallowValueMatcher as it relates to how they function:

* AllowValueMatcher sets an attribute to a value on a record and expects
  the record not to fail validation.
* DisallowValueMatcher sets an attribute to a value on a record, but
  expects the record *to* fail validation.

The issue in this case is that, because AllowValueMatcher was used
instead of DisallowValueMatcher, the inclusion matcher thought that the
AllowValueMatcher failed, when in fact it passed (this result was just
inverted). So it tried to generate a failure message for a matcher that
didn't fail in the first place. By using DisallowValueMatcher, we set
the proper expectations.
2018-09-12 22:34:22 -06:00
.hound Fix .hound/ruby.yml syntax 2018-09-04 09:34:26 -03:00
doc_config
docs/errors
gemfiles Create Appraisal and TravisCI config for Rails 5.2 2018-09-05 10:41:20 -03:00
lib Fix inclusion to correctly disallow outside values 2018-09-12 22:34:22 -06:00
script Update util scripts to use Ruby versions in .travis.yml 2018-01-24 00:30:10 -06:00
spec Fix inclusion to correctly disallow outside values 2018-09-12 22:34:22 -06:00
tasks
.gitignore
.hound.yml
.rubocop.yml Update Rubocop settings 2018-01-24 00:52:01 -06:00
.travis.yml Create Appraisal and TravisCI config for Rails 5.2 2018-09-05 10:41:20 -03:00
.yardopts
Appraisals Create Appraisal and TravisCI config for Rails 5.2 2018-09-05 10:41:20 -03:00
CONTRIBUTING.md Update CONTRIBUTING 2018-01-24 00:30:10 -06:00
custom_plan.rb
Gemfile Upgrade Rake 2018-01-25 21:37:06 -06:00
Gemfile.lock Upgrade Rake 2018-01-25 21:37:06 -06:00
MIT-LICENSE Update MIT-License 2018-09-01 23:58:39 -03:00
NEWS.md Fix inclusion to correctly disallow outside values 2018-09-12 22:34:22 -06:00
Rakefile Update CONTRIBUTING 2018-01-24 00:30:10 -06:00
README.md Add a Reviewed by Hound badge 2018-08-07 18:21:03 -07:00
shoulda-matchers.gemspec Updated homepage in gemspec 2018-09-03 16:15:42 -03:00
zeus.json Fix Zeus so that it runs again on Ruby >= 2.5.x 2018-09-12 21:53:53 -06:00

Shoulda Matchers Gem Version Build Status Downloads Hound

Shoulda Matchers provides RSpec- and Minitest-compatible one-liners that test common Rails functionality. These tests would otherwise be much longer, more complex, and error-prone.

View the official documentation for the latest version (3.1.1).

This is the master branch

We are currently working on shoulda-matchers 4.0, which will support Ruby 2.4 and Rails 5.x. We don't have a date on when this will be released, but you can stay up to date on the progress by monitoring the milestone. Use this branch at your discretion!


ActiveModel matchers

ActiveRecord matchers

ActionController matchers

  • filter_param tests parameter filtering configuration.
  • permit tests that an action places a restriction on the params hash.
  • redirect_to tests that an action redirects to a certain location.
  • render_template tests that an action renders a template.
  • render_with_layout tests that an action is rendered with a certain layout.
  • rescue_from tests usage of the rescue_from macro.
  • respond_with tests that an action responds with a certain status code.
  • route tests your routes.
  • set_session makes assertions on the session hash.
  • set_flash makes assertions on the flash hash.
  • use_after_action tests that an after_action callback is defined in your controller.
  • use_around_action tests that an around_action callback is defined in your controller.
  • use_before_action tests that a before_action callback is defined in your controller.

Independent matchers

  • delegate_method tests that an object forwards messages to other, internal objects by way of delegation.

Getting started

RSpec

Start by including shoulda-matchers in your Gemfile:

group :test do
  gem 'shoulda-matchers', '~> 3.1'
end

We typically use rspec-rails alongside shoulda-matchers, but if for some reason you do not want to do this, and your app is on Rails 5+, you'll want to add the rails-controller-testing gem as well:

group :test do
  gem 'rails-controller-testing'
end

Now you need to tell the gem a couple of things:

  • Which test framework you're using
  • Which portion of the matchers you want to use

You can supply this information by using a configuration block. Place the following in rails_helper.rb:

Shoulda::Matchers.configure do |config|
  config.integrate do |with|
    # Choose a test framework:
    with.test_framework :rspec
    with.test_framework :minitest
    with.test_framework :minitest_4
    with.test_framework :test_unit

    # Choose one or more libraries:
    with.library :active_record
    with.library :active_model
    with.library :action_controller
    # Or, choose the following (which implies all of the above):
    with.library :rails
  end
end

Now you can use matchers in your tests. For instance, a model test might look like this:

RSpec.describe Person, type: :model do
  it { should validate_presence_of(:name) }
end

Availability of matchers in various example groups

Since shoulda-matchers provides four categories of matchers, there are four different levels where you can use these matchers:

  • ActiveRecord and ActiveModel matchers are available only in model example groups, i.e., those tagged with type: :model or in files located under spec/models.
  • ActionController matchers are available only in controller example groups, i.e., those tagged with type: :controller or in files located under spec/controllers.
  • The route matcher is available also in routing example groups, i.e., those tagged with type: :routing or in files located under spec/routing.
  • Independent matchers are available in all example groups.

If you are using ActiveModel or ActiveRecord outside of Rails and you want to use model matchers in certain example groups, you'll need to manually include them. Here's a good way of doing that:

RSpec.configure do |config|
  config.include(Shoulda::Matchers::ActiveModel, type: :model)
  config.include(Shoulda::Matchers::ActiveRecord, type: :model)
end

Then you can say:

describe MySpecialModel, type: :model do
  # ...
end

should vs is_expected.to

Note that in this README and throughout the documentation we're using the should form of RSpec's one-liner syntax over is_expected.to. The should form works regardless of how you've configured RSpec -- meaning you can still use it even when using the expect syntax. But if you prefer to use is_expected.to, you can do that too:

RSpec.describe Person, type: :model do
  it { is_expected.to validate_presence_of(:name) }
end

Minitest

Shoulda Matchers was originally a component of Shoulda, a gem that also provides should and context syntax via shoulda-context.

At the moment, shoulda has not been updated to support shoulda-matchers 3.x, so you'll want to add the following to your Gemfile:

group :test do
  gem 'shoulda', '~> 3.5'
  gem 'shoulda-matchers', '~> 2.0'
end

Now you can use matchers in your tests. For instance a model test might look like this:

class PersonTest < ActiveSupport::TestCase
  should validate_presence_of(:name)
end

Running tests

Unit tests

Unit tests are the most common kind of tests in this gem, and the best way to run them is by using Zeus.

You'll want to run zeus start in one shell, then in another shell, instead of using rspec to run tests, you can use zeus rspec. So for instance, you might say:

zeus rspec spec/unit/shoulda/matchers/active_model/validate_inclusion_of_matcher_spec.rb

As a shortcut, you can also drop the initial part of the path and say this instead:

zeus rspec active_model/validate_inclusion_of_matcher_spec.rb

Acceptance tests

The gem uses Appraisal to test against multiple versions of Rails and Ruby. This means that if you're trying to run a single test file, you'll need to specify which appraisal to use. For instance, you can't simply say:

rspec spec/acceptance/active_model_integration_spec.rb

Instead, you need to say

bundle exec appraisal 5.1 rspec spec/acceptance/active_model_integration_spec.rb

All tests

You can run all tests by saying:

bundle exec rake

Generating documentation

YARD is used to generate documentation, which can be viewed online. You can preview changes you make to the documentation locally by running

yard doc

from this directory. Then, open doc/index.html in your browser.

If you want to be able to regenerate the docs as you work without having to run yard doc over and over again, keep this command running in a separate terminal session:

rake docs:autogenerate

Contributing

Shoulda Matchers is open source, and we are grateful for everyone who's contributed so far.

If you'd like to contribute, please take a look at the instructions for installing dependencies and crafting a good pull request.

Compatibility

Shoulda Matchers is tested and supported against Rails 5.x, Rails 4.2+, RSpec 3.x, Minitest 5, Minitest 4, and Ruby 2.2+.

Versioning

Shoulda Matchers follows Semantic Versioning 2.0 as defined at http://semver.org.

License

Shoulda Matchers is copyright © 2006-2017 thoughtbot, inc. It is free software, and may be redistributed under the terms specified in the MIT-LICENSE file.

About thoughtbot

thoughtbot

Shoulda Matchers is maintained and funded by thoughtbot, inc. The names and logos for thoughtbot are trademarks of thoughtbot, inc.

We are passionate about open source software. See our other projects. We are available for hire.