thoughtbot--shoulda-matchers/spec
Matheus Sales 09bc2609d7
Add `in: range` matcher to validate_numericality_of (#1512)
Closes: #1493

In Rails 7 was added a new option to validate numericality. You can use
`in: range` to specify a range to validate an attribute.

```ruby
class User < ApplicationRecord
  validates :age, numericality: { greater_than_or_equal_to: 18, less_than_or_equal_to: 65 }
end

class User < ApplicationRecord
  validates :age, numericality: { in: 18..65 }
end
```

In this commit we are adding the support matcher to this new
functionality, while also making a refactor on the numericality
matchers that use the concept of submatchers.

We've created a new class (`NumericalityMatchers::Submatcher`) that's
been used by `NumericalityMatchers::RangeMatcher` and
`NumericalityMatchers::ComparisonMatcher`, this new class wil handle
shared logic regarding having submatchers that will check if the parent
matcher is valid or not.

Our new class `Numericality::Matchers::RangeMatcher` is using as
submatchers two `NumericalityMatchers::ComparisonMatcher` instances to
avoid creating new logic to handle this new option and also to replicate
what was being used before this option existed in Rails (see example
above)

In this commit we are adding:

* NumericalityMatchers::RangeMatcher file to support the new `in: range`
  option.
* Specs on ValidateNumericalityOfMatcherSpec file for the new supported
  option, only running on rails_versions > 7.
* NumericalityMatchers::Submatchers file to handle having submatchers
  inside a matcher file.
* Refactors to NumericalityMatchers::ComparisonMatcher.
2022-10-29 08:17:09 -03:00
..
acceptance Fix the undefined method error for non rails project due to use of many? method. (#1459) 2021-08-31 20:04:37 -03:00
support Add `in: range` matcher to validate_numericality_of (#1512) 2022-10-29 08:17:09 -03:00
unit/shoulda/matchers Add `in: range` matcher to validate_numericality_of (#1512) 2022-10-29 08:17:09 -03:00
acceptance_spec_helper.rb fix(rubocop): Fix Layout related offenses [ci skip] 2020-11-03 10:05:25 -07:00
doublespeak_spec_helper.rb Extract a common spec helper 2015-10-07 23:32:51 -06:00
report_warnings.rb Use warnings_logger instead of warnings_spy 2020-08-23 22:58:51 -06:00
spec_helper.rb fix(rubocop): Use __dir__ for Style/ExpandPathArguments [ci skip] 2020-11-03 10:05:25 -07:00
unit_spec_helper.rb fix(rubocop): Fix Layout related offenses [ci skip] 2020-11-03 10:05:25 -07:00