5c3fb37a14
Currently, `rake` does run the `appraise` task before running tests. If you run `rake appraise` on its own, it runs `rake appraise:install` beforehand. However, the way that `rake` runs `appraise` is by executing, not invoking, it. Hence, `appraisal:install` will actually not be run (as #execute does not run dependencies for the task being executed). This fix is mostly useful when running tests locally -- on Travis this isn't a problem b/c we are running `rake spec cucumber` instead of just `rake`.
1.4 KiB
We love pull requests. Here's a quick guide:
-
Fork the repo.
-
Run the tests. We only take pull requests with passing tests, and it's great to know that you have a clean slate:
bundle && bundle exec rake -
Add a test for your change. Only refactoring and documentation changes require no new tests. If you are adding functionality or fixing a bug, we need a test!
-
Make the test pass.
-
Update NEWS.md with a brief description of your changes under the HEAD heading.
-
Push to your fork and submit a pull request.
At this point you're waiting on us. We like to at least comment on, if not accept, pull requests within three business days (and, typically, one business day). We may suggest some changes or improvements or alternatives.
Some things that will increase the chance that your pull request is accepted, taken straight from the Ruby on Rails guide:
- Use Rails idioms and helpers
- Include tests that fail without your code, and pass with it
- Update the documentation, the surrounding one, examples elsewhere, guides, whatever is affected by your contribution
Syntax:
- Two spaces, no tabs.
- No trailing whitespace. Blank lines should not have any space.
- Prefer &&/|| over and/or.
- MyClass.my_method(my_arg) not my_method( my_arg ) or my_method my_arg.
- a = b and not a=b.
- Follow the conventions you see used in the source already.
And in case we didn't emphasize it enough: we love tests!