2019-07-25 05:24:42 +00:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2015-08-26 01:42:46 +00:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-06-16 18:09:01 +00:00
|
|
|
RSpec.describe 'Commits' do
|
2020-02-26 18:09:24 +00:00
|
|
|
let_it_be(:project) { create(:project, :repository) }
|
|
|
|
let_it_be(:user) { create(:user) }
|
2015-10-06 18:36:22 +00:00
|
|
|
|
2015-12-08 10:59:46 +00:00
|
|
|
describe 'CI' do
|
2015-08-26 01:42:46 +00:00
|
|
|
before do
|
2017-06-20 02:06:13 +00:00
|
|
|
sign_in(user)
|
2016-06-03 14:22:26 +00:00
|
|
|
stub_ci_pipeline_to_return_yaml_file
|
2015-08-26 01:42:46 +00:00
|
|
|
end
|
|
|
|
|
2019-04-11 15:21:18 +00:00
|
|
|
let(:creator) { create(:user, developer_projects: [project]) }
|
2016-06-03 14:22:26 +00:00
|
|
|
let!(:pipeline) do
|
2016-10-24 15:23:28 +00:00
|
|
|
create(:ci_pipeline,
|
|
|
|
project: project,
|
2017-03-13 15:39:12 +00:00
|
|
|
user: creator,
|
2016-10-24 15:23:28 +00:00
|
|
|
ref: project.default_branch,
|
|
|
|
sha: project.commit.sha,
|
2017-03-13 15:39:12 +00:00
|
|
|
status: :success,
|
|
|
|
created_at: 5.months.ago)
|
2015-10-05 12:31:51 +00:00
|
|
|
end
|
|
|
|
|
2016-01-26 07:32:36 +00:00
|
|
|
context 'commit status is Generic Commit Status' do
|
2016-10-24 15:23:28 +00:00
|
|
|
let!(:status) { create(:generic_commit_status, pipeline: pipeline) }
|
2015-12-08 10:59:46 +00:00
|
|
|
|
2016-02-04 11:57:46 +00:00
|
|
|
before do
|
2017-12-22 08:18:28 +00:00
|
|
|
project.add_reporter(user)
|
2016-02-04 11:57:46 +00:00
|
|
|
end
|
|
|
|
|
2016-01-26 07:32:36 +00:00
|
|
|
describe 'Commit builds' do
|
|
|
|
before do
|
2017-11-14 10:06:57 +00:00
|
|
|
visit pipeline_path(pipeline)
|
2016-01-26 07:32:36 +00:00
|
|
|
end
|
2015-12-14 10:28:49 +00:00
|
|
|
|
2016-06-03 14:22:26 +00:00
|
|
|
it { expect(page).to have_content pipeline.sha[0..7] }
|
2016-01-26 07:32:36 +00:00
|
|
|
|
|
|
|
it 'contains generic commit status build' do
|
|
|
|
page.within('.table-holder') do
|
|
|
|
expect(page).to have_content "##{status.id}" # build id
|
|
|
|
expect(page).to have_content 'generic' # build name
|
|
|
|
end
|
2015-12-14 10:28:49 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-01-26 07:32:36 +00:00
|
|
|
context 'commit status is Ci Build' do
|
2016-10-24 15:23:28 +00:00
|
|
|
let!(:build) { create(:ci_build, pipeline: pipeline) }
|
2018-06-05 21:18:06 +00:00
|
|
|
let(:artifacts_file) { fixture_file_upload('spec/fixtures/banana_sample.gif', 'image/gif') }
|
2015-08-26 01:42:46 +00:00
|
|
|
|
2016-02-04 11:57:46 +00:00
|
|
|
context 'when logged as developer' do
|
2016-01-26 07:32:36 +00:00
|
|
|
before do
|
2017-12-22 08:18:28 +00:00
|
|
|
project.add_developer(user)
|
2016-01-26 07:32:36 +00:00
|
|
|
end
|
2015-10-12 21:47:32 +00:00
|
|
|
|
2016-02-04 11:57:46 +00:00
|
|
|
describe 'Project commits' do
|
2016-10-24 15:23:28 +00:00
|
|
|
let!(:pipeline_from_other_branch) do
|
|
|
|
create(:ci_pipeline,
|
|
|
|
project: project,
|
|
|
|
ref: 'fix',
|
|
|
|
sha: project.commit.sha,
|
|
|
|
status: :failed)
|
|
|
|
end
|
|
|
|
|
2016-02-04 11:57:46 +00:00
|
|
|
before do
|
2017-06-29 17:06:35 +00:00
|
|
|
visit project_commits_path(project, :master)
|
2016-01-26 07:32:36 +00:00
|
|
|
end
|
2015-10-12 21:47:32 +00:00
|
|
|
|
2016-10-24 15:23:28 +00:00
|
|
|
it 'shows correct build status from default branch' do
|
2016-06-03 14:22:26 +00:00
|
|
|
page.within("//li[@id='commit-#{pipeline.short_sha}']") do
|
2016-10-24 15:23:28 +00:00
|
|
|
expect(page).to have_css('.ci-status-link')
|
|
|
|
expect(page).to have_css('.ci-status-icon-success')
|
2016-02-04 11:57:46 +00:00
|
|
|
end
|
|
|
|
end
|
2016-01-26 07:32:36 +00:00
|
|
|
end
|
2015-10-12 21:47:32 +00:00
|
|
|
|
2017-06-29 04:13:10 +00:00
|
|
|
describe 'Commit builds', :js do
|
2016-02-04 11:57:46 +00:00
|
|
|
before do
|
2019-04-11 15:21:18 +00:00
|
|
|
project.add_developer(user)
|
2017-11-14 10:06:57 +00:00
|
|
|
visit pipeline_path(pipeline)
|
2016-02-04 11:57:46 +00:00
|
|
|
end
|
2015-08-26 01:42:46 +00:00
|
|
|
|
2019-04-11 15:21:18 +00:00
|
|
|
it 'shows pipeline data' do
|
2016-10-19 12:25:37 +00:00
|
|
|
expect(page).to have_content pipeline.sha[0..7]
|
2019-04-26 15:51:05 +00:00
|
|
|
expect(page).to have_content pipeline.git_commit_message.gsub!(/\s+/, ' ')
|
2017-03-13 15:39:12 +00:00
|
|
|
expect(page).to have_content pipeline.user.name
|
2016-10-19 12:25:37 +00:00
|
|
|
end
|
2015-12-08 10:02:13 +00:00
|
|
|
end
|
|
|
|
|
2016-02-04 11:57:46 +00:00
|
|
|
context 'Download artifacts' do
|
|
|
|
before do
|
2019-03-22 12:38:45 +00:00
|
|
|
create(:ci_job_artifact, :archive, file: artifacts_file, job: build)
|
2016-02-04 11:57:46 +00:00
|
|
|
end
|
2015-08-26 01:42:46 +00:00
|
|
|
|
2016-02-04 11:57:46 +00:00
|
|
|
it do
|
2017-11-14 10:06:57 +00:00
|
|
|
visit pipeline_path(pipeline)
|
2016-02-04 11:57:46 +00:00
|
|
|
click_on 'Download artifacts'
|
|
|
|
expect(page.response_headers['Content-Type']).to eq(artifacts_file.content_type)
|
|
|
|
end
|
2015-12-08 10:02:13 +00:00
|
|
|
end
|
2016-01-26 07:32:36 +00:00
|
|
|
|
2016-02-04 11:57:46 +00:00
|
|
|
describe 'Cancel all builds' do
|
2019-10-23 09:06:03 +00:00
|
|
|
it 'cancels commit', :js, :sidekiq_might_not_need_inline do
|
2017-11-14 10:06:57 +00:00
|
|
|
visit pipeline_path(pipeline)
|
2016-02-04 11:57:46 +00:00
|
|
|
click_on 'Cancel running'
|
|
|
|
expect(page).to have_content 'canceled'
|
2016-01-26 07:32:36 +00:00
|
|
|
end
|
2016-02-04 11:57:46 +00:00
|
|
|
end
|
2016-01-26 07:32:36 +00:00
|
|
|
|
2016-02-04 11:57:46 +00:00
|
|
|
describe 'Cancel build' do
|
2019-10-23 09:06:03 +00:00
|
|
|
it 'cancels build', :js, :sidekiq_might_not_need_inline do
|
2017-11-14 10:06:57 +00:00
|
|
|
visit pipeline_path(pipeline)
|
2020-08-10 18:09:54 +00:00
|
|
|
find('[data-testid="cancelPipeline"]').click
|
2016-02-04 11:57:46 +00:00
|
|
|
expect(page).to have_content 'canceled'
|
2016-01-26 07:32:36 +00:00
|
|
|
end
|
|
|
|
end
|
2015-08-26 01:42:46 +00:00
|
|
|
end
|
2016-02-04 11:57:46 +00:00
|
|
|
|
|
|
|
context "when logged as reporter" do
|
|
|
|
before do
|
2017-12-22 08:18:28 +00:00
|
|
|
project.add_reporter(user)
|
2019-03-22 12:38:45 +00:00
|
|
|
create(:ci_job_artifact, :archive, file: artifacts_file, job: build)
|
2017-11-14 10:06:57 +00:00
|
|
|
visit pipeline_path(pipeline)
|
2016-02-04 11:57:46 +00:00
|
|
|
end
|
|
|
|
|
2020-12-09 18:09:48 +00:00
|
|
|
it 'renders header', :js do
|
2016-06-03 14:22:26 +00:00
|
|
|
expect(page).to have_content pipeline.sha[0..7]
|
2019-04-26 15:51:05 +00:00
|
|
|
expect(page).to have_content pipeline.git_commit_message.gsub!(/\s+/, ' ')
|
2017-03-13 15:39:12 +00:00
|
|
|
expect(page).to have_content pipeline.user.name
|
2016-05-23 23:37:59 +00:00
|
|
|
expect(page).not_to have_link('Cancel running')
|
2017-02-20 16:08:29 +00:00
|
|
|
expect(page).not_to have_link('Retry')
|
2016-02-04 11:57:46 +00:00
|
|
|
end
|
2017-06-02 13:24:42 +00:00
|
|
|
|
|
|
|
it do
|
|
|
|
expect(page).to have_link('Download artifacts')
|
|
|
|
end
|
2016-02-04 11:57:46 +00:00
|
|
|
end
|
|
|
|
|
2021-01-26 18:09:30 +00:00
|
|
|
context 'when accessing internal project with disallowed access', :js, quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/299575' do
|
2016-02-04 11:57:46 +00:00
|
|
|
before do
|
2021-03-31 12:08:55 +00:00
|
|
|
project.update!(
|
2016-02-04 11:57:46 +00:00
|
|
|
visibility_level: Gitlab::VisibilityLevel::INTERNAL,
|
|
|
|
public_builds: false)
|
2019-03-22 12:38:45 +00:00
|
|
|
create(:ci_job_artifact, :archive, file: artifacts_file, job: build)
|
2017-11-14 10:06:57 +00:00
|
|
|
visit pipeline_path(pipeline)
|
2016-02-04 11:57:46 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it do
|
2016-06-03 14:22:26 +00:00
|
|
|
expect(page).to have_content pipeline.sha[0..7]
|
2019-04-26 15:51:05 +00:00
|
|
|
expect(page).to have_content pipeline.git_commit_message.gsub!(/\s+/, ' ')
|
2017-03-13 15:39:12 +00:00
|
|
|
expect(page).to have_content pipeline.user.name
|
2017-06-02 13:24:42 +00:00
|
|
|
|
2016-05-23 23:37:59 +00:00
|
|
|
expect(page).not_to have_link('Cancel running')
|
2017-02-20 16:08:29 +00:00
|
|
|
expect(page).not_to have_link('Retry')
|
2016-02-04 11:57:46 +00:00
|
|
|
end
|
|
|
|
end
|
2015-08-26 01:42:46 +00:00
|
|
|
end
|
|
|
|
end
|
2016-11-30 21:28:42 +00:00
|
|
|
|
|
|
|
context 'viewing commits for a branch' do
|
|
|
|
let(:branch_name) { 'master' }
|
|
|
|
|
|
|
|
before do
|
2018-07-11 14:36:08 +00:00
|
|
|
project.add_maintainer(user)
|
2017-06-20 02:06:13 +00:00
|
|
|
sign_in(user)
|
2017-06-29 17:06:35 +00:00
|
|
|
visit project_commits_path(project, branch_name)
|
2016-11-30 21:28:42 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'includes the committed_date for each commit' do
|
2018-01-29 15:27:46 +00:00
|
|
|
commits = project.repository.commits(branch_name, limit: 40)
|
2016-11-30 21:28:42 +00:00
|
|
|
|
|
|
|
commits.each do |commit|
|
2017-12-13 16:09:51 +00:00
|
|
|
expect(page).to have_content("authored #{commit.authored_date.strftime("%b %d, %Y")}")
|
2016-11-30 21:28:42 +00:00
|
|
|
end
|
|
|
|
end
|
2017-11-20 19:48:33 +00:00
|
|
|
|
|
|
|
it 'shows the ref switcher with the multi-file editor enabled', :js do
|
|
|
|
set_cookie('new_repo', 'true')
|
|
|
|
visit project_commits_path(project, branch_name)
|
|
|
|
|
|
|
|
expect(find('.js-project-refs-dropdown')).to have_content branch_name
|
|
|
|
end
|
2016-11-30 21:28:42 +00:00
|
|
|
end
|
2020-02-26 18:09:24 +00:00
|
|
|
|
|
|
|
context 'viewing commits for an author' do
|
|
|
|
let(:author_commit) { project.repository.commits(nil, limit: 1).first }
|
|
|
|
let(:commits) { project.repository.commits(nil, author: author, limit: 40) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
project.add_maintainer(user)
|
|
|
|
sign_in(user)
|
|
|
|
visit project_commits_path(project, nil, author: author)
|
|
|
|
end
|
|
|
|
|
|
|
|
shared_examples 'show commits by author' do
|
|
|
|
it "includes the author's commits" do
|
|
|
|
commits.each do |commit|
|
|
|
|
expect(page).to have_content("#{author_commit.author_name} authored #{commit.authored_date.strftime("%b %d, %Y")}")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'author is complete' do
|
|
|
|
let(:author) { "#{author_commit.author_name} <#{author_commit.author_email}>" }
|
|
|
|
|
|
|
|
it_behaves_like 'show commits by author'
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'author is just a name' do
|
|
|
|
let(:author) { "#{author_commit.author_name}" }
|
|
|
|
|
|
|
|
it_behaves_like 'show commits by author'
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'author is just an email' do
|
|
|
|
let(:author) { "#{author_commit.author_email}" }
|
|
|
|
|
|
|
|
it_behaves_like 'show commits by author'
|
|
|
|
end
|
|
|
|
end
|
2015-08-26 01:42:46 +00:00
|
|
|
end
|