2019-09-30 12:06:01 +00:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2018-01-27 16:32:10 +00:00
|
|
|
require "spec_helper"
|
|
|
|
|
2020-06-24 09:08:32 +00:00
|
|
|
RSpec.describe UserCalloutsHelper do
|
2021-09-15 00:09:30 +00:00
|
|
|
let_it_be(:user, refind: true) { create(:user) }
|
2018-01-27 16:32:10 +00:00
|
|
|
|
|
|
|
before do
|
|
|
|
allow(helper).to receive(:current_user).and_return(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '.show_gke_cluster_integration_callout?' do
|
2020-06-26 15:08:45 +00:00
|
|
|
let_it_be(:project) { create(:project) }
|
2018-01-27 16:32:10 +00:00
|
|
|
|
2018-01-30 15:59:10 +00:00
|
|
|
subject { helper.show_gke_cluster_integration_callout?(project) }
|
2018-01-27 16:32:10 +00:00
|
|
|
|
2018-02-05 13:33:49 +00:00
|
|
|
context 'when user can create a cluster' do
|
2018-01-27 16:32:10 +00:00
|
|
|
before do
|
2018-02-05 13:33:49 +00:00
|
|
|
allow(helper).to receive(:can?).with(anything, :create_cluster, anything)
|
|
|
|
.and_return(true)
|
2018-01-27 16:32:10 +00:00
|
|
|
end
|
|
|
|
|
2018-02-05 13:33:49 +00:00
|
|
|
context 'when user has not dismissed' do
|
2018-01-27 16:32:10 +00:00
|
|
|
before do
|
2018-02-05 13:33:49 +00:00
|
|
|
allow(helper).to receive(:user_dismissed?).and_return(false)
|
2018-01-27 16:32:10 +00:00
|
|
|
end
|
|
|
|
|
2020-08-13 03:10:13 +00:00
|
|
|
context 'when active_nav_link is in the operations section' do
|
|
|
|
before do
|
|
|
|
allow(helper).to receive(:active_nav_link?).and_return(true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to be true }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when active_nav_link is not in the operations section' do
|
|
|
|
before do
|
|
|
|
allow(helper).to receive(:active_nav_link?).and_return(false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to be false }
|
|
|
|
end
|
2018-01-27 16:32:10 +00:00
|
|
|
end
|
|
|
|
|
2018-02-05 13:33:49 +00:00
|
|
|
context 'when user dismissed' do
|
2018-02-02 02:39:07 +00:00
|
|
|
before do
|
2018-02-05 13:33:49 +00:00
|
|
|
allow(helper).to receive(:user_dismissed?).and_return(true)
|
2018-01-27 16:32:10 +00:00
|
|
|
end
|
|
|
|
|
2018-02-02 02:39:07 +00:00
|
|
|
it { is_expected.to be false }
|
2018-01-27 16:32:10 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-02-05 13:33:49 +00:00
|
|
|
context 'when user can not create a cluster' do
|
2018-01-27 16:32:10 +00:00
|
|
|
before do
|
2018-02-05 13:33:49 +00:00
|
|
|
allow(helper).to receive(:can?).with(anything, :create_cluster, anything)
|
|
|
|
.and_return(false)
|
2018-01-27 16:32:10 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to be false }
|
|
|
|
end
|
|
|
|
end
|
2019-01-04 23:14:15 +00:00
|
|
|
|
2020-08-18 21:09:57 +00:00
|
|
|
describe '.show_customize_homepage_banner?' do
|
2021-03-24 06:09:16 +00:00
|
|
|
subject { helper.show_customize_homepage_banner? }
|
2020-08-18 21:09:57 +00:00
|
|
|
|
|
|
|
context 'when user has not dismissed' do
|
|
|
|
before do
|
|
|
|
allow(helper).to receive(:user_dismissed?).with(described_class::CUSTOMIZE_HOMEPAGE) { false }
|
|
|
|
end
|
|
|
|
|
2021-06-29 12:08:48 +00:00
|
|
|
context 'when user is on the default dashboard' do
|
|
|
|
it { is_expected.to be true }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user is not on the default dashboard' do
|
|
|
|
before do
|
|
|
|
user.dashboard = 'stars'
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to be false }
|
|
|
|
end
|
2020-08-18 21:09:57 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user dismissed' do
|
|
|
|
before do
|
|
|
|
allow(helper).to receive(:user_dismissed?).with(described_class::CUSTOMIZE_HOMEPAGE) { true }
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to be false }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-01-04 23:14:15 +00:00
|
|
|
describe '.render_flash_user_callout' do
|
|
|
|
it 'renders the flash_user_callout partial' do
|
|
|
|
expect(helper).to receive(:render)
|
|
|
|
.with(/flash_user_callout/, flash_type: :warning, message: 'foo', feature_name: 'bar')
|
|
|
|
|
|
|
|
helper.render_flash_user_callout(:warning, 'foo', 'bar')
|
|
|
|
end
|
|
|
|
end
|
2020-10-07 12:09:12 +00:00
|
|
|
|
|
|
|
describe '.show_feature_flags_new_version?' do
|
|
|
|
subject { helper.show_feature_flags_new_version? }
|
|
|
|
|
|
|
|
let(:user) { create(:user) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
allow(helper).to receive(:current_user).and_return(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the feature flags new version info has not been dismissed' do
|
|
|
|
it { is_expected.to be_truthy }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the feature flags new version has been dismissed' do
|
|
|
|
before do
|
|
|
|
create(:user_callout, user: user, feature_name: described_class::FEATURE_FLAGS_NEW_VERSION)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to be_falsy }
|
|
|
|
end
|
|
|
|
end
|
2020-11-16 09:09:18 +00:00
|
|
|
|
|
|
|
describe '.show_registration_enabled_user_callout?' do
|
|
|
|
let_it_be(:admin) { create(:user, :admin) }
|
|
|
|
|
|
|
|
subject { helper.show_registration_enabled_user_callout? }
|
|
|
|
|
2020-11-19 00:09:41 +00:00
|
|
|
context 'when on gitlab.com' do
|
|
|
|
before do
|
|
|
|
allow(::Gitlab).to receive(:com?).and_return(true)
|
|
|
|
allow(helper).to receive(:current_user).and_return(admin)
|
|
|
|
stub_application_setting(signup_enabled: true)
|
|
|
|
allow(helper).to receive(:user_dismissed?).with(described_class::REGISTRATION_ENABLED_CALLOUT) { false }
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to be false }
|
|
|
|
end
|
|
|
|
|
2020-11-16 09:09:18 +00:00
|
|
|
context 'when `current_user` is not an admin' do
|
|
|
|
before do
|
2020-11-19 00:09:41 +00:00
|
|
|
allow(::Gitlab).to receive(:com?).and_return(false)
|
2020-11-16 09:09:18 +00:00
|
|
|
allow(helper).to receive(:current_user).and_return(user)
|
|
|
|
stub_application_setting(signup_enabled: true)
|
|
|
|
allow(helper).to receive(:user_dismissed?).with(described_class::REGISTRATION_ENABLED_CALLOUT) { false }
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to be false }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when signup is disabled' do
|
|
|
|
before do
|
2020-11-19 00:09:41 +00:00
|
|
|
allow(::Gitlab).to receive(:com?).and_return(false)
|
2020-11-16 09:09:18 +00:00
|
|
|
allow(helper).to receive(:current_user).and_return(admin)
|
|
|
|
stub_application_setting(signup_enabled: false)
|
|
|
|
allow(helper).to receive(:user_dismissed?).with(described_class::REGISTRATION_ENABLED_CALLOUT) { false }
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to be false }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user has dismissed callout' do
|
|
|
|
before do
|
2020-11-19 00:09:41 +00:00
|
|
|
allow(::Gitlab).to receive(:com?).and_return(false)
|
2020-11-16 09:09:18 +00:00
|
|
|
allow(helper).to receive(:current_user).and_return(admin)
|
|
|
|
stub_application_setting(signup_enabled: true)
|
|
|
|
allow(helper).to receive(:user_dismissed?).with(described_class::REGISTRATION_ENABLED_CALLOUT) { true }
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to be false }
|
|
|
|
end
|
|
|
|
|
2020-11-19 00:09:41 +00:00
|
|
|
context 'when not gitlab.com, `current_user` is an admin, signup is enabled, and user has not dismissed callout' do
|
2020-11-16 09:09:18 +00:00
|
|
|
before do
|
2020-11-19 00:09:41 +00:00
|
|
|
allow(::Gitlab).to receive(:com?).and_return(false)
|
2020-11-16 09:09:18 +00:00
|
|
|
allow(helper).to receive(:current_user).and_return(admin)
|
|
|
|
stub_application_setting(signup_enabled: true)
|
|
|
|
allow(helper).to receive(:user_dismissed?).with(described_class::REGISTRATION_ENABLED_CALLOUT) { false }
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to be true }
|
|
|
|
end
|
|
|
|
end
|
2021-01-26 18:09:30 +00:00
|
|
|
|
|
|
|
describe '.show_unfinished_tag_cleanup_callout?' do
|
|
|
|
subject { helper.show_unfinished_tag_cleanup_callout? }
|
|
|
|
|
|
|
|
before do
|
|
|
|
allow(helper).to receive(:user_dismissed?).with(described_class::UNFINISHED_TAG_CLEANUP_CALLOUT) { dismissed }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user has not dismissed' do
|
|
|
|
let(:dismissed) { false }
|
|
|
|
|
|
|
|
it { is_expected.to be true }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user dismissed' do
|
|
|
|
let(:dismissed) { true }
|
|
|
|
|
|
|
|
it { is_expected.to be false }
|
|
|
|
end
|
|
|
|
end
|
2021-09-15 00:09:30 +00:00
|
|
|
|
|
|
|
describe '.show_invite_banner?' do
|
|
|
|
let_it_be(:group) { create(:group) }
|
|
|
|
|
|
|
|
subject { helper.show_invite_banner?(group) }
|
|
|
|
|
|
|
|
context 'when user has the admin ability for the group' do
|
|
|
|
before do
|
|
|
|
group.add_owner(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the invite_members_banner has not been dismissed' do
|
|
|
|
it { is_expected.to eq(true) }
|
|
|
|
|
|
|
|
context 'when a user has dismissed this banner via cookies already' do
|
|
|
|
before do
|
|
|
|
helper.request.cookies["invite_#{group.id}_#{user.id}"] = 'true'
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to eq(false) }
|
|
|
|
|
|
|
|
it 'creates the callout from cookie', :aggregate_failures do
|
|
|
|
expect { subject }.to change { Users::GroupCallout.count }.by(1)
|
|
|
|
expect(Users::GroupCallout.last).to have_attributes(group_id: group.id,
|
|
|
|
feature_name: described_class::INVITE_MEMBERS_BANNER)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the group was just created' do
|
|
|
|
before do
|
|
|
|
flash[:notice] = "Group #{group.name} was successfully created"
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to eq(false) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with concerning multiple members' do
|
|
|
|
let_it_be(:user_2) { create(:user) }
|
|
|
|
|
|
|
|
context 'on current group' do
|
|
|
|
before do
|
|
|
|
group.add_guest(user_2)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to eq(false) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'on current group that is a subgroup' do
|
|
|
|
let_it_be(:subgroup) { create(:group, parent: group) }
|
|
|
|
|
|
|
|
subject { helper.show_invite_banner?(subgroup) }
|
|
|
|
|
|
|
|
context 'with only one user on parent and this group' do
|
|
|
|
it { is_expected.to eq(true) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when another user is on this group' do
|
|
|
|
before do
|
|
|
|
subgroup.add_guest(user_2)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to eq(false) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when another user is on the parent group' do
|
|
|
|
before do
|
|
|
|
group.add_guest(user_2)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to eq(false) }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the invite_members_banner has been dismissed' do
|
|
|
|
before do
|
|
|
|
create(:group_callout,
|
|
|
|
user: user,
|
|
|
|
group: group,
|
|
|
|
feature_name: described_class::INVITE_MEMBERS_BANNER)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to eq(false) }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user does not have admin ability for the group' do
|
|
|
|
it { is_expected.to eq(false) }
|
|
|
|
end
|
|
|
|
end
|
2021-09-30 18:11:31 +00:00
|
|
|
|
|
|
|
describe '.show_security_newsletter_user_callout?' do
|
|
|
|
let_it_be(:admin) { create(:user, :admin) }
|
|
|
|
|
|
|
|
subject { helper.show_security_newsletter_user_callout? }
|
|
|
|
|
|
|
|
context 'when `current_user` is not an admin' do
|
|
|
|
before do
|
|
|
|
allow(helper).to receive(:current_user).and_return(user)
|
|
|
|
allow(helper).to receive(:user_dismissed?).with(described_class::SECURITY_NEWSLETTER_CALLOUT) { false }
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to be false }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user has dismissed callout' do
|
|
|
|
before do
|
|
|
|
allow(helper).to receive(:current_user).and_return(admin)
|
|
|
|
allow(helper).to receive(:user_dismissed?).with(described_class::SECURITY_NEWSLETTER_CALLOUT) { true }
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to be false }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when `current_user` is an admin and user has not dismissed callout' do
|
|
|
|
before do
|
|
|
|
allow(helper).to receive(:current_user).and_return(admin)
|
|
|
|
allow(helper).to receive(:user_dismissed?).with(described_class::SECURITY_NEWSLETTER_CALLOUT) { false }
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to be true }
|
|
|
|
end
|
|
|
|
end
|
2018-01-27 16:32:10 +00:00
|
|
|
end
|