gitlab-org--gitlab-foss/lib/api/issues.rb

277 lines
12 KiB
Ruby
Raw Normal View History

module API
2012-07-24 12:19:51 +00:00
# Issues API
class Issues < Grape::API
before { authenticate! }
2014-08-14 10:41:16 +00:00
helpers do
2014-09-04 22:01:12 +00:00
def filter_issues_state(issues, state)
2014-08-14 10:41:16 +00:00
case state
when 'opened' then issues.opened
when 'closed' then issues.closed
else issues
2014-08-14 10:41:16 +00:00
end
end
2014-08-14 14:17:19 +00:00
def filter_issues_labels(issues, labels)
2014-09-04 22:01:12 +00:00
issues.includes(:labels).where('labels.title' => labels.split(','))
end
def filter_issues_milestone(issues, milestone)
issues.includes(:milestone).where('milestones.title' => milestone)
2014-08-14 14:17:19 +00:00
end
def issue_params
new_params = declared(params, include_parent_namespace: false, include_missing: false).to_h
new_params = new_params.with_indifferent_access
new_params.delete(:id)
new_params.delete(:issue_id)
new_params
end
def merge_request_for_resolving_discussions
return unless merge_request_iid = params[:merge_request_for_resolving_discussions]
@merge_request_for_resolving_discussions ||= MergeRequestsFinder.new(current_user, project_id: user_project.id).
execute.
find_by(iid: merge_request_iid)
end
2014-08-14 10:41:16 +00:00
end
2012-07-24 12:19:51 +00:00
resource :issues do
# Get currently authenticated user's issues
#
2014-08-14 10:41:16 +00:00
# Parameters:
# state (optional) - Return "opened" or "closed" issues
2014-08-14 14:17:19 +00:00
# labels (optional) - Comma-separated list of label names
# order_by (optional) - Return requests ordered by `created_at` or `updated_at` fields. Default is `created_at`
# sort (optional) - Return requests sorted in `asc` or `desc` order. Default is `desc`
#
2014-08-14 10:41:16 +00:00
# Example Requests:
2012-07-24 12:19:51 +00:00
# GET /issues
2014-08-14 10:41:16 +00:00
# GET /issues?state=opened
# GET /issues?state=closed
2014-08-14 14:17:19 +00:00
# GET /issues?labels=foo
# GET /issues?labels=foo,bar
# GET /issues?labels=foo,bar&state=opened
2012-07-24 12:19:51 +00:00
get do
issues = current_user.issues.inc_notes_with_associations
2014-08-14 14:17:19 +00:00
issues = filter_issues_state(issues, params[:state]) unless params[:state].nil?
issues = filter_issues_labels(issues, params[:labels]) unless params[:labels].nil?
2016-09-09 14:16:14 +00:00
issues = issues.reorder(issuable_order_by => issuable_sort)
2016-04-08 06:41:10 +00:00
present paginate(issues), with: Entities::Issue, current_user: current_user
2012-07-24 12:19:51 +00:00
end
end
resource :groups do
# Get a list of group issues
#
# Parameters:
# id (required) - The ID of a group
# state (optional) - Return "opened" or "closed" issues
# labels (optional) - Comma-separated list of label names
# milestone (optional) - Milestone title
# order_by (optional) - Return requests ordered by `created_at` or `updated_at` fields. Default is `created_at`
# sort (optional) - Return requests sorted in `asc` or `desc` order. Default is `desc`
#
# Example Requests:
# GET /groups/:id/issues
# GET /groups/:id/issues?state=opened
# GET /groups/:id/issues?state=closed
# GET /groups/:id/issues?labels=foo
# GET /groups/:id/issues?labels=foo,bar
# GET /groups/:id/issues?labels=foo,bar&state=opened
# GET /groups/:id/issues?milestone=1.0.0
# GET /groups/:id/issues?milestone=1.0.0&state=closed
get ":id/issues" do
group = find_group!(params[:id])
params[:state] ||= 'opened'
params[:group_id] = group.id
params[:milestone_title] = params.delete(:milestone)
params[:label_name] = params.delete(:labels)
2016-09-09 14:16:14 +00:00
if params[:order_by] || params[:sort]
# The Sortable concern takes 'created_desc', not 'created_at_desc' (for example)
params[:sort] = "#{issuable_order_by.sub('_at', '')}_#{issuable_sort}"
end
issues = IssuesFinder.new(current_user, params).execute
present paginate(issues), with: Entities::Issue, current_user: current_user
end
end
params do
requires :id, type: String, desc: 'The ID of a project'
end
2012-07-24 12:19:51 +00:00
resource :projects do
# Get a list of project issues
#
# Parameters:
# id (required) - The ID of a project
# iid (optional) - Return the project issue having the given `iid`
2014-08-14 10:41:16 +00:00
# state (optional) - Return "opened" or "closed" issues
2014-08-14 14:17:19 +00:00
# labels (optional) - Comma-separated list of label names
2014-09-04 22:01:12 +00:00
# milestone (optional) - Milestone title
# order_by (optional) - Return requests ordered by `created_at` or `updated_at` fields. Default is `created_at`
# sort (optional) - Return requests sorted in `asc` or `desc` order. Default is `desc`
2014-08-14 10:41:16 +00:00
#
# Example Requests:
2012-07-24 12:19:51 +00:00
# GET /projects/:id/issues
2014-08-14 10:41:16 +00:00
# GET /projects/:id/issues?state=opened
# GET /projects/:id/issues?state=closed
2014-08-14 14:17:19 +00:00
# GET /projects/:id/issues?labels=foo
# GET /projects/:id/issues?labels=foo,bar
# GET /projects/:id/issues?labels=foo,bar&state=opened
2014-09-04 22:01:12 +00:00
# GET /projects/:id/issues?milestone=1.0.0
# GET /projects/:id/issues?milestone=1.0.0&state=closed
# GET /issues?iid=42
2012-07-24 12:19:51 +00:00
get ":id/issues" do
Merge branch 'jej-use-issuable-finder-instead-of-access-check' into 'security' Replace issue access checks with use of IssuableFinder Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867 ## Which fixes are in this MR? :warning: - Potentially untested :bomb: - No test coverage :traffic_light: - Test coverage of some sort exists (a test failed when error raised) :vertical_traffic_light: - Test coverage of return value (a test failed when nil used) :white_check_mark: - Permissions check tested ### Issue lookup with access check Using `visible_to_user` likely makes these security issues too. See [Code smells](#code-smells). - [x] :vertical_traffic_light: app/finders/notes_finder.rb:15 [`visible_to_user`] - [x] :traffic_light: app/views/layouts/nav/_project.html.haml:73 [`visible_to_user`] [`.count`] - [x] :white_check_mark: app/services/merge_requests/build_service.rb:84 [`issue.try(:confidential?)`] - [x] :white_check_mark: lib/api/issues.rb:112 [`visible_to_user`] - CHANGELOG: Prevented API returning issues set to 'Only team members' to everyone - [x] :white_check_mark: lib/api/helpers.rb:126 [`can?(current_user, :read_issue, issue)`] Maybe here too? - [x] :white_check_mark: lib/gitlab/search_results.rb:53 [`visible_to_user`] ### Previous discussions - [ ] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#b2ff264eddf9819d7693c14ae213d941494fe2b3_128_126 - [ ] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#7b6375270d22f880bdcb085e47b519b426a5c6c7_87_87 See merge request !2031
2016-11-22 10:25:04 +00:00
issues = IssuesFinder.new(current_user, project_id: user_project.id).execute.inc_notes_with_associations
2014-08-14 14:17:19 +00:00
issues = filter_issues_state(issues, params[:state]) unless params[:state].nil?
issues = filter_issues_labels(issues, params[:labels]) unless params[:labels].nil?
issues = filter_by_iid(issues, params[:iid]) unless params[:iid].nil?
2014-09-04 22:01:12 +00:00
unless params[:milestone].nil?
issues = filter_issues_milestone(issues, params[:milestone])
end
2014-08-14 14:17:19 +00:00
2016-09-09 14:16:14 +00:00
issues = issues.reorder(issuable_order_by => issuable_sort)
present paginate(issues), with: Entities::Issue, current_user: current_user, project: user_project
2012-07-24 12:19:51 +00:00
end
# Get a single project issue
#
# Parameters:
# id (required) - The ID of a project
2012-07-24 12:19:51 +00:00
# issue_id (required) - The ID of a project issue
# Example Request:
# GET /projects/:id/issues/:issue_id
get ":id/issues/:issue_id" do
@issue = find_project_issue(params[:issue_id])
present @issue, with: Entities::Issue, current_user: current_user, project: user_project
2012-07-24 12:19:51 +00:00
end
# Create a new project issue
#
# Parameters:
# id (required) - The ID of a project
# title (required) - The title of an issue
# description (optional) - The description of an issue
# assignee_id (optional) - The ID of a user to assign issue
# milestone_id (optional) - The ID of a milestone to assign issue
# labels (optional) - The labels of an issue
# created_at (optional) - Date time string, ISO 8601 formatted
# due_date (optional) - Date time string in the format YEAR-MONTH-DAY
# confidential (optional) - Boolean parameter if the issue should be confidential
# merge_request_for_resolving_discussions (optional) - The IID of a merge request for which to resolve discussions
2012-07-24 12:19:51 +00:00
# Example Request:
# POST /projects/:id/issues
2016-07-12 15:59:21 +00:00
post ':id/issues' do
required_attributes! [:title]
keys = [:title, :description, :assignee_id, :milestone_id, :due_date, :confidential, :labels, :merge_request_for_resolving_discussions]
keys << :created_at if current_user.admin? || user_project.owner == current_user
attrs = attributes_for_keys(keys)
attrs[:labels] = params[:labels] if params[:labels]
attrs[:merge_request_for_resolving_discussions] = merge_request_for_resolving_discussions if params[:merge_request_for_resolving_discussions]
2016-07-15 14:21:53 +00:00
# Convert and filter out invalid confidential flags
attrs['confidential'] = to_boolean(attrs['confidential'])
attrs.delete('confidential') if attrs['confidential'].nil?
issue = ::Issues::CreateService.new(user_project, current_user, attrs.merge(request: request, api: true)).execute
if issue.spam?
render_api_error!({ error: 'Spam detected' }, 400)
end
if issue.valid?
present issue, with: Entities::Issue, current_user: current_user, project: user_project
else
render_validation_error!(issue)
2012-07-24 12:19:51 +00:00
end
end
desc 'Update an existing issue' do
success Entities::Issue
end
params do
requires :id, type: String, desc: 'The ID of a project'
requires :issue_id, type: Integer, desc: "The ID of a project issue"
optional :title, type: String, desc: 'The new title of the issue'
optional :description, type: String, desc: 'The description of an issue'
optional :assignee_id, type: Integer, desc: 'The ID of a user to assign issue'
optional :milestone_id, type: Integer, desc: 'The ID of a milestone to assign issue'
optional :labels, type: String, desc: 'The labels of an issue'
optional :state_event, type: String, values: ['close', 'reopen'], desc: 'The state event of an issue'
# TODO 9.0, use the Grape DateTime type here
optional :updated_at, type: String, desc: 'Date time string, ISO 8601 formatted'
optional :due_date, type: String, desc: 'Date time string in the format YEAR-MONTH-DAY'
# TODO 9.0, use the Grape boolean type here
optional :confidential, type: String, desc: 'Boolean parameter if the issue should be confidential'
end
2016-07-12 15:59:21 +00:00
put ':id/issues/:issue_id' do
issue = user_project.issues.find(params[:issue_id])
authorize! :update_issue, issue
2016-07-15 14:21:53 +00:00
# Convert and filter out invalid confidential flags
params[:confidential] = to_boolean(params[:confidential])
params.delete(:confidential) if params[:confidential].nil?
params.delete(:updated_at) unless current_user.admin? || user_project.owner == current_user
2016-07-15 14:21:53 +00:00
issue = ::Issues::UpdateService.new(user_project, current_user, issue_params).execute(issue)
2013-06-11 15:15:18 +00:00
if issue.valid?
present issue, with: Entities::Issue, current_user: current_user, project: user_project
else
render_validation_error!(issue)
2012-07-24 12:19:51 +00:00
end
end
2016-04-07 12:07:17 +00:00
# Move an existing issue
#
# Parameters:
2016-04-12 16:38:18 +00:00
# id (required) - The ID of a project
# issue_id (required) - The ID of a project issue
# to_project_id (required) - The ID of the new project
2016-04-07 12:07:17 +00:00
# Example Request:
# POST /projects/:id/issues/:issue_id/move
2016-04-12 16:38:18 +00:00
post ':id/issues/:issue_id/move' do
required_attributes! [:to_project_id]
2016-04-07 12:07:17 +00:00
issue = user_project.issues.find(params[:issue_id])
2016-04-12 16:38:18 +00:00
new_project = Project.find(params[:to_project_id])
2016-04-07 12:07:17 +00:00
begin
issue = ::Issues::MoveService.new(user_project, current_user).execute(issue, new_project)
present issue, with: Entities::Issue, current_user: current_user, project: user_project
2016-04-07 12:07:17 +00:00
rescue ::Issues::MoveService::MoveError => error
render_api_error!(error.message, 400)
end
end
#
2016-02-26 08:55:43 +00:00
# Delete a project issue
2012-07-24 12:19:51 +00:00
#
# Parameters:
# id (required) - The ID of a project
2012-07-24 12:19:51 +00:00
# issue_id (required) - The ID of a project issue
# Example Request:
# DELETE /projects/:id/issues/:issue_id
delete ":id/issues/:issue_id" do
2016-03-21 13:12:52 +00:00
issue = user_project.issues.find_by(id: params[:issue_id])
2016-02-26 08:55:43 +00:00
2016-03-21 13:12:52 +00:00
authorize!(:destroy_issue, issue)
2016-02-26 08:55:43 +00:00
issue.destroy
2012-07-24 12:19:51 +00:00
end
end
end
end