2015-08-26 01:42:46 +00:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2015-12-08 10:59:46 +00:00
|
|
|
describe 'Commits' do
|
2015-10-06 18:36:22 +00:00
|
|
|
include CiStatusHelper
|
2015-09-11 11:05:31 +00:00
|
|
|
|
2017-03-28 21:13:16 +00:00
|
|
|
let(:project) { create(:project, :repository) }
|
2017-06-20 02:06:13 +00:00
|
|
|
let(:user) { create(:user) }
|
2015-10-06 18:36:22 +00:00
|
|
|
|
2015-12-08 10:59:46 +00:00
|
|
|
describe 'CI' do
|
2015-08-26 01:42:46 +00:00
|
|
|
before do
|
2017-06-20 02:06:13 +00:00
|
|
|
sign_in(user)
|
2016-06-03 14:22:26 +00:00
|
|
|
stub_ci_pipeline_to_return_yaml_file
|
2015-08-26 01:42:46 +00:00
|
|
|
end
|
|
|
|
|
2017-03-13 15:39:12 +00:00
|
|
|
let(:creator) { create(:user) }
|
2017-03-20 19:53:14 +00:00
|
|
|
|
2016-06-03 14:22:26 +00:00
|
|
|
let!(:pipeline) do
|
2016-10-24 15:23:28 +00:00
|
|
|
create(:ci_pipeline,
|
|
|
|
project: project,
|
2017-03-13 15:39:12 +00:00
|
|
|
user: creator,
|
2016-10-24 15:23:28 +00:00
|
|
|
ref: project.default_branch,
|
|
|
|
sha: project.commit.sha,
|
2017-03-13 15:39:12 +00:00
|
|
|
status: :success,
|
|
|
|
created_at: 5.months.ago)
|
2015-10-05 12:31:51 +00:00
|
|
|
end
|
|
|
|
|
2016-01-26 07:32:36 +00:00
|
|
|
context 'commit status is Generic Commit Status' do
|
2016-10-24 15:23:28 +00:00
|
|
|
let!(:status) { create(:generic_commit_status, pipeline: pipeline) }
|
2015-12-08 10:59:46 +00:00
|
|
|
|
2016-02-04 11:57:46 +00:00
|
|
|
before do
|
2017-06-20 02:06:13 +00:00
|
|
|
project.team << [user, :reporter]
|
2016-02-04 11:57:46 +00:00
|
|
|
end
|
|
|
|
|
2016-01-26 07:32:36 +00:00
|
|
|
describe 'Commit builds' do
|
|
|
|
before do
|
2016-06-03 14:22:26 +00:00
|
|
|
visit ci_status_path(pipeline)
|
2016-01-26 07:32:36 +00:00
|
|
|
end
|
2015-12-14 10:28:49 +00:00
|
|
|
|
2016-06-03 14:22:26 +00:00
|
|
|
it { expect(page).to have_content pipeline.sha[0..7] }
|
2016-01-26 07:32:36 +00:00
|
|
|
|
|
|
|
it 'contains generic commit status build' do
|
|
|
|
page.within('.table-holder') do
|
|
|
|
expect(page).to have_content "##{status.id}" # build id
|
|
|
|
expect(page).to have_content 'generic' # build name
|
|
|
|
end
|
2015-12-14 10:28:49 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-01-26 07:32:36 +00:00
|
|
|
context 'commit status is Ci Build' do
|
2016-10-24 15:23:28 +00:00
|
|
|
let!(:build) { create(:ci_build, pipeline: pipeline) }
|
2016-02-04 11:57:46 +00:00
|
|
|
let(:artifacts_file) { fixture_file_upload(Rails.root + 'spec/fixtures/banana_sample.gif', 'image/gif') }
|
2015-08-26 01:42:46 +00:00
|
|
|
|
2016-02-04 11:57:46 +00:00
|
|
|
context 'when logged as developer' do
|
2016-01-26 07:32:36 +00:00
|
|
|
before do
|
2017-06-20 02:06:13 +00:00
|
|
|
project.team << [user, :developer]
|
2016-01-26 07:32:36 +00:00
|
|
|
end
|
2015-10-12 21:47:32 +00:00
|
|
|
|
2016-02-04 11:57:46 +00:00
|
|
|
describe 'Project commits' do
|
2016-10-24 15:23:28 +00:00
|
|
|
let!(:pipeline_from_other_branch) do
|
|
|
|
create(:ci_pipeline,
|
|
|
|
project: project,
|
|
|
|
ref: 'fix',
|
|
|
|
sha: project.commit.sha,
|
|
|
|
status: :failed)
|
|
|
|
end
|
|
|
|
|
2016-02-04 11:57:46 +00:00
|
|
|
before do
|
2017-06-29 17:06:35 +00:00
|
|
|
visit project_commits_path(project, :master)
|
2016-01-26 07:32:36 +00:00
|
|
|
end
|
2015-10-12 21:47:32 +00:00
|
|
|
|
2016-10-24 15:23:28 +00:00
|
|
|
it 'shows correct build status from default branch' do
|
2016-06-03 14:22:26 +00:00
|
|
|
page.within("//li[@id='commit-#{pipeline.short_sha}']") do
|
2016-10-24 15:23:28 +00:00
|
|
|
expect(page).to have_css('.ci-status-link')
|
|
|
|
expect(page).to have_css('.ci-status-icon-success')
|
2016-02-04 11:57:46 +00:00
|
|
|
end
|
|
|
|
end
|
2016-01-26 07:32:36 +00:00
|
|
|
end
|
2015-10-12 21:47:32 +00:00
|
|
|
|
2017-06-02 13:24:42 +00:00
|
|
|
describe 'Commit builds', :feature, :js do
|
2016-02-04 11:57:46 +00:00
|
|
|
before do
|
2016-06-03 14:22:26 +00:00
|
|
|
visit ci_status_path(pipeline)
|
2016-02-04 11:57:46 +00:00
|
|
|
end
|
2015-08-26 01:42:46 +00:00
|
|
|
|
2016-10-19 12:25:37 +00:00
|
|
|
it 'shows pipeline`s data' do
|
|
|
|
expect(page).to have_content pipeline.sha[0..7]
|
|
|
|
expect(page).to have_content pipeline.git_commit_message
|
2017-03-13 15:39:12 +00:00
|
|
|
expect(page).to have_content pipeline.user.name
|
2016-10-19 12:25:37 +00:00
|
|
|
end
|
2015-12-08 10:02:13 +00:00
|
|
|
end
|
|
|
|
|
2016-02-04 11:57:46 +00:00
|
|
|
context 'Download artifacts' do
|
|
|
|
before do
|
|
|
|
build.update_attributes(artifacts_file: artifacts_file)
|
|
|
|
end
|
2015-08-26 01:42:46 +00:00
|
|
|
|
2016-02-04 11:57:46 +00:00
|
|
|
it do
|
2016-06-03 14:22:26 +00:00
|
|
|
visit ci_status_path(pipeline)
|
2016-02-04 11:57:46 +00:00
|
|
|
click_on 'Download artifacts'
|
|
|
|
expect(page.response_headers['Content-Type']).to eq(artifacts_file.content_type)
|
|
|
|
end
|
2015-12-08 10:02:13 +00:00
|
|
|
end
|
2016-01-26 07:32:36 +00:00
|
|
|
|
2016-02-04 11:57:46 +00:00
|
|
|
describe 'Cancel all builds' do
|
2017-06-02 13:24:42 +00:00
|
|
|
it 'cancels commit', :js do
|
2016-06-03 14:22:26 +00:00
|
|
|
visit ci_status_path(pipeline)
|
2016-02-04 11:57:46 +00:00
|
|
|
click_on 'Cancel running'
|
|
|
|
expect(page).to have_content 'canceled'
|
2016-01-26 07:32:36 +00:00
|
|
|
end
|
2016-02-04 11:57:46 +00:00
|
|
|
end
|
2016-01-26 07:32:36 +00:00
|
|
|
|
2016-02-04 11:57:46 +00:00
|
|
|
describe 'Cancel build' do
|
2017-06-02 13:24:42 +00:00
|
|
|
it 'cancels build', :js do
|
2016-06-03 14:22:26 +00:00
|
|
|
visit ci_status_path(pipeline)
|
2017-06-02 13:24:42 +00:00
|
|
|
find('.js-btn-cancel-pipeline').click
|
2016-02-04 11:57:46 +00:00
|
|
|
expect(page).to have_content 'canceled'
|
2016-01-26 07:32:36 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-02-04 11:57:46 +00:00
|
|
|
describe '.gitlab-ci.yml not found warning' do
|
|
|
|
context 'ci builds enabled' do
|
|
|
|
it "does not show warning" do
|
2016-06-03 14:22:26 +00:00
|
|
|
visit ci_status_path(pipeline)
|
2016-02-04 11:57:46 +00:00
|
|
|
expect(page).not_to have_content '.gitlab-ci.yml not found in this commit'
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'shows warning' do
|
2016-06-03 14:22:26 +00:00
|
|
|
stub_ci_pipeline_yaml_file(nil)
|
|
|
|
visit ci_status_path(pipeline)
|
2016-02-04 11:57:46 +00:00
|
|
|
expect(page).to have_content '.gitlab-ci.yml not found in this commit'
|
|
|
|
end
|
2016-01-26 07:32:36 +00:00
|
|
|
end
|
2015-12-08 10:02:13 +00:00
|
|
|
|
2016-02-04 11:57:46 +00:00
|
|
|
context 'ci builds disabled' do
|
|
|
|
before do
|
|
|
|
stub_ci_builds_disabled
|
2016-06-03 14:22:26 +00:00
|
|
|
stub_ci_pipeline_yaml_file(nil)
|
|
|
|
visit ci_status_path(pipeline)
|
2016-02-04 11:57:46 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not show warning' do
|
|
|
|
expect(page).not_to have_content '.gitlab-ci.yml not found in this commit'
|
|
|
|
end
|
2016-01-26 07:32:36 +00:00
|
|
|
end
|
2015-12-08 10:02:13 +00:00
|
|
|
end
|
2015-08-26 01:42:46 +00:00
|
|
|
end
|
2016-02-04 11:57:46 +00:00
|
|
|
|
|
|
|
context "when logged as reporter" do
|
|
|
|
before do
|
2017-06-20 02:06:13 +00:00
|
|
|
project.team << [user, :reporter]
|
2016-02-04 11:57:46 +00:00
|
|
|
build.update_attributes(artifacts_file: artifacts_file)
|
2016-06-03 14:22:26 +00:00
|
|
|
visit ci_status_path(pipeline)
|
2016-02-04 11:57:46 +00:00
|
|
|
end
|
|
|
|
|
2017-06-02 13:24:42 +00:00
|
|
|
it 'Renders header', :feature, :js do
|
2016-06-03 14:22:26 +00:00
|
|
|
expect(page).to have_content pipeline.sha[0..7]
|
|
|
|
expect(page).to have_content pipeline.git_commit_message
|
2017-03-13 15:39:12 +00:00
|
|
|
expect(page).to have_content pipeline.user.name
|
2016-05-23 23:37:59 +00:00
|
|
|
expect(page).not_to have_link('Cancel running')
|
2017-02-20 16:08:29 +00:00
|
|
|
expect(page).not_to have_link('Retry')
|
2016-02-04 11:57:46 +00:00
|
|
|
end
|
2017-06-02 13:24:42 +00:00
|
|
|
|
|
|
|
it do
|
|
|
|
expect(page).to have_link('Download artifacts')
|
|
|
|
end
|
2016-02-04 11:57:46 +00:00
|
|
|
end
|
|
|
|
|
2017-06-02 13:24:42 +00:00
|
|
|
context 'when accessing internal project with disallowed access', :feature, :js do
|
2016-02-04 11:57:46 +00:00
|
|
|
before do
|
|
|
|
project.update(
|
|
|
|
visibility_level: Gitlab::VisibilityLevel::INTERNAL,
|
|
|
|
public_builds: false)
|
|
|
|
build.update_attributes(artifacts_file: artifacts_file)
|
2016-06-03 14:22:26 +00:00
|
|
|
visit ci_status_path(pipeline)
|
2016-02-04 11:57:46 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it do
|
2016-06-03 14:22:26 +00:00
|
|
|
expect(page).to have_content pipeline.sha[0..7]
|
|
|
|
expect(page).to have_content pipeline.git_commit_message
|
2017-03-13 15:39:12 +00:00
|
|
|
expect(page).to have_content pipeline.user.name
|
2017-06-02 13:24:42 +00:00
|
|
|
|
2016-05-23 23:37:59 +00:00
|
|
|
expect(page).not_to have_link('Cancel running')
|
2017-02-20 16:08:29 +00:00
|
|
|
expect(page).not_to have_link('Retry')
|
2016-02-04 11:57:46 +00:00
|
|
|
end
|
|
|
|
end
|
2015-08-26 01:42:46 +00:00
|
|
|
end
|
|
|
|
end
|
2016-11-30 21:28:42 +00:00
|
|
|
|
|
|
|
context 'viewing commits for a branch' do
|
|
|
|
let(:branch_name) { 'master' }
|
|
|
|
|
|
|
|
before do
|
|
|
|
project.team << [user, :master]
|
2017-06-20 02:06:13 +00:00
|
|
|
sign_in(user)
|
2017-06-29 17:06:35 +00:00
|
|
|
visit project_commits_path(project, branch_name)
|
2016-11-30 21:28:42 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'includes the committed_date for each commit' do
|
|
|
|
commits = project.repository.commits(branch_name)
|
|
|
|
|
|
|
|
commits.each do |commit|
|
2017-02-13 09:01:09 +00:00
|
|
|
expect(page).to have_content("committed #{commit.committed_date.strftime("%b %d, %Y")}")
|
2016-11-30 21:28:42 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2017-02-23 11:03:18 +00:00
|
|
|
|
|
|
|
describe 'GPG signed commits' do
|
2017-06-22 06:47:11 +00:00
|
|
|
it 'changes from unverified to verified when the user changes his email to match the gpg key' do
|
|
|
|
user = create :user, email: 'unrelated.user@example.org'
|
|
|
|
project.team << [user, :master]
|
|
|
|
|
2017-06-22 12:18:01 +00:00
|
|
|
Sidekiq::Testing.inline! do
|
|
|
|
create :gpg_key, key: GpgHelpers::User1.public_key, user: user
|
|
|
|
end
|
2017-06-22 06:47:11 +00:00
|
|
|
|
2017-06-28 11:24:52 +00:00
|
|
|
sign_in(user)
|
2017-02-23 11:03:18 +00:00
|
|
|
|
2017-06-26 12:29:01 +00:00
|
|
|
visit namespace_project_commits_path(project.namespace, project, :'signed-commits')
|
2017-02-23 11:03:18 +00:00
|
|
|
|
|
|
|
within '#commits-list' do
|
|
|
|
expect(page).to have_content 'Unverified'
|
2017-06-22 06:47:11 +00:00
|
|
|
expect(page).not_to have_content 'Verified'
|
2017-02-23 11:03:18 +00:00
|
|
|
end
|
2017-02-28 14:25:12 +00:00
|
|
|
|
2017-06-22 06:47:11 +00:00
|
|
|
# user changes his email which makes the gpg key verified
|
2017-06-22 12:18:01 +00:00
|
|
|
Sidekiq::Testing.inline! do
|
|
|
|
user.skip_reconfirmation!
|
|
|
|
user.update_attributes!(email: GpgHelpers::User1.emails.first)
|
|
|
|
end
|
2017-06-22 06:47:11 +00:00
|
|
|
|
2017-06-26 12:29:01 +00:00
|
|
|
visit namespace_project_commits_path(project.namespace, project, :'signed-commits')
|
2017-06-22 06:47:11 +00:00
|
|
|
|
|
|
|
within '#commits-list' do
|
|
|
|
expect(page).to have_content 'Unverified'
|
|
|
|
expect(page).to have_content 'Verified'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'changes from unverified to verified when the user adds the missing gpg key' do
|
|
|
|
user = create :user, email: GpgHelpers::User1.emails.first
|
|
|
|
project.team << [user, :master]
|
|
|
|
|
2017-06-28 11:24:52 +00:00
|
|
|
sign_in(user)
|
2017-02-28 14:25:12 +00:00
|
|
|
|
2017-06-26 12:29:01 +00:00
|
|
|
visit namespace_project_commits_path(project.namespace, project, :'signed-commits')
|
2017-02-28 14:25:12 +00:00
|
|
|
|
|
|
|
within '#commits-list' do
|
|
|
|
expect(page).to have_content 'Unverified'
|
|
|
|
expect(page).not_to have_content 'Verified'
|
|
|
|
end
|
2017-06-22 06:47:11 +00:00
|
|
|
|
|
|
|
# user adds the gpg key which makes the signature valid
|
2017-06-22 12:18:01 +00:00
|
|
|
Sidekiq::Testing.inline! do
|
|
|
|
create :gpg_key, key: GpgHelpers::User1.public_key, user: user
|
|
|
|
end
|
2017-06-22 06:47:11 +00:00
|
|
|
|
2017-06-26 12:29:01 +00:00
|
|
|
visit namespace_project_commits_path(project.namespace, project, :'signed-commits')
|
2017-06-22 06:47:11 +00:00
|
|
|
|
|
|
|
within '#commits-list' do
|
|
|
|
expect(page).to have_content 'Unverified'
|
|
|
|
expect(page).to have_content 'Verified'
|
|
|
|
end
|
2017-02-23 11:03:18 +00:00
|
|
|
end
|
2017-06-23 20:52:43 +00:00
|
|
|
|
|
|
|
it 'shows popover badges', :js do
|
2017-07-13 14:04:19 +00:00
|
|
|
gpg_user = create :user, email: GpgHelpers::User1.emails.first, username: 'nannie.bernhard', name: 'Nannie Bernhard'
|
2017-06-23 20:52:43 +00:00
|
|
|
Sidekiq::Testing.inline! do
|
2017-07-13 14:04:19 +00:00
|
|
|
create :gpg_key, key: GpgHelpers::User1.public_key, user: gpg_user
|
2017-06-23 20:52:43 +00:00
|
|
|
end
|
|
|
|
|
2017-07-13 14:04:19 +00:00
|
|
|
user = create :user
|
|
|
|
project.team << [user, :master]
|
|
|
|
|
2017-06-28 11:24:52 +00:00
|
|
|
sign_in(user)
|
2017-06-26 12:29:01 +00:00
|
|
|
visit namespace_project_commits_path(project.namespace, project, :'signed-commits')
|
2017-06-23 20:52:43 +00:00
|
|
|
|
2017-07-13 14:04:19 +00:00
|
|
|
# unverified signature
|
2017-07-10 08:02:41 +00:00
|
|
|
click_on 'Unverified', match: :first
|
|
|
|
within '.popover' do
|
|
|
|
expect(page).to have_content 'This commit was signed with an unverified signature.'
|
|
|
|
expect(page).to have_content "GPG Key ID: #{GpgHelpers::User2.primary_keyid}"
|
|
|
|
end
|
|
|
|
|
2017-07-13 14:04:19 +00:00
|
|
|
# verified and the gpg user has a gitlab profile
|
2017-06-23 20:52:43 +00:00
|
|
|
click_on 'Verified'
|
|
|
|
within '.popover' do
|
|
|
|
expect(page).to have_content 'This commit was signed with a verified signature.'
|
|
|
|
expect(page).to have_content 'Nannie Bernhard'
|
2017-07-13 14:08:14 +00:00
|
|
|
expect(page).to have_content '@nannie.bernhard'
|
2017-07-10 08:02:41 +00:00
|
|
|
expect(page).to have_content "GPG Key ID: #{GpgHelpers::User1.primary_keyid}"
|
2017-06-23 20:52:43 +00:00
|
|
|
end
|
2017-07-13 14:04:19 +00:00
|
|
|
|
|
|
|
# verified and the gpg user's profile doesn't exist anymore
|
|
|
|
gpg_user.destroy!
|
|
|
|
|
|
|
|
visit namespace_project_commits_path(project.namespace, project, :'signed-commits')
|
|
|
|
|
|
|
|
click_on 'Verified'
|
|
|
|
within '.popover' do
|
|
|
|
expect(page).to have_content 'This commit was signed with a verified signature.'
|
|
|
|
expect(page).to have_content 'Nannie Bernhard'
|
|
|
|
expect(page).to have_content 'nannie.bernhard@example.com'
|
|
|
|
expect(page).to have_content "GPG Key ID: #{GpgHelpers::User1.primary_keyid}"
|
|
|
|
end
|
2017-06-23 20:52:43 +00:00
|
|
|
end
|
2017-02-23 11:03:18 +00:00
|
|
|
end
|
2015-08-26 01:42:46 +00:00
|
|
|
end
|