2013-05-15 13:59:15 +00:00
|
|
|
require 'spec_helper'
|
|
|
|
|
|
2015-12-09 10:55:49 +00:00
|
|
|
describe Issues::BulkUpdateService, services: true do
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
let(:user) { create(:user) }
|
|
|
|
|
let(:project) { Projects::CreateService.new(user, namespace: user.namespace, name: 'test').execute }
|
2013-05-16 10:32:16 +00:00
|
|
|
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
let!(:result) { Issues::BulkUpdateService.new(project, user, params).execute }
|
2013-05-15 13:59:15 +00:00
|
|
|
|
2016-05-31 21:33:18 +00:00
|
|
|
describe :close_issue do
|
|
|
|
|
let(:issues) { create_list(:issue, 5, project: project) }
|
|
|
|
|
let(:params) do
|
|
|
|
|
{
|
2015-03-06 14:01:13 +00:00
|
|
|
state_event: 'close',
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
issues_ids: issues.map(&:id).join(',')
|
2013-05-15 13:59:15 +00:00
|
|
|
}
|
|
|
|
|
end
|
|
|
|
|
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
it 'succeeds and returns the correct number of issues updated' do
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(result[:success]).to be_truthy
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
expect(result[:count]).to eq(issues.count)
|
2015-06-22 20:00:54 +00:00
|
|
|
end
|
2013-05-15 13:59:15 +00:00
|
|
|
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
it 'closes all the issues passed' do
|
|
|
|
|
expect(project.issues.opened).to be_empty
|
|
|
|
|
expect(project.issues.closed).not_to be_empty
|
|
|
|
|
end
|
2013-05-15 13:59:15 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
|
|
describe :reopen_issues do
|
2016-05-31 21:33:18 +00:00
|
|
|
let(:issues) { create_list(:closed_issue, 5, project: project) }
|
|
|
|
|
let(:params) do
|
|
|
|
|
{
|
2015-03-06 14:01:13 +00:00
|
|
|
state_event: 'reopen',
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
issues_ids: issues.map(&:id).join(',')
|
2013-05-15 13:59:15 +00:00
|
|
|
}
|
|
|
|
|
end
|
|
|
|
|
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
it 'succeeds and returns the correct number of issues updated' do
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(result[:success]).to be_truthy
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
expect(result[:count]).to eq(issues.count)
|
2015-06-22 20:00:54 +00:00
|
|
|
end
|
2013-05-16 10:32:16 +00:00
|
|
|
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
it 'reopens all the issues passed' do
|
|
|
|
|
expect(project.issues.closed).to be_empty
|
|
|
|
|
expect(project.issues.opened).not_to be_empty
|
|
|
|
|
end
|
2013-05-16 10:32:16 +00:00
|
|
|
end
|
|
|
|
|
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
describe 'updating assignee' do
|
|
|
|
|
let(:issue) do
|
|
|
|
|
create(:issue, project: project) { |issue| issue.update_attributes(assignee: user) }
|
|
|
|
|
end
|
2013-05-16 10:32:16 +00:00
|
|
|
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
let(:params) do
|
|
|
|
|
{
|
|
|
|
|
assignee_id: assignee_id,
|
|
|
|
|
issues_ids: issue.id.to_s
|
2013-05-16 10:32:16 +00:00
|
|
|
}
|
2013-05-15 13:59:15 +00:00
|
|
|
end
|
|
|
|
|
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
context 'when the new assignee ID is a valid user' do
|
|
|
|
|
let(:new_assignee) { create(:user) }
|
|
|
|
|
let(:assignee_id) { new_assignee.id }
|
2013-05-16 10:32:16 +00:00
|
|
|
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
it 'succeeds' do
|
|
|
|
|
expect(result[:success]).to be_truthy
|
|
|
|
|
expect(result[:count]).to eq(1)
|
|
|
|
|
end
|
2013-05-15 13:59:15 +00:00
|
|
|
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
it 'updates the assignee to the use ID passed' do
|
|
|
|
|
expect(issue.reload.assignee).to eq(new_assignee)
|
|
|
|
|
end
|
|
|
|
|
end
|
2015-02-25 09:29:33 +00:00
|
|
|
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
context 'when the new assignee ID is -1' do
|
|
|
|
|
let(:assignee_id) { -1 }
|
2015-02-25 09:29:33 +00:00
|
|
|
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
it 'unassigns the issues' do
|
|
|
|
|
expect(issue.reload.assignee).to be_nil
|
|
|
|
|
end
|
2015-02-25 09:29:33 +00:00
|
|
|
end
|
|
|
|
|
|
2016-05-23 17:02:53 +00:00
|
|
|
context 'when the new assignee ID is not present' do
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
let(:assignee_id) { nil }
|
2015-02-25 09:29:33 +00:00
|
|
|
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
it 'does not unassign' do
|
|
|
|
|
expect(issue.reload.assignee).to eq(user)
|
|
|
|
|
end
|
2015-02-25 09:29:33 +00:00
|
|
|
end
|
2013-05-15 13:59:15 +00:00
|
|
|
end
|
|
|
|
|
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
describe 'updating milestones' do
|
|
|
|
|
let(:issue) { create(:issue, project: project) }
|
|
|
|
|
let(:milestone) { create(:milestone, project: project) }
|
2013-05-16 10:32:16 +00:00
|
|
|
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
let(:params) do
|
|
|
|
|
{
|
2016-06-02 16:25:44 +00:00
|
|
|
issues_ids: issue.id.to_s,
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
milestone_id: milestone.id
|
2013-05-16 10:32:16 +00:00
|
|
|
}
|
|
|
|
|
end
|
|
|
|
|
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
it 'succeeds' do
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(result[:success]).to be_truthy
|
|
|
|
|
expect(result[:count]).to eq(1)
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
end
|
2013-05-16 10:32:16 +00:00
|
|
|
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
it 'updates the issue milestone' do
|
|
|
|
|
expect(project.issues.first.milestone).to eq(milestone)
|
2015-06-22 20:00:54 +00:00
|
|
|
end
|
2013-05-15 13:59:15 +00:00
|
|
|
end
|
|
|
|
|
|
2016-05-02 15:25:21 +00:00
|
|
|
describe 'updating labels' do
|
|
|
|
|
def create_issue_with_labels(labels)
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
create(:issue, project: project) { |issue| issue.update_attributes(labels: labels) }
|
2016-05-02 15:25:21 +00:00
|
|
|
end
|
|
|
|
|
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
let(:bug) { create(:label, project: project) }
|
|
|
|
|
let(:regression) { create(:label, project: project) }
|
|
|
|
|
let(:merge_requests) { create(:label, project: project) }
|
2016-05-02 15:25:21 +00:00
|
|
|
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
let(:issue_all_labels) { create_issue_with_labels([bug, regression, merge_requests]) }
|
|
|
|
|
let(:issue_bug_and_regression) { create_issue_with_labels([bug, regression]) }
|
|
|
|
|
let(:issue_bug_and_merge_requests) { create_issue_with_labels([bug, merge_requests]) }
|
2016-05-02 15:25:21 +00:00
|
|
|
let(:issue_no_labels) { create(:issue, project: project) }
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
let(:issues) { [issue_all_labels, issue_bug_and_regression, issue_bug_and_merge_requests, issue_no_labels] }
|
2016-05-02 15:25:21 +00:00
|
|
|
|
|
|
|
|
let(:labels) { [] }
|
|
|
|
|
let(:add_labels) { [] }
|
|
|
|
|
let(:remove_labels) { [] }
|
|
|
|
|
|
|
|
|
|
let(:params) do
|
|
|
|
|
{
|
|
|
|
|
label_ids: labels.map(&:id),
|
|
|
|
|
add_label_ids: add_labels.map(&:id),
|
|
|
|
|
remove_label_ids: remove_labels.map(&:id),
|
|
|
|
|
issues_ids: issues.map(&:id).join(',')
|
|
|
|
|
}
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
context 'when label_ids are passed' do
|
|
|
|
|
let(:issues) { [issue_all_labels, issue_no_labels] }
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
let(:labels) { [bug, regression] }
|
2016-05-02 15:25:21 +00:00
|
|
|
|
|
|
|
|
it 'updates the labels of all issues passed to the labels passed' do
|
|
|
|
|
expect(issues.map(&:reload).map(&:label_ids)).to all(eq(labels.map(&:id)))
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it 'does not update issues not passed in' do
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
expect(issue_bug_and_regression.label_ids).to contain_exactly(bug.id, regression.id)
|
2016-05-02 15:25:21 +00:00
|
|
|
end
|
2016-05-31 10:14:15 +00:00
|
|
|
|
|
|
|
|
context 'when those label IDs are empty' do
|
|
|
|
|
let(:labels) { [] }
|
|
|
|
|
|
|
|
|
|
it 'updates the issues passed to have no labels' do
|
|
|
|
|
expect(issues.map(&:reload).map(&:label_ids)).to all(be_empty)
|
|
|
|
|
end
|
|
|
|
|
end
|
2016-05-02 15:25:21 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
|
|
context 'when add_label_ids are passed' do
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
let(:issues) { [issue_all_labels, issue_bug_and_merge_requests, issue_no_labels] }
|
|
|
|
|
let(:add_labels) { [bug, regression, merge_requests] }
|
2016-05-02 15:25:21 +00:00
|
|
|
|
|
|
|
|
it 'adds those label IDs to all issues passed' do
|
|
|
|
|
expect(issues.map(&:reload).map(&:label_ids)).to all(include(*add_labels.map(&:id)))
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it 'does not update issues not passed in' do
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
expect(issue_bug_and_regression.label_ids).to contain_exactly(bug.id, regression.id)
|
2016-05-02 15:25:21 +00:00
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
context 'when remove_label_ids are passed' do
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
let(:issues) { [issue_all_labels, issue_bug_and_merge_requests, issue_no_labels] }
|
|
|
|
|
let(:remove_labels) { [bug, regression, merge_requests] }
|
2016-05-02 15:25:21 +00:00
|
|
|
|
|
|
|
|
it 'removes those label IDs from all issues passed' do
|
|
|
|
|
expect(issues.map(&:reload).map(&:label_ids)).to all(be_empty)
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it 'does not update issues not passed in' do
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
expect(issue_bug_and_regression.label_ids).to contain_exactly(bug.id, regression.id)
|
2016-05-02 15:25:21 +00:00
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
context 'when add_label_ids and remove_label_ids are passed' do
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
let(:issues) { [issue_all_labels, issue_bug_and_merge_requests, issue_no_labels] }
|
|
|
|
|
let(:add_labels) { [bug] }
|
|
|
|
|
let(:remove_labels) { [merge_requests] }
|
2016-05-02 15:25:21 +00:00
|
|
|
|
|
|
|
|
it 'adds the label IDs to all issues passed' do
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
expect(issues.map(&:reload).map(&:label_ids)).to all(include(bug.id))
|
2016-05-02 15:25:21 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it 'removes the label IDs from all issues passed' do
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
expect(issues.map(&:reload).map(&:label_ids).flatten).not_to include(merge_requests.id)
|
2016-05-02 15:25:21 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it 'does not update issues not passed in' do
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
expect(issue_bug_and_regression.label_ids).to contain_exactly(bug.id, regression.id)
|
2016-05-02 15:25:21 +00:00
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
context 'when add_label_ids and label_ids are passed' do
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
let(:issues) { [issue_all_labels, issue_bug_and_regression, issue_bug_and_merge_requests] }
|
|
|
|
|
let(:labels) { [merge_requests] }
|
|
|
|
|
let(:add_labels) { [regression] }
|
2016-05-02 15:25:21 +00:00
|
|
|
|
|
|
|
|
it 'adds the label IDs to all issues passed' do
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
expect(issues.map(&:reload).map(&:label_ids)).to all(include(regression.id))
|
2016-05-02 15:25:21 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it 'ignores the label IDs parameter' do
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
expect(issues.map(&:reload).map(&:label_ids)).to all(include(bug.id))
|
2016-05-02 15:25:21 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it 'does not update issues not passed in' do
|
|
|
|
|
expect(issue_no_labels.label_ids).to be_empty
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
context 'when remove_label_ids and label_ids are passed' do
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
let(:issues) { [issue_no_labels, issue_bug_and_regression] }
|
|
|
|
|
let(:labels) { [merge_requests] }
|
|
|
|
|
let(:remove_labels) { [regression] }
|
2016-05-02 15:25:21 +00:00
|
|
|
|
|
|
|
|
it 'remove the label IDs from all issues passed' do
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
expect(issues.map(&:reload).map(&:label_ids).flatten).not_to include(regression.id)
|
2016-05-02 15:25:21 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it 'ignores the label IDs parameter' do
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
expect(issues.map(&:reload).map(&:label_ids).flatten).not_to include(merge_requests.id)
|
2016-05-02 15:25:21 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it 'does not update issues not passed in' do
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
expect(issue_all_labels.label_ids).to contain_exactly(bug.id, regression.id, merge_requests.id)
|
2016-05-02 15:25:21 +00:00
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
context 'when add_label_ids, remove_label_ids, and label_ids are passed' do
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
let(:issues) { [issue_bug_and_merge_requests, issue_no_labels] }
|
|
|
|
|
let(:labels) { [regression] }
|
|
|
|
|
let(:add_labels) { [bug] }
|
|
|
|
|
let(:remove_labels) { [merge_requests] }
|
2016-05-02 15:25:21 +00:00
|
|
|
|
|
|
|
|
it 'adds the label IDs to all issues passed' do
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
expect(issues.map(&:reload).map(&:label_ids)).to all(include(bug.id))
|
2016-05-02 15:25:21 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it 'removes the label IDs from all issues passed' do
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
expect(issues.map(&:reload).map(&:label_ids).flatten).not_to include(merge_requests.id)
|
2016-05-02 15:25:21 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it 'ignores the label IDs parameter' do
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
expect(issues.map(&:reload).map(&:label_ids).flatten).not_to include(regression.id)
|
2016-05-02 15:25:21 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it 'does not update issues not passed in' do
|
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-05-02 16:36:25 +00:00
|
|
|
expect(issue_bug_and_regression.label_ids).to contain_exactly(bug.id, regression.id)
|
2016-05-02 15:25:21 +00:00
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
end
|
2016-07-12 23:18:13 +00:00
|
|
|
|
|
|
|
|
describe :subscribe_issues do
|
|
|
|
|
let(:issues) { create_list(:issue, 5, project: project) }
|
|
|
|
|
let(:params) do
|
|
|
|
|
{
|
|
|
|
|
subscription_event: 'subscribe',
|
|
|
|
|
issues_ids: issues.map(&:id).join(',')
|
|
|
|
|
}
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it 'subscribes the given user' do
|
|
|
|
|
issues.each do |issue|
|
|
|
|
|
expect(issue.subscribed?(user)).to be_truthy
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
describe :unsubscribe_issues do
|
|
|
|
|
let(:issues) { create_list(:closed_issue, 5, project: project) }
|
|
|
|
|
let(:params) do
|
|
|
|
|
{
|
|
|
|
|
subscription_event: 'unsubscribe',
|
|
|
|
|
issues_ids: issues.map(&:id).join(',')
|
|
|
|
|
}
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
before do
|
|
|
|
|
issues.each do |issue|
|
|
|
|
|
issue.subscriptions.create(user: user, subscribed: true)
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it 'unsubscribes the given user' do
|
|
|
|
|
issues.each do |issue|
|
|
|
|
|
expect(issue.subscribed?(user)).to be_falsey
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
end
|
2013-05-16 10:32:16 +00:00
|
|
|
end
|
