2012-10-09 04:14:17 -04:00
|
|
|
# == Schema Information
|
|
|
|
#
|
|
|
|
# Table name: notes
|
|
|
|
#
|
2012-11-19 13:24:05 -05:00
|
|
|
# id :integer not null, primary key
|
2012-10-09 04:14:17 -04:00
|
|
|
# note :text
|
|
|
|
# noteable_type :string(255)
|
|
|
|
# author_id :integer
|
2012-11-19 13:24:05 -05:00
|
|
|
# created_at :datetime not null
|
|
|
|
# updated_at :datetime not null
|
2012-10-09 04:14:17 -04:00
|
|
|
# project_id :integer
|
|
|
|
# attachment :string(255)
|
|
|
|
# line_code :string(255)
|
2013-01-03 14:09:18 -05:00
|
|
|
# commit_id :string(255)
|
|
|
|
# noteable_id :integer
|
2012-10-09 04:14:17 -04:00
|
|
|
#
|
|
|
|
|
2011-10-08 17:36:38 -04:00
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe Note do
|
|
|
|
describe "Associations" do
|
|
|
|
it { should belong_to(:project) }
|
2012-08-29 11:36:02 -04:00
|
|
|
it { should belong_to(:noteable) }
|
|
|
|
it { should belong_to(:author).class_name('User') }
|
2011-10-08 17:36:38 -04:00
|
|
|
end
|
|
|
|
|
2012-09-26 14:17:17 -04:00
|
|
|
describe "Mass assignment" do
|
|
|
|
it { should_not allow_mass_assignment_of(:author) }
|
|
|
|
it { should_not allow_mass_assignment_of(:author_id) }
|
|
|
|
end
|
|
|
|
|
2011-10-08 17:36:38 -04:00
|
|
|
describe "Validation" do
|
|
|
|
it { should validate_presence_of(:note) }
|
|
|
|
it { should validate_presence_of(:project) }
|
|
|
|
end
|
|
|
|
|
2011-11-18 01:52:13 -05:00
|
|
|
describe "Scopes" do
|
|
|
|
it "should have a today named scope that returns ..." do
|
|
|
|
Note.today.where_values.should == ["created_at >= '#{Date.today}'"]
|
|
|
|
end
|
|
|
|
end
|
2012-01-21 07:54:32 -05:00
|
|
|
|
2012-03-14 09:31:31 -04:00
|
|
|
describe "Voting score" do
|
2012-11-05 22:31:55 -05:00
|
|
|
let(:project) { create(:project) }
|
2012-03-14 09:31:31 -04:00
|
|
|
|
|
|
|
it "recognizes a neutral note" do
|
2012-11-05 22:31:55 -05:00
|
|
|
note = create(:note, note: "This is not a +1 note")
|
2012-03-14 09:31:31 -04:00
|
|
|
note.should_not be_upvote
|
2012-09-07 20:08:35 -04:00
|
|
|
note.should_not be_downvote
|
|
|
|
end
|
|
|
|
|
|
|
|
it "recognizes a neutral emoji note" do
|
|
|
|
note = build(:note, note: "I would :+1: this, but I don't want to")
|
|
|
|
note.should_not be_upvote
|
|
|
|
note.should_not be_downvote
|
2012-03-14 09:31:31 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "recognizes a +1 note" do
|
2012-11-05 22:31:55 -05:00
|
|
|
note = create(:note, note: "+1 for this")
|
2012-03-14 09:31:31 -04:00
|
|
|
note.should be_upvote
|
|
|
|
end
|
|
|
|
|
2012-09-06 15:31:25 -04:00
|
|
|
it "recognizes a +1 emoji as a vote" do
|
|
|
|
note = build(:note, note: ":+1: for this")
|
|
|
|
note.should be_upvote
|
|
|
|
end
|
|
|
|
|
2012-09-07 20:08:35 -04:00
|
|
|
it "recognizes a -1 note" do
|
2012-11-05 22:31:55 -05:00
|
|
|
note = create(:note, note: "-1 for this")
|
2012-09-07 20:08:35 -04:00
|
|
|
note.should be_downvote
|
|
|
|
end
|
|
|
|
|
|
|
|
it "recognizes a -1 emoji as a vote" do
|
|
|
|
note = build(:note, note: ":-1: for this")
|
|
|
|
note.should be_downvote
|
2012-09-06 15:31:25 -04:00
|
|
|
end
|
2012-03-14 09:31:31 -04:00
|
|
|
end
|
|
|
|
|
2012-08-28 07:01:27 -04:00
|
|
|
let(:project) { create(:project) }
|
|
|
|
let(:commit) { project.commit }
|
2012-03-14 09:31:31 -04:00
|
|
|
|
2012-08-28 07:01:27 -04:00
|
|
|
describe "Commit notes" do
|
2012-03-14 09:31:31 -04:00
|
|
|
before do
|
2012-11-05 22:31:55 -05:00
|
|
|
@note = create(:note,
|
2012-12-18 13:02:00 -05:00
|
|
|
commit_id: commit.id,
|
2012-11-05 22:31:55 -05:00
|
|
|
noteable_type: "Commit")
|
2012-01-21 07:54:32 -05:00
|
|
|
end
|
|
|
|
|
2012-10-13 10:23:12 -04:00
|
|
|
it "should be accessible through #noteable" do
|
2012-12-18 13:02:00 -05:00
|
|
|
@note.commit_id.should == commit.id
|
2012-10-13 10:23:12 -04:00
|
|
|
@note.noteable.should be_a(Commit)
|
|
|
|
@note.noteable.should == commit
|
|
|
|
end
|
|
|
|
|
2012-01-21 07:54:32 -05:00
|
|
|
it "should save a valid note" do
|
2012-12-18 13:02:00 -05:00
|
|
|
@note.commit_id.should == commit.id
|
2012-10-13 10:23:12 -04:00
|
|
|
@note.noteable == commit
|
|
|
|
end
|
|
|
|
|
|
|
|
it "should be recognized by #for_commit?" do
|
|
|
|
@note.should be_for_commit
|
2012-01-21 07:54:32 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2012-03-14 09:31:31 -04:00
|
|
|
describe "Pre-line commit notes" do
|
|
|
|
before do
|
2012-11-05 22:31:55 -05:00
|
|
|
@note = create(:note,
|
2012-12-18 13:02:00 -05:00
|
|
|
commit_id: commit.id,
|
2012-11-05 22:31:55 -05:00
|
|
|
noteable_type: "Commit",
|
|
|
|
line_code: "0_16_1")
|
2012-01-21 07:54:32 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it "should save a valid note" do
|
2012-12-18 13:02:00 -05:00
|
|
|
@note.commit_id.should == commit.id
|
2012-10-13 10:23:12 -04:00
|
|
|
@note.noteable.id.should == commit.id
|
|
|
|
end
|
|
|
|
|
|
|
|
it "should be recognized by #for_diff_line?" do
|
|
|
|
@note.should be_for_diff_line
|
2012-01-21 07:54:32 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2012-05-20 14:35:03 -04:00
|
|
|
describe '#create_status_change_note' do
|
2012-11-05 22:31:55 -05:00
|
|
|
let(:project) { create(:project) }
|
|
|
|
let(:thing) { create(:issue, project: project) }
|
|
|
|
let(:author) { create(:user) }
|
2012-05-20 14:35:03 -04:00
|
|
|
let(:status) { 'new_status' }
|
|
|
|
|
|
|
|
subject { Note.create_status_change_note(thing, author, status) }
|
|
|
|
|
|
|
|
it 'creates and saves a Note' do
|
|
|
|
should be_a Note
|
|
|
|
subject.id.should_not be_nil
|
|
|
|
end
|
|
|
|
|
|
|
|
its(:noteable) { should == thing }
|
|
|
|
its(:project) { should == thing.project }
|
|
|
|
its(:author) { should == author }
|
|
|
|
its(:note) { should =~ /Status changed to #{status}/ }
|
|
|
|
end
|
|
|
|
|
2011-10-26 09:46:25 -04:00
|
|
|
describe :authorization do
|
|
|
|
before do
|
2012-08-28 07:01:27 -04:00
|
|
|
@p1 = create(:project)
|
2012-11-05 22:31:55 -05:00
|
|
|
@p2 = create(:project)
|
|
|
|
@u1 = create(:user)
|
|
|
|
@u2 = create(:user)
|
|
|
|
@u3 = create(:user)
|
2011-10-08 17:36:38 -04:00
|
|
|
@abilities = Six.new
|
|
|
|
@abilities << Ability
|
|
|
|
end
|
|
|
|
|
2011-10-26 09:46:25 -04:00
|
|
|
describe :read do
|
|
|
|
before do
|
2012-08-10 18:07:50 -04:00
|
|
|
@p1.users_projects.create(user: @u2, project_access: UsersProject::GUEST)
|
|
|
|
@p2.users_projects.create(user: @u3, project_access: UsersProject::GUEST)
|
2011-10-08 17:36:38 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it { @abilities.allowed?(@u1, :read_note, @p1).should be_false }
|
|
|
|
it { @abilities.allowed?(@u2, :read_note, @p1).should be_true }
|
|
|
|
it { @abilities.allowed?(@u3, :read_note, @p1).should be_false }
|
|
|
|
end
|
|
|
|
|
2011-10-26 09:46:25 -04:00
|
|
|
describe :write do
|
|
|
|
before do
|
2012-08-10 18:07:50 -04:00
|
|
|
@p1.users_projects.create(user: @u2, project_access: UsersProject::DEVELOPER)
|
|
|
|
@p2.users_projects.create(user: @u3, project_access: UsersProject::DEVELOPER)
|
2011-10-08 17:36:38 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it { @abilities.allowed?(@u1, :write_note, @p1).should be_false }
|
|
|
|
it { @abilities.allowed?(@u2, :write_note, @p1).should be_true }
|
|
|
|
it { @abilities.allowed?(@u3, :write_note, @p1).should be_false }
|
|
|
|
end
|
|
|
|
|
2011-10-26 09:46:25 -04:00
|
|
|
describe :admin do
|
|
|
|
before do
|
2012-08-10 18:07:50 -04:00
|
|
|
@p1.users_projects.create(user: @u1, project_access: UsersProject::REPORTER)
|
|
|
|
@p1.users_projects.create(user: @u2, project_access: UsersProject::MASTER)
|
|
|
|
@p2.users_projects.create(user: @u3, project_access: UsersProject::MASTER)
|
2011-10-08 17:36:38 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it { @abilities.allowed?(@u1, :admin_note, @p1).should be_false }
|
|
|
|
it { @abilities.allowed?(@u2, :admin_note, @p1).should be_true }
|
|
|
|
it { @abilities.allowed?(@u3, :admin_note, @p1).should be_false }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|