kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Don't fail the pipeline when a colon-emoji is used

Browse source 
A colon-emoji like 💯 can be valid in the case where we're talking
about the GitLab feature that processes these into emojis. It's fine to
warn about those, but failing the pipeline is too restrictive.
This commit is contained in:
Sean McGivern 2019-06-06 19:14:08 +01:00
parent 70a717daf9
commit 1b2de25dee
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
danger/commit_messages/Dangerfile
View file

@ -163,10 +163,10 @@ def lint_commit(commit)
end end
if emoji_checker.includes_emoji?(commit.message) if emoji_checker.includes_emoji?(commit.message)
fail_commit( warn_commit(
commit, commit,
'Avoid the use of Markdown Emoji such as `:+1:`. ' \ 'Avoid the use of Markdown Emoji such as `:+1:`. ' \
'These add no value to the commit message, ' \ 'These add limited value to the commit message, ' \
'and are displayed as plain text outside of GitLab' 'and are displayed as plain text outside of GitLab'
) )