updated relation_factory based on MR feedback
This commit is contained in:
parent
7779457907
commit
279412f90a
|
@ -57,11 +57,11 @@ module Gitlab
|
||||||
|
|
||||||
author = @relation_hash.delete('author')
|
author = @relation_hash.delete('author')
|
||||||
|
|
||||||
update_note_for_missing_author(author['name']) if can_update_notes?
|
update_note_for_missing_author(author['name']) if missing_author?
|
||||||
end
|
end
|
||||||
|
|
||||||
def can_update_notes?
|
def missing_author?
|
||||||
(admin_user? && @members_mapper.missing_author_ids.include?(old_author_id)) || !admin_user?
|
!admin_user? || @members_mapper.missing_author_ids.include?(old_author_id)
|
||||||
end
|
end
|
||||||
|
|
||||||
def missing_author_note(updated_at, author_name)
|
def missing_author_note(updated_at, author_name)
|
||||||
|
|
Loading…
Reference in New Issue