kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Add a soft SLA for reviewers and maintainers

Browse source 
By setting expectations both the contributor and reviewer have more
certainty on what gets reviewed when, and at what speed changes could be
merged.
This commit is contained in:
Zeger-Jan van de Weg 2019-02-13 12:10:29 +01:00
parent a772e01051
commit 341556816c
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
doc/development/code_review.md
View file

@ -132,6 +132,13 @@ If a developer who happens to also be a maintainer was involved in a merge reque
as a domain expert and/or reviewer, it is recommended that they are not also picked
as the maintainer to ultimately approve and merge it.
Try to review in a timely manner; doing so allows everyone involved in the merge
request to iterate faster as the context is fresh in memory. Further, this
improves contributors' experiences significantly. Provided full availability;
reviewing within two work days should be the aim. If you don't think you'll be
able to review a merge request within that time, let the author know as soon as
possible.
Maintainers should check before merging if the merge request is approved by the
required approvers.