Add failing feature spec detailing a maintainer creating a subgroup

- Change the two existing feature examples that create a subgroup to
  elucidate that the owner is creating the subgroup

- Nest two more specs inside the 'subgroup support' context detailing
  what happens when a maintainer attempts to add a subgroup (one with
  subgroup support, and one without)
This commit is contained in:
Fabio Papa 2019-06-14 15:16:55 -07:00
parent 7b958537fd
commit 3cbca3776c

View file

@ -56,32 +56,67 @@ describe 'Group show page' do
end
context 'subgroup support' do
let(:user) { create(:user) }
let(:owner) { create(:user) }
let(:maintainer) { create(:user) }
before do
group.add_owner(user)
sign_in(user)
group.add_owner(owner)
group.add_maintainer(maintainer)
end
context 'when subgroups are supported', :js, :nested_groups do
context 'for owners' do
before do
allow(Group).to receive(:supports_nested_objects?) { true }
visit path
sign_in(owner)
end
it 'allows creating subgroups' do
expect(page).to have_css("li[data-text='New subgroup']", visible: false)
context 'when subgroups are supported', :js, :nested_groups do
before do
allow(Group).to receive(:supports_nested_objects?) { true }
visit path
end
it 'allows creating subgroups' do
expect(page).to have_css("li[data-text='New subgroup']", visible: false)
end
end
context 'when subgroups are not supported' do
before do
allow(Group).to receive(:supports_nested_objects?) { false }
visit path
end
it 'allows creating subgroups' do
expect(page).not_to have_selector("li[data-text='New subgroup']", visible: false)
end
end
end
context 'when subgroups are not supported' do
context 'for maintainers' do
before do
allow(Group).to receive(:supports_nested_objects?) { false }
visit path
sign_in(maintainer)
end
it 'allows creating subgroups' do
expect(page).not_to have_selector("li[data-text='New subgroup']", visible: false)
context 'when subgroups are supported', :js, :nested_groups do
before do
allow(Group).to receive(:supports_nested_objects?) { true }
visit path
end
it 'allows creating subgroups' do
expect(page).to have_css("li[data-text='New subgroup']", visible: false)
end
end
context 'when subgroups are not supported' do
before do
allow(Group).to receive(:supports_nested_objects?) { false }
visit path
end
it 'allows creating subgroups' do
expect(page).not_to have_selector("li[data-text='New subgroup']", visible: false)
end
end
end
end