kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Merge branch 'remove-require-from-services' into 'master' 

Remove unnecessary require_relative calls from service classes.

See merge request !7601
This commit is contained in:
Robert Speicher 2016-11-22 07:36:42 +00:00
parent 35d6ea4f5e 724864eeb4
commit 60c2d59072
16 changed files with 4 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/services/after_branch_delete_service.rb
View File

@ -1,5 +1,3 @@
require_relative 'base_service'
##
# Branch can be deleted either by DeleteBranchService
# or by GitPushService.

2
app/services/create_branch_service.rb
View File

@ -1,5 +1,3 @@
require_relative 'base_service'
class CreateBranchService < BaseService
def execute(branch_name, ref, source_project: @project)
valid_branch = Gitlab::GitRefValidator.validate(branch_name)

2
app/services/create_deployment_service.rb
View File

@ -1,5 +1,3 @@
require_relative 'base_service'
class CreateDeploymentService < BaseService
def execute(deployable = nil)
return unless executable?

2
app/services/create_release_service.rb
View File

@ -1,5 +1,3 @@
require_relative 'base_service'
class CreateReleaseService < BaseService
def execute(tag_name, release_description)
repository = project.repository

2
app/services/create_tag_service.rb
View File

@ -1,5 +1,3 @@
require_relative 'base_service'
class CreateTagService < BaseService
def execute(tag_name, target, message, release_description = nil)
valid_tag = Gitlab::GitRefValidator.validate(tag_name)

2
app/services/delete_branch_service.rb
View File

@ -1,5 +1,3 @@
require_relative 'base_service'
class DeleteBranchService < BaseService
def execute(branch_name)
repository = project.repository

2
app/services/delete_merged_branches_service.rb
View File

@ -1,5 +1,3 @@
require_relative 'base_service'
class DeleteMergedBranchesService < BaseService
def async_execute
DeleteMergedBranchesWorker.perform_async(project.id, current_user.id)

2
app/services/delete_tag_service.rb
View File

@ -1,5 +1,3 @@
require_relative 'base_service'
class DeleteTagService < BaseService
def execute(tag_name)
repository = project.repository

2
app/services/files/create_dir_service.rb
View File

@ -1,5 +1,3 @@
require_relative "base_service"
module Files
class CreateDirService < Files::BaseService
def commit

2
app/services/files/create_service.rb
View File

@ -1,5 +1,3 @@
require_relative "base_service"
module Files
class CreateService < Files::BaseService
def commit

2
app/services/files/delete_service.rb
View File

@ -1,5 +1,3 @@
require_relative "base_service"
module Files
class DeleteService < Files::BaseService
def commit

2
app/services/files/multi_service.rb
View File

@ -1,5 +1,3 @@
require_relative "base_service"
module Files
class MultiService < Files::BaseService
class FileChangedError < StandardError; end

2
app/services/files/update_service.rb
View File

@ -1,5 +1,3 @@
require_relative "base_service"
module Files
class UpdateService < Files::BaseService
class FileChangedError < StandardError; end

4
app/services/merge_requests/update_service.rb
View File

@ -1,7 +1,3 @@
require_relative 'base_service'
require_relative 'reopen_service'
require_relative 'close_service'
module MergeRequests
class UpdateService < MergeRequests::BaseService
def execute(merge_request)

2
app/services/update_release_service.rb
View File

@ -1,5 +1,3 @@
require_relative 'base_service'
class UpdateReleaseService < BaseService
def execute(tag_name, release_description)
repository = project.repository

4
changelogs/unreleased/remove-require-from-services.yml Normal file
View File

@ -0,0 +1,4 @@
---
title: 'Remove unnecessary require_relative calls from service classes'
merge_request: '7601'
author: Semyon Pupkov