Merge branch 'remove-require-from-services' into 'master'
Remove unnecessary require_relative calls from service classes. See merge request !7601
This commit is contained in:
commit
60c2d59072
|
@ -1,5 +1,3 @@
|
||||||
require_relative 'base_service'
|
|
||||||
|
|
||||||
##
|
##
|
||||||
# Branch can be deleted either by DeleteBranchService
|
# Branch can be deleted either by DeleteBranchService
|
||||||
# or by GitPushService.
|
# or by GitPushService.
|
||||||
|
|
|
@ -1,5 +1,3 @@
|
||||||
require_relative 'base_service'
|
|
||||||
|
|
||||||
class CreateBranchService < BaseService
|
class CreateBranchService < BaseService
|
||||||
def execute(branch_name, ref, source_project: @project)
|
def execute(branch_name, ref, source_project: @project)
|
||||||
valid_branch = Gitlab::GitRefValidator.validate(branch_name)
|
valid_branch = Gitlab::GitRefValidator.validate(branch_name)
|
||||||
|
|
|
@ -1,5 +1,3 @@
|
||||||
require_relative 'base_service'
|
|
||||||
|
|
||||||
class CreateDeploymentService < BaseService
|
class CreateDeploymentService < BaseService
|
||||||
def execute(deployable = nil)
|
def execute(deployable = nil)
|
||||||
return unless executable?
|
return unless executable?
|
||||||
|
|
|
@ -1,5 +1,3 @@
|
||||||
require_relative 'base_service'
|
|
||||||
|
|
||||||
class CreateReleaseService < BaseService
|
class CreateReleaseService < BaseService
|
||||||
def execute(tag_name, release_description)
|
def execute(tag_name, release_description)
|
||||||
repository = project.repository
|
repository = project.repository
|
||||||
|
|
|
@ -1,5 +1,3 @@
|
||||||
require_relative 'base_service'
|
|
||||||
|
|
||||||
class CreateTagService < BaseService
|
class CreateTagService < BaseService
|
||||||
def execute(tag_name, target, message, release_description = nil)
|
def execute(tag_name, target, message, release_description = nil)
|
||||||
valid_tag = Gitlab::GitRefValidator.validate(tag_name)
|
valid_tag = Gitlab::GitRefValidator.validate(tag_name)
|
||||||
|
|
|
@ -1,5 +1,3 @@
|
||||||
require_relative 'base_service'
|
|
||||||
|
|
||||||
class DeleteBranchService < BaseService
|
class DeleteBranchService < BaseService
|
||||||
def execute(branch_name)
|
def execute(branch_name)
|
||||||
repository = project.repository
|
repository = project.repository
|
||||||
|
|
|
@ -1,5 +1,3 @@
|
||||||
require_relative 'base_service'
|
|
||||||
|
|
||||||
class DeleteMergedBranchesService < BaseService
|
class DeleteMergedBranchesService < BaseService
|
||||||
def async_execute
|
def async_execute
|
||||||
DeleteMergedBranchesWorker.perform_async(project.id, current_user.id)
|
DeleteMergedBranchesWorker.perform_async(project.id, current_user.id)
|
||||||
|
|
|
@ -1,5 +1,3 @@
|
||||||
require_relative 'base_service'
|
|
||||||
|
|
||||||
class DeleteTagService < BaseService
|
class DeleteTagService < BaseService
|
||||||
def execute(tag_name)
|
def execute(tag_name)
|
||||||
repository = project.repository
|
repository = project.repository
|
||||||
|
|
|
@ -1,5 +1,3 @@
|
||||||
require_relative "base_service"
|
|
||||||
|
|
||||||
module Files
|
module Files
|
||||||
class CreateDirService < Files::BaseService
|
class CreateDirService < Files::BaseService
|
||||||
def commit
|
def commit
|
||||||
|
|
|
@ -1,5 +1,3 @@
|
||||||
require_relative "base_service"
|
|
||||||
|
|
||||||
module Files
|
module Files
|
||||||
class CreateService < Files::BaseService
|
class CreateService < Files::BaseService
|
||||||
def commit
|
def commit
|
||||||
|
|
|
@ -1,5 +1,3 @@
|
||||||
require_relative "base_service"
|
|
||||||
|
|
||||||
module Files
|
module Files
|
||||||
class DeleteService < Files::BaseService
|
class DeleteService < Files::BaseService
|
||||||
def commit
|
def commit
|
||||||
|
|
|
@ -1,5 +1,3 @@
|
||||||
require_relative "base_service"
|
|
||||||
|
|
||||||
module Files
|
module Files
|
||||||
class MultiService < Files::BaseService
|
class MultiService < Files::BaseService
|
||||||
class FileChangedError < StandardError; end
|
class FileChangedError < StandardError; end
|
||||||
|
|
|
@ -1,5 +1,3 @@
|
||||||
require_relative "base_service"
|
|
||||||
|
|
||||||
module Files
|
module Files
|
||||||
class UpdateService < Files::BaseService
|
class UpdateService < Files::BaseService
|
||||||
class FileChangedError < StandardError; end
|
class FileChangedError < StandardError; end
|
||||||
|
|
|
@ -1,7 +1,3 @@
|
||||||
require_relative 'base_service'
|
|
||||||
require_relative 'reopen_service'
|
|
||||||
require_relative 'close_service'
|
|
||||||
|
|
||||||
module MergeRequests
|
module MergeRequests
|
||||||
class UpdateService < MergeRequests::BaseService
|
class UpdateService < MergeRequests::BaseService
|
||||||
def execute(merge_request)
|
def execute(merge_request)
|
||||||
|
|
|
@ -1,5 +1,3 @@
|
||||||
require_relative 'base_service'
|
|
||||||
|
|
||||||
class UpdateReleaseService < BaseService
|
class UpdateReleaseService < BaseService
|
||||||
def execute(tag_name, release_description)
|
def execute(tag_name, release_description)
|
||||||
repository = project.repository
|
repository = project.repository
|
||||||
|
|
|
@ -0,0 +1,4 @@
|
||||||
|
---
|
||||||
|
title: 'Remove unnecessary require_relative calls from service classes'
|
||||||
|
merge_request: '7601'
|
||||||
|
author: Semyon Pupkov
|
Loading…
Reference in New Issue