Fix bug where form's `novalidate` attribute is not respected

2017-05-25 15:05:51 +05:30 · 2017-05-25 15:05:51 +05:30 · 69c47658c7
parent c5e28a7b41
commit 69c47658c7
1 changed files with 7 additions and 3 deletions
--- a/app/assets/javascripts/gl_field_errors.js
+++ b/app/assets/javascripts/gl_field_errors.js
@ -31,9 +31,13 @@ class GlFieldErrors {
   * and prevents disabling of invalid submit button by application.js */

  catchInvalidFormSubmit (event) {
-    if (!event.currentTarget.checkValidity()) {
-      event.preventDefault();
-      event.stopPropagation();
+    const $form = $(event.currentTarget);
+
+    if (!$form.attr('novalidate')) {
+      if (!event.currentTarget.checkValidity()) {
+        event.preventDefault();
+        event.stopPropagation();
+      }
    }
  }