Merge branch 'bvl-remove-sha-from-help' into 'master'

Link to the tag from a version instead of commit

Closes gitlab-org/release/tasks#459

See merge request gitlab-org/gitlab-ce!22015

app/views/help/index.html.haml

@@ -7,8 +7,7 @@
   GitLab
   Community Edition
   - if user_signed_in?
-    %span= Gitlab::VERSION
-    %small= link_to Gitlab.revision, Gitlab::COM_URL + namespace_project_commits_path('gitlab-org', 'gitlab-ce', Gitlab.revision)
+    %span= link_to Gitlab::VERSION, Gitlab::COM_URL + namespace_project_tag_path('gitlab-org', 'gitlab-ce', "v#{Gitlab::VERSION}")
     = version_status_badge
   %hr
 

changelogs/unreleased/bvl-remove-sha-from-help.yml

@@ -0,0 +1,5 @@
+---
+title: Link to the tag for a version on the help page instead of to the commit
+merge_request: 22015
+author:
+type: changed

spec/views/help/index.html.haml_spec.rb

@@ -21,7 +21,7 @@ describe 'help/index' do
       render
 
       expect(rendered).to match '8.0.2'
-      expect(rendered).to have_link('abcdefg', href: 'https://gitlab.com/gitlab-org/gitlab-ce/commits/abcdefg')
+      expect(rendered).to have_link('8.0.2', href: 'https://gitlab.com/gitlab-org/gitlab-ce/tags/v8.0.2')
     end
   end