Use run_after_commit to avoid race condition, feedback:

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6342/diffs#note_17038749
2016-10-17 18:09:43 +08:00 · 2016-10-17 18:09:43 +08:00 · b4e751557a
commit b4e751557a
parent 98217bc067
1 changed files with 3 additions and 1 deletions
--- a/app/models/ci/pipeline.rb
+++ b/app/models/ci/pipeline.rb
@ -84,7 +84,9 @@ module Ci
      end

      after_transition any => [:success, :failed] do |pipeline|
-        SendPipelineNotificationWorker.perform_async(pipeline.id)
+        pipeline.run_after_commit do
+          SendPipelineNotificationWorker.perform_async(pipeline.id)
+        end
      end
    end