Fix popen bug in rake gitlab:satellites:create

The Satellite#create method no longer sets the `$?` global variable.
Instead, we can use the method return value to test if the satellite was
created successfully
This commit is contained in:
Jacob Vosmaer 2014-04-07 11:17:55 +02:00
parent bfd4494890
commit bcfd9386f5
2 changed files with 3 additions and 5 deletions

View file

@ -8,6 +8,7 @@ v 6.8.0
- Create branches via API (sponsored by O'Reilly Media)
- Changed permission of gitlab-satellites directory not to be world accessible
- Protected branch does not allow force push
- Fix popen bug in `rake gitlab:satellites:create`
v 6.7.3
- Fix the merge notification email not being sent (Pierre de La Morinerie)

View file

@ -27,11 +27,8 @@ namespace :gitlab do
if project.satellite.exists?
puts "exists already".green
else
puts ""
project.satellite.create
print "... "
if $?.success?
print "\n... "
if project.satellite.create
puts "created".green
else
puts "error".red