Fix popen bug in `rake gitlab:satellites:create`
The Satellite#create method no longer sets the `$?` global variable. Instead, we can use the method return value to test if the satellite was created successfully
This commit is contained in:
parent
bfd4494890
commit
bcfd9386f5
|
@ -8,6 +8,7 @@ v 6.8.0
|
||||||
- Create branches via API (sponsored by O'Reilly Media)
|
- Create branches via API (sponsored by O'Reilly Media)
|
||||||
- Changed permission of gitlab-satellites directory not to be world accessible
|
- Changed permission of gitlab-satellites directory not to be world accessible
|
||||||
- Protected branch does not allow force push
|
- Protected branch does not allow force push
|
||||||
|
- Fix popen bug in `rake gitlab:satellites:create`
|
||||||
|
|
||||||
v 6.7.3
|
v 6.7.3
|
||||||
- Fix the merge notification email not being sent (Pierre de La Morinerie)
|
- Fix the merge notification email not being sent (Pierre de La Morinerie)
|
||||||
|
|
|
@ -27,11 +27,8 @@ namespace :gitlab do
|
||||||
if project.satellite.exists?
|
if project.satellite.exists?
|
||||||
puts "exists already".green
|
puts "exists already".green
|
||||||
else
|
else
|
||||||
puts ""
|
print "\n... "
|
||||||
project.satellite.create
|
if project.satellite.create
|
||||||
|
|
||||||
print "... "
|
|
||||||
if $?.success?
|
|
||||||
puts "created".green
|
puts "created".green
|
||||||
else
|
else
|
||||||
puts "error".red
|
puts "error".red
|
||||||
|
|
Loading…
Reference in New Issue