kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Merge branch 'dz-sidekiq-remove-queue' into 'master' 

Update sidekiq style guide with rename/remove queue instructions

Closes #34223

See merge request !13009
This commit is contained in:
Sean McGivern 2017-07-21 18:50:42 +00:00
parent 2209426f7b 921e5ab0e1
commit f23d74345a
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
doc/development/sidekiq_style_guide.md
View File

@ -36,3 +36,10 @@ slow jobs blocking work (even for different jobs) on the shared queue.
Each Sidekiq worker must be tested using RSpec, just like any other class. These
tests should be placed in `spec/workers`.
## Removing or renaming queues
Try to avoid renaming or removing queues in minor and patch releases.
During online update instance can have pending jobs and removing the queue can
lead to those jobs being stuck forever. If you can't write migration for those
Sidekiq jobs, please consider doing rename or remove queue in major release only.