Merge branch 'todo-update-order' into 'master'

Remove unnecessary ORDER BY clause when updating todos

See merge request !10399

app/services/todo_service.rb

@@ -204,7 +204,7 @@ class TodoService
     # Only update those that are not really on that state
     todos = todos.where.not(state: state)
     todos_ids = todos.pluck(:id)
-    todos.update_all(state: state)
+    todos.unscope(:order).update_all(state: state)
     current_user.update_todos_count_cache
     todos_ids
   end

changelogs/unreleased/todo-update-order.yml

@@ -0,0 +1,4 @@
+---
+title: Remove unnecessary ORDER BY clause when updating todos
+merge_request:
+author: mhasbini